Ubuntu
location-service package

Not yet available but configured providers should be added as soon as they become available

Bug #1415029 reported by Thomas Voß
36
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
John McAleely
Canonical System Image ww02-2016 "ota9"
location-service (Ubuntu)
In Progress
Critical
Thomas Voß
ubuntu-location-provider-here (Ubuntu)
Fix Released
High
Loïc Minier
ubuntu-location-provider-here (Ubuntu RTM)
Fix Released
Undecided
Unassigned
ubuntu-system-settings (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

Right now, the location service tries to instantiate configured providers at startup. In specific corner cases, some of the configured sensors might not be available and the service should be able to be notified when those providers become available.

In particular, this affects the wizard running on first boot, and subsequent login to the user session.

See original description
Tags: location

Related branches

lp://staging/~lool/ubuntu-location-provider-here/lp-1415029
Thomas Voß (community): Approve
Diff: 14 lines (+5/-0)
1 file modified
etc/init/ubuntu-location-provider-here-after-wizard.conf (+5/-0)
lp://staging/~ssweeny/location-service/async-providers.15.04
Thomas Voß (community): Approve (code)
Diff: 622 lines (+412/-40)
13 files modified
examples/service/service.cpp (+14/-15)
include/location_service/com/ubuntu/location/provider_factory.h (+3/-0)
src/location_service/com/ubuntu/location/provider_factory.cpp (+14/-0)
src/location_service/com/ubuntu/location/providers/config.cpp (+7/-0)
src/location_service/com/ubuntu/location/providers/dummy/CMakeLists.txt (+3/-1)
src/location_service/com/ubuntu/location/providers/dummy/delayed_provider.cpp (+42/-0)
src/location_service/com/ubuntu/location/providers/dummy/delayed_provider.h (+62/-0)
src/location_service/com/ubuntu/location/providers/remote/provider.cpp (+23/-0)
src/location_service/com/ubuntu/location/service/daemon.cpp (+14/-17)
tests/CMakeLists.txt (+1/-0)
tests/delayed_service_test.cpp (+193/-0)
tests/mock_event_receiver.h (+35/-0)
tests/remote_providerd_test.cpp (+1/-7)
Thomas Voß (thomas-voss)
description: updated
Changed in location-service (Ubuntu):
importance: Undecided → Critical
Loïc Minier (lool)
Changed in ubuntu-location-provider-here (Ubuntu):
assignee: nobody → Loïc Minier (lool)
status: New → In Progress
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-location-provider-here - 0.1+15.04.20150127~rtm-0ubuntu1

---------------
ubuntu-location-provider-here (0.1+15.04.20150127~rtm-0ubuntu1) 14.09; urgency=low

  [ Loïc Minier ]
  * Sleep 5 and restart ubuntu-location-service after starting HERE
    stack when wizard completes; lets location-service pick up the new
    provider; LP: #1415029. (LP: #1415029)

  [ Ubuntu daily release ]
  * New rebuild forced

ubuntu-location-provider-here (0.1+15.04.20141110-0ubuntu1) vivid; urgency=low

  [ Loïc Minier ]
  * Wait for NM and oFono to be started before starting slpgwd due to a
    bug in location-service-connectivity API (LP 1390490); works around
    LP: #1389874. (LP: #1390490, #1389874)
 -- Ubuntu daily release <email address hidden> Tue, 27 Jan 2015 17:32:31 +0000

Changed in ubuntu-location-provider-here (Ubuntu RTM):
status: New → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
importance: Undecided → High
milestone: none → ww09-2015
status: New → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
assignee: nobody → Thomas Voß (thomas-voss)
Revision history for this message
John McAleely (john.mcaleely) wrote :

@tvoss, is this going to land this week for ww09 milestone?

Revision history for this message
John McAleely (john.mcaleely) wrote :

phablet@ubuntu-phablet:~$ dpkg -l | grep provider-here
ii ubuntu-location-provider-here 0.1+15.04.20150127~rtm-0ubuntu1 armhf HERE provider for the Ubuntu Location Service
phablet@ubuntu-phablet:~$ system-image-cli -i
current build number: 239
device name: krillin
channel: ubuntu-touch/ubuntu-rtm/14.09-proposed
last update: 2015-02-18 19:19:28
version version: 239
version ubuntu: 20150218
version device: 20150216-fe747ac
version custom: 20150216-561-29-186

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: In Progress → Fix Released
Revision history for this message
Jonathan Cave (jocave) wrote :

Version: ubuntu-touch/stable/bq-aquaris.en r18 krillin

Just tried to switch to HERE supported location after having initially been set to GPS only. A reboot was required before the HERE app was able to find my location.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

This fixed the wizard scenario but not when enabled in settings, will open a new bug.

Changed in canonical-devices-system-image:
status: Fix Released → Confirmed
Changed in ubuntu-location-provider-here (Ubuntu RTM):
status: Fix Released → Confirmed
Changed in canonical-devices-system-image:
milestone: ww09-2015 → ww11-2015
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

on second thought just reopened it

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww11-2015 → ww13-2015
Revision history for this message
John McAleely (john.mcaleely) wrote :

@pat - is my understanding correct that the system-settings part you mention in #5 is fixed now in vivid?

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

I do not think the other scenario is fixed, assign to Bill t confirm

Changed in canonical-devices-system-image:
assignee: Thomas Voß (thomas-voss) → Bill Filler (bfiller)
Bill Filler (bfiller)
Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
Revision history for this message
Ken VanDine (ken-vandine) wrote :

@thomas-voss: Wouldn't it make more sense for the location-service to reload when it sees the property changes on accountsservice?

Revision history for this message
Thomas Voß (thomas-voss) wrote :

@ken-vandine: Sure, and we are already doing that for the wizard case. However, to make the overall solution more robust, we should be able to handle delayed/deferred providers flawlessly.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

@thomas-voss: Sure, it should be robust, which is why I don't think system-settings should be restarting the service. It's one thing to do that at the end of the wizard upstart job, but we can't really do that during runtime.

Revision history for this message
Noemí (noemi-gallego) wrote :

Is there any posibility of this affecting google maps too?
It couln't determinate my position until I accepted the here conditions and rebooted the device.

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Yes because if the Here provider is not loaded the only think available is gps which takes time to lock location. Anything on the system needing location is affected.

Revision history for this message
Bill Filler (bfiller) wrote :

marking system-settings task as invalid. The location-service should be monitoring for the signal and reloading when providers become ready

Changed in ubuntu-system-settings (Ubuntu):
status: New → Invalid
Changed in canonical-devices-system-image:
assignee: Bill Filler (bfiller) → Thomas Voß (thomas-voss)
Ken VanDine (ken-vandine)
Changed in ubuntu-system-settings (Ubuntu):
assignee: Ken VanDine (ken-vandine) → nobody
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww13-2015 → ww17-2015
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww17-2015 → ww18-2015
assignee: Thomas Voß (thomas-voss) → Canonical Phone Foundations (canonical-phonedations-team)
milestone: ww18-2015 → ww17-2015
milestone: ww17-2015 → ww18-2015
Pat McGowan (pat-mcgowan)
Changed in location-service (Ubuntu):
assignee: Thomas Voß (thomas-voss) → Manuel de la Peña (mandel)
Changed in canonical-devices-system-image:
milestone: ww18-2015 → ww22-2015
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug was fixed in the package ubuntu-location-provider-here 0.1+15.04.20150529-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-location-provider-here (0.1+15.04.20150529-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Manuel de la Pena ]
  * Empty commit to made the changes available for vivid.

ubuntu-location-provider-here (0.1+15.04.20150127~rtm-0ubuntu1) 14.09; urgency=low

  [ Loïc Minier ]
  * Sleep 5 and restart ubuntu-location-service after starting HERE
    stack when wizard completes; lets location-service pick up the new
    provider; LP: #1415029. (LP: #1415029)

  [ Ubuntu daily release ]
  * New rebuild forced

 -- CI Train Bot <email address hidden> Fri, 29 May 2015 08:11:27 +0000

Changed in ubuntu-location-provider-here (Ubuntu RTM):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-location-provider-here - 0.1+15.10.20150529-0ubuntu1

---------------
ubuntu-location-provider-here (0.1+15.10.20150529-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Manuel de la Pena ]
  * Empty commit to made the changes available for vivid.

ubuntu-location-provider-here (0.1+15.04.20150127~rtm-0ubuntu1) 14.09; urgency=low

  [ Loïc Minier ]
  * Sleep 5 and restart ubuntu-location-service after starting HERE
    stack when wizard completes; lets location-service pick up the new
    provider; LP: #1415029. (LP: #1415029)

  [ Ubuntu daily release ]
  * New rebuild forced

 -- CI Train Bot <email address hidden> Fri, 29 May 2015 08:11:27 +0000

Changed in ubuntu-location-provider-here (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww22-2015 → ww24-2015
Revision history for this message
Noemí (noemi-gallego) wrote :

It still reproduces on Vivid

Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww24-2015 → ww28-2015
tags: added: location
John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
assignee: Canonical Phone Foundations (canonical-phonedations-team) → John McAleely (john.mcaleely)
John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
milestone: ww28-2015 → ww34-2015
John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
milestone: ww34-2015 → ww40-2015
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
milestone: ww40-2015 → ww46-2015
Revision history for this message
Thomas Voß (thomas-voss) wrote :

Okay, finally found time to revisit my previous patch. I think we should load providers asynchronously on service startup. With that, configured providers are just hints to the underlying machinery, and loading/announcement of providers ready for consumption is executed on a different thread.

Pat McGowan (pat-mcgowan)
Changed in location-service (Ubuntu):
assignee: Manuel de la Peña (mandel) → Thomas Voß (thomas-voss)
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

assuming this didnt land

Changed in canonical-devices-system-image:
milestone: ww46-2015 → ww02-2016
Revision history for this message
Jean-Baptiste Lallement (jibel) wrote :

I confirm it is not fixed in OTA8

Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.