Ubuntu
livecd-rootfs package

should disable journald rate limiting in live-server session

Bug #1776891 reported by Michael Hudson-Doyle
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
subiquity
Fix Released
Undecided
Unassigned
livecd-rootfs (Ubuntu)
Fix Released
Undecided
Unassigned
Bionic
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
subiquity displays the curtin output by running curtin under systemd-cat. curtin can produce pretty large amounts of output and can hit journald rate limits, particularly when it fails (which is of course when you most want to see the output!). We should disable the rate limit in the installer.squashfs.

[Test case]
I guess make a CD with a deliberately broken subiquity that causes curtin to fail in a verbose way and ensure that all output is visible in subiquity's "view full log" screen.

[Regression potential]
Having no rate limit increases the chances of running the live system out of RAM if curtin is especially verbose I guess, but this would be an issue if we were spooling the log output to a file too.

Related branches

lp://staging/~mwhudson/livecd-rootfs/lp-1776891
Steve Langasek: Approve
Diff: 34 lines (+10/-0) (has conflicts)
2 files modified
debian/changelog (+9/-0)
live-build/ubuntu-server/includes.binary/overlay/etc/systemd/journald.conf.d/no-rate-limit.conf (+1/-0)
lp://staging/~mwhudson/livecd-rootfs/lp-1776891-bionic
Steve Langasek: Approve
Diff: 24 lines (+6/-0)
2 files modified
debian/changelog (+5/-0)
live-build/ubuntu-server/includes.binary/overlay/etc/systemd/journald.conf.d/no-rate-limit.conf (+1/-0)
lp://staging/~ubuntu-core-dev/livecd-rootfs/bionic-proposed
Francis Ginther (fginther)
tags: added: id-5b224cde9b772a957099c27e
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

We didn't land this still?

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.534

---------------
livecd-rootfs (2.534) cosmic; urgency=medium

  [ Michael Hudson-Doyle ]
  * Disable journald rate limiting in the live-server live session.
    (LP: #1776891)

  [ Steve Langasek ]
  * generate all tar files with --xattrs. LP: #1302192.

 -- Steve Langasek <email address hidden> Mon, 06 Aug 2018 13:12:02 -0700

Changed in livecd-rootfs (Ubuntu):
status: New → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in livecd-rootfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

So it turns out the fix in cosmic isn't actually correct :(

Changed in livecd-rootfs (Ubuntu):
status: Fix Released → In Progress
tags: added: verification-failed verification-failed-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Ok, dropping this from bionic-proposed then - overwriting it with the next livecd-rootfs SRU.

Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Hello Michael, or anyone else affected,

Accepted livecd-rootfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/livecd-rootfs/2.525.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-bionic
removed: verification-failed verification-failed-bionic
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I tested this by booting a live-server ISO, running systemd-cat -t testing seq 10000 and checking that all 10001 lines of output ended up in the journal.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for livecd-rootfs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package livecd-rootfs - 2.525.8

---------------
livecd-rootfs (2.525.8) bionic; urgency=medium

  * Disentangle enabling universe in the final image a little from having
    PREINSTALLED=true set and enable it for a live-server build.
    (LP: #1783129)
  * Fix live-server journald config snippet to actually disable journald rate
    limiting.

livecd-rootfs (2.525.7) bionic; urgency=medium

  * Disable journald rate limiting in the live-server live session.
    (LP: #1776891)

 -- Michael Hudson-Doyle <email address hidden> Tue, 28 Aug 2018 11:03:37 +1200

Changed in livecd-rootfs (Ubuntu Bionic):
status: Fix Committed → Fix Released
Michael Hudson-Doyle (mwhudson)
Changed in subiquity:
status: New → Fix Released
Changed in livecd-rootfs (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.