ubuntu-cpc: Don't build minimized artifacts that won't boot with linux-kvm
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
livecd-rootfs (Ubuntu) |
Fix Released
|
Undecided
|
Dan Watkins | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Currently, the ubuntu-cpc hooks execute for all builds, minimized or not. As minimized images use the linux-kvm kernel, we shouldn't produce images for non-KVM platforms. The hooks that need skipping are the ones that produce the VMDK, OVA and Vagrant box.
Given that livecd-rootfs own the definition of minimized images, it should also own defining which images should be produced when a minimized build runs.
[Impact]
* Increased build time for minimized images
* Publication of minimized cloud images that cannot possibly boot
[Test Case]
Run a minimized livefs build; the .vmdk, .ova and .box files should not be produced. Run a regular livefs build, the .vmdk, .ova and .box files should be produced.
[Regression Potential]
The changes required are adding conditional "exit 0"s to the hooks in question, which aren't used by any other hooks. The only potential regression would be either (a) syntax issues that would manifest obviously in a complete failure to build (and therefore cause the Test Case to fail), or (b) accidental exclusion of these image types for non-minimized builds, which is covered in the Test Case section.
Related branches
- Steve Langasek: Approve
-
Diff: 74 lines (+34/-0)4 files modifieddebian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/040-vmdk-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+9/-0)
- Ubuntu Core Development Team: Pending requested
-
Diff: 72 lines (+33/-0)4 files modifieddebian/changelog (+7/-0)
live-build/ubuntu-cpc/hooks/040-vmdk-image.binary (+9/-0)
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+8/-0)
live-build/ubuntu-cpc/hooks/042-vagrant.binary (+9/-0)
Changed in livecd-rootfs (Ubuntu): | |
status: | New → Fix Committed |
Changed in livecd-rootfs (Ubuntu Xenial): | |
status: | New → In Progress |
tags: | added: patch |
tags: | added: id-5ab10f6f7858201e0301532d |
Attached debdiff that addresses this in xenial.