Activity log for bug #2027816

Date Who What changed Old value New value Message
2023-07-14 15:23:32 You-Sheng Yang bug added bug
2023-07-14 15:30:48 You-Sheng Yang bug added subscriber Canonical Hardware Enablement
2023-07-14 15:30:57 You-Sheng Yang tags amd oem-priority originate-from-2026793
2023-07-14 15:31:26 You-Sheng Yang bug task added linux-oem-6.1 (Ubuntu)
2023-07-14 15:32:40 You-Sheng Yang nominated for series Ubuntu Mantic
2023-07-14 15:32:40 You-Sheng Yang bug task added linux (Ubuntu Mantic)
2023-07-14 15:32:40 You-Sheng Yang bug task added linux-oem-6.1 (Ubuntu Mantic)
2023-07-14 15:32:40 You-Sheng Yang nominated for series Ubuntu Lunar
2023-07-14 15:32:40 You-Sheng Yang bug task added linux (Ubuntu Lunar)
2023-07-14 15:32:40 You-Sheng Yang bug task added linux-oem-6.1 (Ubuntu Lunar)
2023-07-14 15:32:40 You-Sheng Yang nominated for series Ubuntu Jammy
2023-07-14 15:32:40 You-Sheng Yang bug task added linux (Ubuntu Jammy)
2023-07-14 15:32:40 You-Sheng Yang bug task added linux-oem-6.1 (Ubuntu Jammy)
2023-07-14 15:32:54 You-Sheng Yang linux-oem-6.1 (Ubuntu Lunar): status New Invalid
2023-07-14 15:32:56 You-Sheng Yang linux-oem-6.1 (Ubuntu Mantic): status New Invalid
2023-07-14 15:33:05 You-Sheng Yang linux-oem-6.1 (Ubuntu Jammy): status New In Progress
2023-07-14 15:33:08 You-Sheng Yang linux-oem-6.1 (Ubuntu Jammy): importance Undecided High
2023-07-14 15:33:12 You-Sheng Yang linux-oem-6.1 (Ubuntu Jammy): assignee You-Sheng Yang (vicamo)
2023-07-14 15:33:25 You-Sheng Yang linux (Ubuntu Mantic): status New Confirmed
2023-07-14 15:33:32 You-Sheng Yang linux (Ubuntu Lunar): status New Confirmed
2023-07-14 15:33:35 You-Sheng Yang linux (Ubuntu Jammy): status New Confirmed
2023-07-14 15:46:15 You-Sheng Yang summary interrupt storm on GPIO controller on AMD platforms Interrupt storm on GPIO controller on AMD platforms
2023-07-14 16:07:14 You-Sheng Yang description On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to GPIO 7 is causing an interrupt storm. This issue doesn't happen on Windows. Comparing the GPIO register configuration between Windows and Linux bit 20 has been configured as a pull up on Windows, but not on Linux. Checking GPIO declaration from the firmware it is clear it *should* have been a pull up on Linux as well. ``` GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000, "\\_SB.GPIO", 0x00, ResourceConsumer, ,) { // Pin list 0x0007 } ``` On Linux amd_gpio_set_config() is currently only used for programming the debounce. Actually the GPIO core calls it with all the arguments that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`. To solve this issue expand amd_gpio_set_config() to support the other arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`, `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`. Upstream bug in https://bugzilla.kernel.org/show_bug.cgi?id=217336 Related fixes are: (all in linux-next) * commit 968ab9261627 ("pinctrl: amd: Detect internal GPIO0 debounce handling") * commit 0d5ace1a07f7 ("pinctrl: amd: Only use special debounce behavior for GPIO 0") * commit 635a750d958e ("pinctrl: amd: Use amd_pinconf_set() for all config options") * commit 3f62312d04d4 ("pinctrl: amd: Drop pull up select configuration") * commit 283c5ce7da0a ("pinctrl: amd: Unify debounce handling into amd_pinconf_set()") On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to GPIO 7 is causing an interrupt storm. This issue doesn't happen on Windows. Comparing the GPIO register configuration between Windows and Linux bit 20 has been configured as a pull up on Windows, but not on Linux. Checking GPIO declaration from the firmware it is clear it *should* have been a pull up on Linux as well. ``` GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000,   "\\_SB.GPIO", 0x00, ResourceConsumer, ,) { // Pin list 0x0007 } ``` On Linux amd_gpio_set_config() is currently only used for programming the debounce. Actually the GPIO core calls it with all the arguments that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`. To solve this issue expand amd_gpio_set_config() to support the other arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`, `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`. Upstream bug in https://bugzilla.kernel.org/show_bug.cgi?id=217336 Related fixes are: * v6.5-rc1: * commit 968ab9261627 ("pinctrl: amd: Detect internal GPIO0 debounce handling") * linux-next: * commit 0d5ace1a07f7 ("pinctrl: amd: Only use special debounce behavior for GPIO 0") * commit 635a750d958e ("pinctrl: amd: Use amd_pinconf_set() for all config options") * commit 3f62312d04d4 ("pinctrl: amd: Drop pull up select configuration") * commit 283c5ce7da0a ("pinctrl: amd: Unify debounce handling into amd_pinconf_set()")
2023-07-14 16:09:36 You-Sheng Yang description On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to GPIO 7 is causing an interrupt storm. This issue doesn't happen on Windows. Comparing the GPIO register configuration between Windows and Linux bit 20 has been configured as a pull up on Windows, but not on Linux. Checking GPIO declaration from the firmware it is clear it *should* have been a pull up on Linux as well. ``` GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000,   "\\_SB.GPIO", 0x00, ResourceConsumer, ,) { // Pin list 0x0007 } ``` On Linux amd_gpio_set_config() is currently only used for programming the debounce. Actually the GPIO core calls it with all the arguments that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`. To solve this issue expand amd_gpio_set_config() to support the other arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`, `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`. Upstream bug in https://bugzilla.kernel.org/show_bug.cgi?id=217336 Related fixes are: * v6.5-rc1: * commit 968ab9261627 ("pinctrl: amd: Detect internal GPIO0 debounce handling") * linux-next: * commit 0d5ace1a07f7 ("pinctrl: amd: Only use special debounce behavior for GPIO 0") * commit 635a750d958e ("pinctrl: amd: Use amd_pinconf_set() for all config options") * commit 3f62312d04d4 ("pinctrl: amd: Drop pull up select configuration") * commit 283c5ce7da0a ("pinctrl: amd: Unify debounce handling into amd_pinconf_set()") On ASUS TUF A16 it is reported that the ITE5570 ACPI device connected to GPIO 7 is causing an interrupt storm. This issue doesn't happen on Windows. Comparing the GPIO register configuration between Windows and Linux bit 20 has been configured as a pull up on Windows, but not on Linux. Checking GPIO declaration from the firmware it is clear it *should* have been a pull up on Linux as well. ``` GpioInt (Level, ActiveLow, Exclusive, PullUp, 0x0000,   "\\_SB.GPIO", 0x00, ResourceConsumer, ,) { // Pin list 0x0007 } ``` On Linux amd_gpio_set_config() is currently only used for programming the debounce. Actually the GPIO core calls it with all the arguments that are supported by a GPIO, pinctrl-amd just responds `-ENOTSUPP`. To solve this issue expand amd_gpio_set_config() to support the other arguments amd_pinconf_set() supports, namely `PIN_CONFIG_BIAS_PULL_DOWN`, `PIN_CONFIG_BIAS_PULL_UP`, and `PIN_CONFIG_DRIVE_STRENGTH`. Upstream bug in https://bugzilla.kernel.org/show_bug.cgi?id=217336 Related fixes are: * v6.4: * commit 010f493d90ee ("pinctrl: amd: Add fields for interrupt status and wake status") * commit 75358cf3319d ("pinctrl: amd: Adjust debugfs output") * v6.5-rc1:   * commit 968ab9261627 ("pinctrl: amd: Detect internal GPIO0 debounce handling") * linux-next:   * commit 0d5ace1a07f7 ("pinctrl: amd: Only use special debounce behavior for GPIO 0")   * commit 635a750d958e ("pinctrl: amd: Use amd_pinconf_set() for all config options")   * commit 3f62312d04d4 ("pinctrl: amd: Drop pull up select configuration")   * commit 283c5ce7da0a ("pinctrl: amd: Unify debounce handling into amd_pinconf_set()")
2023-09-11 13:34:12 Timo Aaltonen tags amd oem-priority originate-from-2026793 amd oem-priority originate-from-2026793 verification-needed-jammy-linux-oem-6.1
2023-09-11 13:35:53 Timo Aaltonen tags amd oem-priority originate-from-2026793 verification-needed-jammy-linux-oem-6.1 amd oem-priority originate-from-2026793