| 2023-03-13 07:37:13 |
You-Sheng Yang |
bug |
|
|
added bug |
| 2023-03-13 07:40:30 |
You-Sheng Yang |
description |
vmd may fail to create sysfs entry while `pci_rescan_bus()` called in some other drivers like wwan.
sysfs: cannot create duplicate filename '/devices/.../resource0'
Call Trace:
<TASK>
sysfs_warn_dup.cold+0x17/0x34
sysfs_add_bin_file_mode_ns+0xc0/0xf0
sysfs_create_bin_file+0x6d/0xb0
pci_create_attr+0x117/0x260
pci_create_resource_files+0x6b/0x150
pci_create_sysfs_dev_files+0x18/0x30
pci_bus_add_device+0x30/0x80
pci_bus_add_devices+0x31/0x80
pci_bus_add_devices+0x5b/0x80
vmd_enable_domain.constprop.0+0x6b7/0x880 [vmd]
vmd_probe+0x16d/0x193 [vmd] |
vmd may fail to create sysfs entry while `pci_rescan_bus()` called in some other drivers like wwan.
This happens after bug 2002089 re-added pci rescan feature back to wwan t7xx driver to support firmware updates via devlink. t7xx may call `pci_rescan_bus()` with proper locks, but vmd doesn't.
sysfs: cannot create duplicate filename '/devices/.../resource0'
Call Trace:
<TASK>
sysfs_warn_dup.cold+0x17/0x34
sysfs_add_bin_file_mode_ns+0xc0/0xf0
sysfs_create_bin_file+0x6d/0xb0
pci_create_attr+0x117/0x260
pci_create_resource_files+0x6b/0x150
pci_create_sysfs_dev_files+0x18/0x30
pci_bus_add_device+0x30/0x80
pci_bus_add_devices+0x31/0x80
pci_bus_add_devices+0x5b/0x80
vmd_enable_domain.constprop.0+0x6b7/0x880 [vmd]
vmd_probe+0x16d/0x193 [vmd] |
|
| 2023-03-13 08:00:06 |
Ubuntu Kernel Bot |
linux (Ubuntu): status |
New |
Incomplete |
|
| 2023-03-13 08:23:01 |
You-Sheng Yang |
nominated for series |
|
Ubuntu Lunar |
|
| 2023-03-13 08:23:01 |
You-Sheng Yang |
bug task added |
|
linux (Ubuntu Lunar) |
|
| 2023-03-13 08:23:01 |
You-Sheng Yang |
nominated for series |
|
Ubuntu Jammy |
|
| 2023-03-13 08:23:01 |
You-Sheng Yang |
bug task added |
|
linux (Ubuntu Jammy) |
|
| 2023-03-13 08:23:16 |
You-Sheng Yang |
bug task added |
|
linux-oem-6.1 (Ubuntu) |
|
| 2023-03-13 08:23:29 |
You-Sheng Yang |
bug task added |
|
linux-oem-6.0 (Ubuntu) |
|
| 2023-03-13 08:23:49 |
You-Sheng Yang |
linux-oem-6.1 (Ubuntu Lunar): status |
New |
Invalid |
|
| 2023-03-13 08:23:53 |
You-Sheng Yang |
linux-oem-6.0 (Ubuntu Lunar): status |
New |
Invalid |
|
| 2023-03-13 08:24:31 |
You-Sheng Yang |
linux (Ubuntu Jammy): status |
New |
Invalid |
|
| 2023-03-13 08:24:39 |
You-Sheng Yang |
linux (Ubuntu Lunar): status |
Incomplete |
In Progress |
|
| 2023-03-13 08:24:47 |
You-Sheng Yang |
linux (Ubuntu Lunar): importance |
Undecided |
High |
|
| 2023-03-13 08:24:49 |
You-Sheng Yang |
linux (Ubuntu Lunar): assignee |
|
You-Sheng Yang (vicamo) |
|
| 2023-03-13 08:24:55 |
You-Sheng Yang |
linux-oem-6.1 (Ubuntu Jammy): status |
New |
In Progress |
|
| 2023-03-13 08:24:59 |
You-Sheng Yang |
linux-oem-6.1 (Ubuntu Jammy): importance |
Undecided |
High |
|
| 2023-03-13 08:25:02 |
You-Sheng Yang |
linux-oem-6.1 (Ubuntu Jammy): assignee |
|
You-Sheng Yang (vicamo) |
|
| 2023-03-13 17:42:30 |
You-Sheng Yang |
bug |
|
|
added subscriber Canonical Hardware Enablement |
| 2023-03-13 17:42:34 |
You-Sheng Yang |
tags |
|
oem-priority originate-from-2008984 somerville |
|
| 2023-03-15 09:54:04 |
You-Sheng Yang |
description |
vmd may fail to create sysfs entry while `pci_rescan_bus()` called in some other drivers like wwan.
This happens after bug 2002089 re-added pci rescan feature back to wwan t7xx driver to support firmware updates via devlink. t7xx may call `pci_rescan_bus()` with proper locks, but vmd doesn't.
sysfs: cannot create duplicate filename '/devices/.../resource0'
Call Trace:
<TASK>
sysfs_warn_dup.cold+0x17/0x34
sysfs_add_bin_file_mode_ns+0xc0/0xf0
sysfs_create_bin_file+0x6d/0xb0
pci_create_attr+0x117/0x260
pci_create_resource_files+0x6b/0x150
pci_create_sysfs_dev_files+0x18/0x30
pci_bus_add_device+0x30/0x80
pci_bus_add_devices+0x31/0x80
pci_bus_add_devices+0x5b/0x80
vmd_enable_domain.constprop.0+0x6b7/0x880 [vmd]
vmd_probe+0x16d/0x193 [vmd] |
[SRU Justification]
[Impact]
With wwan t7xx driver patched, vmd may fail the probe process because it does not lock properly.
[Fix]
https://lore.kernel.org/linux-pci/20230313173733.1815277-1-vicamo.yang@canonical.com/T/#u
[Test Case]
Verify on platforms with FM350 wwan module with prebuilt oem-6.1 or above kernels. No vmd probe error should be found in dmesg.
[Where problems could occur]
This is the way it should have been done.
[Other Info]
This is not reproducible with v6.0 or older kernels, so only Lunar and oem-6.1 are nominated for fix. OEM-6.0 patch goes to Gerrit instead.
========== original bug report ==========
vmd may fail to create sysfs entry while `pci_rescan_bus()` called in some other drivers like wwan.
This happens after bug 2002089 re-added pci rescan feature back to wwan t7xx driver to support firmware updates via devlink. t7xx may call `pci_rescan_bus()` with proper locks, but vmd doesn't.
sysfs: cannot create duplicate filename '/devices/.../resource0'
Call Trace:
<TASK>
sysfs_warn_dup.cold+0x17/0x34
sysfs_add_bin_file_mode_ns+0xc0/0xf0
sysfs_create_bin_file+0x6d/0xb0
pci_create_attr+0x117/0x260
pci_create_resource_files+0x6b/0x150
pci_create_sysfs_dev_files+0x18/0x30
pci_bus_add_device+0x30/0x80
pci_bus_add_devices+0x31/0x80
pci_bus_add_devices+0x5b/0x80
vmd_enable_domain.constprop.0+0x6b7/0x880 [vmd]
vmd_probe+0x16d/0x193 [vmd] |
|
| 2023-03-15 09:58:26 |
You-Sheng Yang |
linux-oem-6.0 (Ubuntu Jammy): status |
New |
Won't Fix |
|
| 2023-03-17 09:33:04 |
Timo Aaltonen |
linux-oem-6.1 (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2023-04-11 05:16:48 |
Ubuntu Kernel Bot |
tags |
oem-priority originate-from-2008984 somerville |
kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
|
| 2023-04-13 06:27:59 |
You-Sheng Yang |
tags |
kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-done-jammy |
|
| 2023-04-18 13:36:07 |
Launchpad Janitor |
linux-oem-6.1 (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2023-06-08 18:41:21 |
Ubuntu Kernel Bot |
tags |
kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-done-jammy |
kernel-spammed-jammy-linux-hwe-6.2 kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
|
| 2023-06-09 20:55:28 |
Ubuntu Kernel Bot |
tags |
kernel-spammed-jammy-linux-hwe-6.2 kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
kernel-spammed-jammy-linux-hwe-6.2 kernel-spammed-jammy-linux-nvidia-6.2 kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
linux (Ubuntu Lunar): status |
In Progress |
Fix Released |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
cve linked |
|
2023-1380 |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
cve linked |
|
2023-2612 |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
cve linked |
|
2023-30456 |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
cve linked |
|
2023-31436 |
|
| 2023-06-15 22:21:51 |
Launchpad Janitor |
cve linked |
|
2023-32233 |
|
| 2023-06-22 15:45:12 |
Launchpad Janitor |
linux (Ubuntu): status |
In Progress |
Fix Released |
|
| 2023-07-19 13:14:15 |
Ubuntu Kernel Bot |
tags |
kernel-spammed-jammy-linux-hwe-6.2 kernel-spammed-jammy-linux-nvidia-6.2 kernel-spammed-jammy-linux-oem-6.1 oem-priority originate-from-2008984 somerville verification-needed-jammy |
kernel-spammed-jammy-linux-hwe-6.2 kernel-spammed-jammy-linux-nvidia-6.2 kernel-spammed-jammy-linux-oem-6.1 kernel-spammed-lunar-linux-azure oem-priority originate-from-2008984 somerville verification-needed-jammy verification-needed-lunar |
|
