Add AMDI0009 support to amd-pmc

Bug #1990916 reported by You-Sheng Yang
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
New
Undecided
Unassigned
linux (Ubuntu)
Incomplete
Undecided
Unassigned
Jammy
Invalid
Undecided
Unassigned
linux-oem-6.0 (Ubuntu)
Invalid
Undecided
Unassigned
Jammy
Fix Released
Undecided
Unassigned

Bug Description

For AMD Pink Sardine a change is being made in newer BIOSes that will use a different _HID than is currently supported in amd-pmc as of kernel 6.0. This new ID changes a interface to the BIOS and is not just adding the ID.

To support s0i3 in OEM 6.0 kernel we will need to support this new ID/interface.

AMD will submit the code to target to kernel 6.1, but it will be needed in OEM-6.0 kernel.

Revision history for this message
You-Sheng Yang (vicamo) wrote :

Quoted from Mario Limonciello in https://bugs.launchpad.net/amd/+bug/1988455/comments/1:

This change needs to come in two drivers.
The drivers/acpi/x86/s2idle.c as well as drivers/platform/x86/amd/pmc.c.

The change to s2idle.c has landed through this patch series going into 6.1.

https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/log/?h=bleeding-edge

9d63b0a08e4d ACPI: x86: s2idle: Add a quirk for ASUSTeK COMPUTER INC. ROG Flow X13
213b18edf309 ACPI: x86: s2idle: Add a quirk for Lenovo Slim 7 Pro 14ARH7
08816b581a65 ACPI: x86: s2idle: Add a quirk for ASUS ROG Zephyrus G14
44b53db6d410 ACPI: x86: s2idle: Add a quirk for ASUS TUF Gaming A17 FA707RE
5c741f11c342 ACPI: x86: s2idle: Add module parameter to prefer Microsoft GUID
f47f08ac6b48 ACPI: x86: s2idle: If a new AMD _HID is missing assume Rembrandt
e3c7a8f1e84c ACPI: x86: s2idle: Move _HID handling for AMD systems into structures

The commit below that if _HID is missing assume Rembrandt behavior will handle it.

Changed in linux-oem-6.0 (Ubuntu):
status: New → Invalid
You-Sheng Yang (vicamo)
tags: added: amd oem-priority originate-from-1988455
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Included in experimental kernel linux-oem-6.0/jammy version 6.0.0-9004.4+exp.8 in https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/intermediate-kernel.

description: updated
Revision history for this message
You-Sheng Yang (vicamo) wrote :

Included an additional commit 39f81776c680 ("ACPI: x86: s2idle: Fix a NULL pointer dereference") in linux-oem-6.0/jammy version 6.0.0-9004.4+exp.10 in https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/intermediate-kernel.

Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.0/6.0.0-1006.6 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-jammy' to 'verification-done-jammy'. If the problem still exists, change the tag 'verification-needed-jammy' to 'verification-failed-jammy'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

Timo Aaltonen (tjaalton)
Changed in linux-oem-6.0 (Ubuntu Jammy):
status: New → Fix Released
Changed in linux (Ubuntu Jammy):
status: New → Invalid
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote : Missing required logs.

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1990916

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

Changed in linux (Ubuntu):
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.