| 2020-07-08 18:10:40 |
Thadeu Lima de Souza Cascardo |
bug |
|
|
added bug |
| 2020-07-08 18:10:48 |
Thadeu Lima de Souza Cascardo |
nominated for series |
|
Ubuntu Bionic |
|
| 2020-07-08 18:10:48 |
Thadeu Lima de Souza Cascardo |
bug task added |
|
linux (Ubuntu Bionic) |
|
| 2020-07-08 18:10:55 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Bionic): status |
New |
Confirmed |
|
| 2020-07-08 18:11:04 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Bionic): importance |
Undecided |
Medium |
|
| 2020-07-08 18:11:14 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu): status |
New |
Invalid |
|
| 2020-07-23 08:59:50 |
Janåke Rönnblom |
bug |
|
|
added subscriber Janåke Rönnblom |
| 2020-11-25 21:50:59 |
Thadeu Lima de Souza Cascardo |
nominated for series |
|
Ubuntu Focal |
|
| 2020-11-25 21:50:59 |
Thadeu Lima de Souza Cascardo |
bug task added |
|
linux (Ubuntu Focal) |
|
| 2020-11-25 21:51:08 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Focal): status |
New |
Confirmed |
|
| 2020-11-25 21:51:12 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Focal): assignee |
|
Thadeu Lima de Souza Cascardo (cascardo) |
|
| 2020-11-25 21:51:14 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Bionic): assignee |
|
Thadeu Lima de Souza Cascardo (cascardo) |
|
| 2020-11-25 21:51:18 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Focal): importance |
Undecided |
Medium |
|
| 2020-11-25 22:56:22 |
Thadeu Lima de Souza Cascardo |
description |
When net_prio is used without setting ifpriomap and BFP cgroup is used, memory may be leaked. This was fixed by upstream commit 090e28b229af92dc5b40786ca673999d59e73056, but it had to be reverted to fix LP #1886668.
When a real fix for this cgroup BFP crash lands, this patch should be reinstated.
Cascardo. |
[Impact]
In some container scenarios, there will be a memory leak, leading to OOM.
[Test case]
Run the following:
while true ; do mkdir net_prio/a unified/a ; bash -c 'echo $$ > unified/a/cgroup.procs ; echo $$ > net_prio/a/tasks ; ping -c 1 localhost > /dev/null' ; rmdir net_prio/a unified/a ; done
Or the attached program cgroup_leak.c, which is faster. A leak would be produced without the fix, while there should be no constant leak with the fix applied.
[Potential regression]
This patch has also caused breakage with BPF cgroup in the past, when racing with its disabling, when one attachs a process to netprio cgroup. Similar breakage could happen.
---------------------------------
When net_prio is used without setting ifpriomap and BFP cgroup is used, memory may be leaked. This was fixed by upstream commit 090e28b229af92dc5b40786ca673999d59e73056, but it had to be reverted to fix LP #1886668.
When a real fix for this cgroup BFP crash lands, this patch should be reinstated.
Cascardo. |
|
| 2020-11-25 22:57:13 |
Thadeu Lima de Souza Cascardo |
attachment added |
|
Reproducer https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1886859/+attachment/5438034/+files/cgroup_leak.c |
|
| 2020-11-26 00:37:17 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Bionic): status |
Confirmed |
In Progress |
|
| 2020-11-26 00:37:18 |
Thadeu Lima de Souza Cascardo |
linux (Ubuntu Focal): status |
Confirmed |
In Progress |
|
| 2020-11-26 15:05:59 |
Kleber Sacilotto de Souza |
linux (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2020-11-26 15:06:01 |
Kleber Sacilotto de Souza |
linux (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2020-11-30 23:47:56 |
Ubuntu Kernel Bot |
tags |
|
verification-needed-focal |
|
| 2020-12-02 12:29:22 |
Ubuntu Kernel Bot |
tags |
verification-needed-focal |
verification-needed-bionic verification-needed-focal |
|
| 2020-12-15 23:18:43 |
Thadeu Lima de Souza Cascardo |
tags |
verification-needed-bionic verification-needed-focal |
verification-done-bionic verification-needed-focal |
|
| 2020-12-16 15:30:06 |
Thadeu Lima de Souza Cascardo |
tags |
verification-done-bionic verification-needed-focal |
verification-done-bionic verification-done-focal |
|
| 2021-01-04 13:54:06 |
Launchpad Janitor |
linux (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-01-04 15:46:58 |
Launchpad Janitor |
linux (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2021-01-04 15:46:58 |
Launchpad Janitor |
cve linked |
|
2019-19770 |
|
