False positive test result in run_afpackettests from net in ubuntu_kernel_selftest
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Xenial |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Bionic |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Disco |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
== Justification ==
The run_afpackettests will be marked as passed regardless the return
value of those sub-tests in the script:
---
running psock_tpacket test
---
[FAIL]
selftests: run_afpackettests [PASS]
Fix this by changing the return value for each tests.
== Fix ==
* 8c03557 (selftests/net: correct the return value for run_afpackettests)
This patch has alreay landed on newer releases and D with stable
updates.
For X and B this can be backported with the same logic.
== Test ==
Tested on a Xenial KVM with this patch applied on these two trees, when
the test failed the return value will be 1 instead of 0 as expected.
== Regression Potential ==
* Low, it's just reflecting the real test return value. We may see this
test failing on some kernels but it's good as it's reporting a real bug.
== Original Bug Report ==
The run_afpackettests will be marked as passed regardless the return
value of those sub-tests in the script:
---
running psock_tpacket test
---
[FAIL]
selftests: run_afpackettests [PASS]
Fix this by changing the return value for each tests.
Patch sent to upstream.
CVE References
Changed in linux (Ubuntu): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
status: | New → In Progress |
tags: | added: ubuntu-kernel-selftests |
tags: | added: disco xenial |
tags: | added: bionic |
tags: | added: sru-20190902 |
Changed in linux (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in ubuntu-kernel-tests: | |
status: | In Progress → Fix Released |
tags: |
added: verification-done-bionic removed: verification-needed-bionic |
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
https:/ /github. com/torvalds/ linux/commit/ 8c03557c3f25271 e62e39154af66eb dd1b59c9ca