hisi_sas: Add missing PHY spinlock init
Bug #1777734 reported by
dann frazier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Undecided
|
dann frazier | ||
Bionic |
Fix Released
|
Undecided
|
dann frazier |
Bug Description
[Impact]
This is a code correctness issue found during code review. From my reading of the code, the spin_lock will always happen to have just been devm_kcalloc'd, which uses GFP_ZERO, before spin_lock_init() needs to be called. That may make the current code safe, but relying on that coincidence seems dangerous. There's also various debugging facilities in the kernel that appear to rely on proper spinlock initialization, and those may currently be broken.
[Test Case]
Boot test to look for regressions.
[Fix]
Backport a fix from the scsi maintainer's 4.19 queue which adds a spin_lock_init() call.
[Regression Risk]
The fix is limited to the hisi_sas driver and is obviously correct.
Changed in linux (Ubuntu): | |
status: | New → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
Changed in linux (Ubuntu): | |
assignee: | nobody → dann frazier (dannf) |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → dann frazier (dannf) |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification- needed- bionic' to 'verification- done-bionic' . If the problem still exists, change the tag 'verification- needed- bionic' to 'verification- failed- bionic' .
If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.
See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you!