| 2015-01-21 09:43:00 |
Colin Ian King |
description |
Running xfs btrfs specific tests 035 with various mount options with 7 target btrfs devices causes the kernel to reboot when running inside a virtual machine. Bisecting tracked the fix down to commit 00fdf13a2e9f313a044288aa59d3b8ec29ff904a:
Author: Liu Bo <bo.li.liu@oracle.com>
Date: Mon Mar 10 18:56:07 2014 +0800
Btrfs: fix a crash of clone with inline extents's split
xfstests's btrfs/035 triggers a BUG_ON, which we use to detect the split
of inline extents in __btrfs_drop_extents().
For inline extents, we cannot duplicate another EXTENT_DATA item, because
it breaks the rule of inline extents, that is, 'start offset' needs to be 0.
We have set limitations for the source inode's compressed inline extents,
because it needs to decompress and recompress. Now the destination inode's
inline extents also need similar limitations.
With this, xfstests btrfs/035 doesn't run into panic.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
SRU Justification:
[Impact]
Running standard btrfs test 035 will cause a machine to reboot.
[Fix]
commit 00fdf13a2e9f313a044288aa59d3b8ec29ff904a
Btrfs: fix a crash of clone with inline extents's split
[Testcase]
Run xfs "btrfs specific" test 35 with 7 devices for the btrfs scratch pool. Run with all mount options. Without the fix, the machine reboots. With the fix, one can run this multiple times w/o a reboot. |
Running xfs btrfs specific tests 035 with various mount options with 7 target btrfs devices causes the kernel to crash when running inside a virtual machine. Bisecting tracked the fix down to commit 00fdf13a2e9f313a044288aa59d3b8ec29ff904a:
Author: Liu Bo <bo.li.liu@oracle.com>
Date: Mon Mar 10 18:56:07 2014 +0800
Btrfs: fix a crash of clone with inline extents's split
xfstests's btrfs/035 triggers a BUG_ON, which we use to detect the split
of inline extents in __btrfs_drop_extents().
For inline extents, we cannot duplicate another EXTENT_DATA item, because
it breaks the rule of inline extents, that is, 'start offset' needs to be 0.
We have set limitations for the source inode's compressed inline extents,
because it needs to decompress and recompress. Now the destination inode's
inline extents also need similar limitations.
With this, xfstests btrfs/035 doesn't run into panic.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>
SRU Justification:
[Impact]
Running standard btrfs test 035 will cause a machine to reboot.
[Fix]
commit 00fdf13a2e9f313a044288aa59d3b8ec29ff904a
Btrfs: fix a crash of clone with inline extents's split
[Testcase]
Run xfs "btrfs specific" test 35 with 7 devices for the btrfs scratch pool. Run with all mount options. Without the fix, the machine reboots. With the fix, one can run this multiple times w/o a reboot. |
|
