Ubuntu
linux-fsl-imx51 package

imx51 udeb hardcodes linux version in vmlinuz binary name

Bug #359049 reported by Loïc Minier
10
Affects Status Importance Assigned to Milestone
linux-fsl-imx51 (Ubuntu)
Fix Released
High
Amit Kucheria
Jaunty
Won't Fix
High
Unassigned
Karmic
Fix Released
High
Amit Kucheria
linux-mvl-dove (Ubuntu)
Fix Released
High
Brad Figg
Jaunty
Won't Fix
Undecided
Unassigned
Karmic
Fix Released
High
Brad Figg

Bug Description

Hi

the imx51 kernel udeb ships ./boot/vmlinuz-2.6.28-11-imx51; note that this pathname includes the linux version number.

We don't really care about the name of the file in the udeb for e.g. netboot images, but for arches where we build full Ubuntu images (with cdimage / debian-cd on cdimage.ubuntu.com), such as i386, amd64, lpia, and now imx51 it is a problem to have the linux version number in the udeb binary because that would require hardcoding the linux version number on the cdimage / debian-cd side.

For lpia, i386, amd64, the udeb simply uses "vmlinuz".

I wish we'd do the same for imx51. It makes sense to follow the same approach for all armel flavours.

Now there's a risk of regression (only in debian-installer / flash-kernel I think) on arches with installed systems if the bootloader points at the wrong location (uses the linux version in its logic). We are probably in a position to fix these issues if we test all flavours before release, which we will.

Another reason why using a longer vmlinuz name is useful is when creating multi-flavours images, e.g. two udebs for the same arch but for two flavours / subarches would be installed in the same target image. We don't currently do that, but we could support it while still dropping the kernel version from the name.

So to recap available options:
- option A: do nothing, hardcode linux version name in cdimage
- option B: change imx51 udeb kernel name to vmlinuz, update debian-installer and cdimage to use that, test imx51
- option C: change imx51, iop32x, ixp4xx, versatile udeb kernel names to vmlinuz, update debian-installer and cdimage to use that, test all flavours
- option D: change imx51, iop32x, ixp4xx, versatile udeb kernel names to vmlinuz-$FLAVOUR, update debian-installer and cdimage to use that, test all flavours

The most desirable is probably D which requires the most work; C and D are more risky than B which is more risky than A.

Bye

Tags: armel
Revision history for this message
Loïc Minier (lool) wrote :

Suffix changes to debian/d-i/kernel-versions.in:
- option B, change imx51 from "y" to "-"
- option C, change imx51, iop32x, ixp4xx, versatile from "y" to "-"
- option D, change imx51, iop32x, ixp4xx, versatile from "y" to "-imx51", "-iop32x", "-ixp4xx", "-versatile" respectively

Changed in linux (Ubuntu Jaunty):
importance: Undecided → High
milestone: none → ubuntu-9.04
Revision history for this message
Loïc Minier (lool) wrote :

Sorry, there's also this option:
- option E: change imx51 udeb kernel name to vmlinuz-imx51, update debian-installer and cdimage to use that, test imx51
less desirable than D, but more than B, and less risky than C and D

Revision history for this message
Steve Langasek (vorlon) wrote :

this missed the cut for the kernel freeze; we'll need another solution for 9.04.

Changed in linux (Ubuntu Jaunty):
status: New → Won't Fix
Revision history for this message
Loïc Minier (lool) wrote :

Was discussed during release meeting, conclusion is to defer to karmic; do NOT address in SRU.

Changed in linux (Ubuntu Jaunty):
milestone: ubuntu-9.04 → none
Leann Ogasawara (leannogasawara)
Changed in linux (Ubuntu):
milestone: ubuntu-9.04 → none
status: New → Triaged
Revision history for this message
Loïc Minier (lool) wrote :

Since we're discussing karmic stuff, I think option D would be the best one. :-)

Brad Figg (brad-figg)
Changed in linux (Ubuntu):
assignee: nobody → brad-figg
Revision history for this message
Brad Figg (brad-figg) wrote :

Work on this is defered until we settle on which arm instruction set we'll be using for Karmic. Per rtg, if we decide to compile for v7, most of the armel flavours will disappear.

Paul Larson (pwlars)
tags: removed: arm
Revision history for this message
Loïc Minier (lool) wrote :

I don't think this change is related to changes in flavours: just change the naming scheme with whatever you have now and use the same naming scheme when adding flavours (option D). I wish we fix this early in the cycle to allow for d-i and cdimage changes afterwards.

Revision history for this message
Colin Watson (cjwatson) wrote :

I agree; there's no reason this should need to wait for flavours to settle.

Loïc Minier (lool)
affects: linux (Ubuntu Karmic) → linux-fsl-imx51 (Ubuntu Karmic)
Loïc Minier (lool)
Changed in linux-mvl-dove (Ubuntu Jaunty):
status: New → Won't Fix
Changed in linux-mvl-dove (Ubuntu Karmic):
assignee: nobody → Brad Figg (brad-figg)
importance: Undecided → High
status: New → Triaged
Changed in linux-fsl-imx51 (Ubuntu Karmic):
assignee: Brad Figg (brad-figg) → Amit Kucheria (amitk)
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Set suffix to 'n' in debian.mvl-dove/d-i/kernel-versions.in

Changed in linux-mvl-dove (Ubuntu Karmic):
status: Triaged → Fix Committed
Revision history for this message
Tim Gardner (timg-tpi) wrote :

Set suffix to 'n' in debian.fsl-imx51/d-i/kernel-versions.in

Changed in linux-fsl-imx51 (Ubuntu Karmic):
status: Triaged → Fix Committed
Revision history for this message
Loïc Minier (lool) wrote :

Tim, I see the fix committed in the fsl branch but not in the mvl one.

Changed in linux-mvl-dove (Ubuntu Karmic):
status: Fix Committed → Triaged
Brad Figg (brad-figg)
Changed in linux-mvl-dove (Ubuntu Karmic):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux-mvl-dove - 2.6.31-204.10

---------------
linux-mvl-dove (2.6.31-204.10) karmic; urgency=low

  [ Tim Gardner ]

  * [Config] Don't include ABI or version in vmlinuz name in kernel-image
    - LP: #359049

  [ Brad Figg ]

  * Rebase against master 878e32db158b972b443c5cd8370b2d52068bcaaf, v2.6.31 final

 -- Tim Gardner <email address hidden> Thu, 10 Sep 2009 16:29:38 -0600

Changed in linux-mvl-dove (Ubuntu Karmic):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (13.5 KiB)

This bug was fixed in the package linux-fsl-imx51 - 2.6.31-101.8

---------------
linux-fsl-imx51 (2.6.31-101.8) karmic; urgency=low

  [ Alan Tull ]

  * ARM: IMX51: ENGR00114681 pcm: set minimum period to 2k
  * ARM: IMX51: ENGR00114820-1 Revert SGTL5000: Enable amixer controls
    Jack/Speaker Function
  * ARM: IMX51: ENGR00114820-2 sgtl5000: pop fixes
  * ARM: IMX51: ENGR00114867 MX51: tristate i2c levelshifter
  * ARM: IMX51: ENGR00115688 dvi: disable edid read
  * ARM: IMX51: ENGR00115618-1 sgtl5000: power reduction pop fix
  * ARM: IMX51: ENGR00115618-2 sgtl5000: power savings
  * ARM: IMX51: ENGR00115754 sgtl5000: power mic bias earlier

  [ Amit Kucheria ]

  * [Config] Run updateconfigs after rebasing to 2.6.31-rc8
  * ARM: IMX51: Make sgt5000 driver compile
  * [Upstream] Remove X86 dependency for the rt3070 driver
    - LP: #423767
  * [Config] Enable rt3070 from staging for imx51
    - LP: #423767
  * [Config] Set CONFIG_LSM_MMAP_MIN_ADDR to 0
  * [Config] imx51: Enable APM_EMULATION as per imx51_defconfig
  * ARM: IMX51: Fix compile of mxc_dataflash.c by replacing bus_id
  * ARM: IMX51: Don't let the dataflash driver hitch a ride on CONFIG_MTD
  * [Config] imx51: disable MTD_MXC_DATAFLASH
  * [Config] Run updateconfigs after rebasing to 2.6.31 final
  * [Config] imx51: updateconfigs after applying sdk-1.6 patches
  * ARM: IMX51: Remove cpu_is_mx2/cpu_is_mx3 definition from hardware.h
  * ARM: IMX51: Paramters to module_param_call should be NULL

  [ Ann Thornton ]

  * ARM: IMX51: ENGR00113055-1 Add ability to read and user EDID info
  * ARM: IMX51: ENGR00113055-2 Added ability to read EDID data and use it
    to set monitor.
  * ARM: IMX51: ENGR00114026 MX51 Prevent 2nd initialization of
    framebuffer.
  * ARM: IMX51: ENGR00114023-1 Support for dual monitors.
  * ARM: IMX51: ENGR00114023-2 MX51: Add support for dual monitors.
  * ARM: IMX51: ENGR00114024 Enable 720p via HDMI

  [ Arik Gubeskys ]

  * ARM: IMX51: ENGR00114210 IPU IC bypass mode: move display configuration
    to the FB driver

  [ b00984 ]

  * ARM: IMX51: ENGR00113773 Add apm support for mc13892 battery
  * ARM: IMX51: ENGR00114655 mitsubishi lvds xga lcd support for babbage
    2.5

  [ Dinh Nguyen ]

  * ARM: IMX51: ENGR00114282 MX51: Disable L2 SRPG
  * ARM: IMX51: ENGR00114453 MX51: Add support for keypad on Babbage 2.5
    board

  [ Guoqing Jiang ]

  * ARM: IMX51: ENGR00113618 Audio: Workaround for sgtl5000 codec suspend
    failure issue on MX25

  [ Jason ]

  * ARM: IMX51: ENGR00114157-1 Add SPI data flash driver support
  * ARM: IMX51: ENGR00114157-2 Add SPI data flash support for MX51
    babbage2.5
  * ARM: IMX51: ENGR00114189 Enlarge the rootfs partition to accommodate
    Gnome-mobile
  * ARM: IMX51: ENGR00113990 Fix for mtd_oobtest test failure
  * ARM: IMX51: ENGR00114882 Reset NFC delay line register
  * ARM: IMX51: ENGR00114880 Data abort on NFC memory byte access
  * ARM: IMX51: ENGR00115329 Enable NFC symmetric mode on MX51
  * ARM: IMX51: ENGR00115330 Fix ECC mode setting for MX51TO3
  * ARM: IMX51: ENGR00115336 Fix setting NFC FW for 16bit nand flash
    support on MX51

  [ JasonHua ]

  * ARM: IMX51: ENGR00113106 MX25 Camera: Some ker...

Changed in linux-fsl-imx51 (Ubuntu Karmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.