Activity log for bug #863629

Date Who What changed Old value New value Message
2011-09-30 20:27:51 Serge Hallyn bug added bug
2011-09-30 20:28:00 Serge Hallyn libvirt (Ubuntu): status New Confirmed
2011-09-30 20:28:07 Serge Hallyn libvirt (Ubuntu): importance Undecided High
2011-09-30 20:29:22 Serge Hallyn attachment added Debdiff with the proposed fix https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/863629/+attachment/2489083/+files/libvirt-lxc-pty.debdiff
2011-09-30 20:32:22 Scott Moser tags server-o-nrs
2011-09-30 20:32:47 Scott Moser bug added subscriber Scott Moser
2011-10-01 00:08:47 Ubuntu Foundations Team Bug Bot tags server-o-nrs patch server-o-nrs
2011-10-01 00:08:48 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Sponsors Team
2011-10-12 21:52:38 Serge Hallyn attachment added libvirt-ptyfix-v2.debdiff https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/863629/+attachment/2539254/+files/libvirt-ptyfix-v2.debdiff
2011-10-14 16:52:04 Serge Hallyn attachment added libvirt-lxc-pty-noglibc.debdiff https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/863629/+attachment/2544737/+files/libvirt-lxc-pty-noglibc.debdiff
2011-10-14 17:00:12 Launchpad Janitor libvirt (Ubuntu): status Confirmed Fix Released
2011-11-01 18:31:10 Serge Hallyn nominated for series Ubuntu Lucid
2011-11-01 18:31:10 Serge Hallyn bug task added libvirt (Ubuntu Lucid)
2011-11-01 18:31:10 Serge Hallyn nominated for series Ubuntu Maverick
2011-11-01 18:31:10 Serge Hallyn bug task added libvirt (Ubuntu Maverick)
2011-11-01 18:31:10 Serge Hallyn nominated for series Ubuntu Natty
2011-11-01 18:31:10 Serge Hallyn bug task added libvirt (Ubuntu Natty)
2011-11-01 18:31:10 Serge Hallyn nominated for series Ubuntu Oneiric
2011-11-01 18:31:10 Serge Hallyn bug task added libvirt (Ubuntu Oneiric)
2011-11-01 18:32:20 Serge Hallyn description lxcControllerRun() is calling virFileOpenTtyAt() with a slave opened on /the/container/chroot/dev/pts. While it is not documented in the manpages, glibc's grantpt does a first check (ensuring that the passed in fd is a pty slave) with '/dev/pts' as the hardcoded path, appending the pty#. lxcControllerRun always calls this on the first slave opened after creating the new /dev/pts, so grantpt is always checking /dev/pts/0. Therefore, if your host does not have /dev/pts/0 (easy to reproduce using screen), then grantpt will fail, and the container creation will subsequently also fail. lxcControllerRun() is calling virFileOpenTtyAt() with a slave opened on /the/container/chroot/dev/pts. While it is not documented in the manpages, glibc's grantpt does a first check (ensuring that the passed in fd is a pty slave) with '/dev/pts' as the hardcoded path, appending the pty#. lxcControllerRun always calls this on the first slave opened after creating the new /dev/pts, so grantpt is always checking /dev/pts/0. Therefore, if your host does not have /dev/pts/0 (easy to reproduce using screen), then grantpt will fail, and the container creation will subsequently also fail. ================================================================= SRU Justification: 1. Impact: libvirt will be unable to create lxc containers, saying that it cannot allocate /dev/pts/0 2. Development fix: A patch was sent upstream which makes libvirt-lxc not use glibc's grantpt, which is the cause of the bug. 3. Stable fix: same as the development fix. 4. Test case: 0. [ Set up libvirt and create a libvirt-lxc container ] 1. make sure noone is logged into the server 2. log in, make sure your tty is /dev/pts/0 (check with 'tty') 3. Pin /dev/pts/0 by doing "sleep 2h & disown; exit" 4. Try to start a container on that system. Without this fix it will fail with an error about /dev/pts/0. 5. Regression potential: if the patch was bad, it could cause failures when starting a container, or other places when libvirt allocates a tty. =================================================================
2011-11-01 18:32:33 Serge Hallyn bug added subscriber Ubuntu Stable Release Updates Team
2011-11-01 18:32:47 Serge Hallyn libvirt (Ubuntu Lucid): status New In Progress
2011-11-01 18:33:10 Serge Hallyn libvirt (Ubuntu Lucid): status In Progress New
2011-11-02 18:17:35 Martin Pitt libvirt (Ubuntu Oneiric): status New Fix Committed
2011-11-02 18:17:38 Martin Pitt bug added subscriber SRU Verification
2011-11-02 18:17:40 Martin Pitt tags patch server-o-nrs patch server-o-nrs verification-needed
2011-11-07 17:04:25 Martin Pitt tags patch server-o-nrs verification-needed patch server-o-nrs verification-done
2011-11-08 23:58:40 Clint Byrum removed subscriber Ubuntu Sponsors Team
2011-11-10 05:45:18 Launchpad Janitor libvirt (Ubuntu Oneiric): status Fix Committed Fix Released
2011-11-14 06:28:46 Martin Pitt libvirt (Ubuntu Lucid): status New Fix Committed
2011-11-14 06:28:51 Martin Pitt tags patch server-o-nrs verification-done patch server-o-nrs
2011-11-14 06:28:53 Martin Pitt tags patch server-o-nrs patch server-o-nrs verification-needed
2011-11-14 19:34:24 Serge Hallyn libvirt (Ubuntu Lucid): status Fix Committed Won't Fix
2011-11-14 19:34:41 Serge Hallyn tags patch server-o-nrs verification-needed patch server-o-nrs verification-failed
2011-11-14 20:46:21 Serge Hallyn libvirt (Ubuntu Lucid): status Won't Fix Confirmed
2011-11-14 20:46:39 Serge Hallyn tags patch server-o-nrs verification-failed patch server-o-nrs verification-needed
2011-11-15 06:10:34 Martin Pitt libvirt (Ubuntu Maverick): status New Fix Committed
2011-11-15 06:11:55 Martin Pitt libvirt (Ubuntu Natty): status New Fix Committed
2011-11-15 16:03:31 Martin Pitt libvirt (Ubuntu Lucid): status Confirmed Fix Committed
2011-11-15 16:03:39 Martin Pitt tags patch server-o-nrs verification-needed patch server-o-nrs verification-done-lucid verification-needed
2011-11-18 05:18:11 Martin Pitt tags patch server-o-nrs verification-done-lucid verification-needed patch server-o-nrs verification-done-lucid verification-done-maverick verification-needed
2011-12-02 16:44:10 Serge Hallyn tags patch server-o-nrs verification-done-lucid verification-done-maverick verification-needed patch server-o-nrs verification-done-lucid verification-done-maverick verification-done-natty
2011-12-02 17:17:58 Clint Byrum tags patch server-o-nrs verification-done-lucid verification-done-maverick verification-done-natty patch server-o-nrs verification-done
2011-12-05 05:50:47 Launchpad Janitor libvirt (Ubuntu Lucid): status Fix Committed Fix Released
2011-12-05 05:51:44 Launchpad Janitor libvirt (Ubuntu Maverick): status Fix Committed Fix Released
2011-12-05 05:52:30 Launchpad Janitor libvirt (Ubuntu Natty): status Fix Committed Fix Released
2012-01-11 10:29:30 Launchpad Janitor branch linked lp:ubuntu/libvirt
2012-04-11 10:13:16 Launchpad Janitor branch linked lp:ubuntu/lucid-proposed/libvirt
2012-04-11 10:13:28 Launchpad Janitor branch linked lp:ubuntu/maverick-updates/libvirt
2012-04-11 10:17:17 Launchpad Janitor branch linked lp:ubuntu/oneiric-proposed/libvirt
2012-04-11 10:17:20 Launchpad Janitor branch linked lp:ubuntu/natty-updates/libvirt