[Upstream] Calc XY (scatter) chart Sort by x values has wrong x,y in tooltip

Created attachment 46954
xyscatterbug.ods

Downstream bug may be found at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/258705

OOo bug may be found at:
http://openoffice.org/bugzilla/show_bug.cgi?id=95508

1) lsb_release -rd
Description: Ubuntu 11.04
Release: 11.04

2) LibreOffice:
apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.2-1ubuntu5
  Candidate: 1:3.3.2-1ubuntu5
  Version table:
 *** 1:3.3.2-1ubuntu5 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty-updates/main i386 Packages
        500 http://us.archive.ubuntu.com/ubuntu/ natty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     1:3.3.2-1ubuntu4 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty/main i386 Packages

3) What is expected to happen in Calc via the Terminal:

cd ~/Desktop && wget https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/258705/+attachment/403067/+files/xyscatterbug.ods && localc -nologo xyscatterbug.ods

double click the XY (Scatter), sorted by X values chart and hover the mouse icon over a data point, the pop up notes the correct X,Y value.

4) What happens instead is it does not. The pop-up is using the data values top to bottom, to display the data point values from left to right.

Created attachment 46954
xyscatterbug.ods

Downstream bug may be found at:
https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/258705

OOo bug may be found at:
http://openoffice.org/bugzilla/show_bug.cgi?id=95508

1) lsb_release -rd
Description: Ubuntu 11.04
Release: 11.04

2) LibreOffice:
apt-cache policy libreoffice-calc
libreoffice-calc:
  Installed: 1:3.3.2-1ubuntu5
  Candidate: 1:3.3.2-1ubuntu5
  Version table:
 *** 1:3.3.2-1ubuntu5 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty-updates/main i386 Packages
        500 http://us.archive.ubuntu.com/ubuntu/ natty-proposed/main i386 Packages
        100 /var/lib/dpkg/status
     1:3.3.2-1ubuntu4 0
        500 http://us.archive.ubuntu.com/ubuntu/ natty/main i386 Packages

3) What is expected to happen in Calc via the Terminal:

cd ~/Desktop && wget https://bugs.launchpad.net/ubuntu/+source/openoffice.org/+bug/258705/+attachment/403067/+files/xyscatterbug.ods && localc -nologo xyscatterbug.ods

double click the XY (Scatter), sorted by X values chart and hover the mouse icon over a data point, the pop up notes the correct X,Y value.

4) What happens instead is it does not. The pop-up is using the data values top to bottom, to display the data point values from left to right.

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html

[This is an automated message.]
This bug was filed before the changes to Bugzilla on 2011-10-16. Thus it
started right out as NEW without ever being explicitly confirmed. The bug is
changed to state NEEDINFO for this reason. To move this bug from NEEDINFO back
to NEW please check if the bug still persists with the 3.5.0 beta1 or beta2 prereleases.
Details on how to test the 3.5.0 beta1 can be found at:
http://wiki.documentfoundation.org/QA/BugHunting_Session_3.5.0.-1

more detail on this bulk operation: http://nabble.documentfoundation.org/RFC-Operation-Spamzilla-tp3607474p3607474.html

Reproducible in:
LOdev 3.5.0beta2
Build ID: 8589e48-760cc4d-f39cf3d-1b2857e-60db978
Microsoft Windows Vista Business 6.0.6002 Service Pack 2 Build 6002

Reproducible in:
LOdev 3.5.0beta2
Build ID: 8589e48-760cc4d-f39cf3d-1b2857e-60db978
Microsoft Windows Vista Business 6.0.6002 Service Pack 2 Build 6002

Hi Christopher

I can confirm that using your explanation I can reproducible that problem. But if I build XY chart from scratch using your data it's not happen.

Could you confirm using LO 4.0.3.3 whether tooltips still show wrong info?

Hi Christopher

I can confirm that using your explanation I can reproducible that problem. But if I build XY chart from scratch using your data it's not happen.

Could you confirm using LO 4.0.3.3 whether tooltips still show wrong info?

ign_christian, thank you for your comments. Using the attachment noted in the Description https://bugs.freedesktop.org/attachment.cgi?id=46954 one may open Microsoft Office Professional Plus 2010 Excel Version 14.0.6023.1000 (32-bit), hover over the noted data point, and it displays the correct tooltip information. For future triaging, let the focus be on the noted attachment.

Problem in Description reproducible in:
Microsoft Windows Vista Business x86 6.0.6002 Service Pack 2 Build 6002
Version: 4.2.0.0.alpha0+
Build ID: 979def88090633bfee0e0445b19999a1dac71ed

ign_christian, thank you for your comments. Using the attachment noted in the Description https://bugs.freedesktop.org/attachment.cgi?id=46954 one may open Microsoft Office Professional Plus 2010 Excel Version 14.0.6023.1000 (32-bit), hover over the noted data point, and it displays the correct tooltip information. For future triaging, let the focus be on the noted attachment.

Problem in Description reproducible in:
Microsoft Windows Vista Business x86 6.0.6002 Service Pack 2 Build 6002
Version: 4.2.0.0.alpha0+
Build ID: 979def88090633bfee0e0445b19999a1dac71ed

I was using that attachment. Just wondering why creating new XY chart on that attachment generates correct result?

I was using that attachment. Just wondering why creating new XY chart on that attachment generates correct result?

On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.

If I create from the file attached a new graphic, I could reproduce too the problem.
(ign_christian: had you checked "Sort by X Values"?)

On pc Debian x86-64 with master sources updated yesterday, I could reproduce this.

If I create from the file attached a new graphic, I could reproduce too the problem.
(ign_christian: had you checked "Sort by X Values"?)

You're right Julien, reproducible with "Sort by X values" checked with LO 4.3.1.1. Looks like I forgot checked that in previous testing :)

Anyway I don't understand the purpose of "Sort by X values" in XY chart. It doesn't make any difference in chart.

You're right Julien, reproducible with "Sort by X values" checked with LO 4.3.1.1. Looks like I forgot checked that in previous testing :)

Anyway I don't understand the purpose of "Sort by X values" in XY chart. It doesn't make any difference in chart.

Thank you ign_christian for your feedback. Great (in a way) you could reproduce it too :)

Just some notes.
Searching "Sort by X Values" with keyId language gives this:
https://translations.documentfoundation.org/fr/translate/#search=CFYgL&sfields=source,target,notes
=> tp_ChartType.ui

http://opengrok.libreoffice.org/search?q=tp_ChartType.ui&project=core&defs=&refs=&path=&hist= gives:
- chart2/source/controller/dialogs/tp_PointGeometry.cxx
- chart2/source/controller/dialogs/tp_ChartType.cxx
From the second one, searching "sort" keyword gives mpCB_XValueSorting, itself linked to "bSortByXValues" member of ChartTypeParameter, see http://opengrok.libreoffice.org/xref/core/chart2/source/controller/dialogs/ChartTypeDialogController.hxx#81

Thank you ign_christian for your feedback. Great (in a way) you could reproduce it too :)

Just some notes.
Searching "Sort by X Values" with keyId language gives this:
https://translations.documentfoundation.org/fr/translate/#search=CFYgL&sfields=source,target,notes
=> tp_ChartType.ui

http://opengrok.libreoffice.org/search?q=tp_ChartType.ui&project=core&defs=&refs=&path=&hist= gives:
- chart2/source/controller/dialogs/tp_PointGeometry.cxx
- chart2/source/controller/dialogs/tp_ChartType.cxx
From the second one, searching "sort" keyword gives mpCB_XValueSorting, itself linked to "bSortByXValues" member of ChartTypeParameter, see http://opengrok.libreoffice.org/xref/core/chart2/source/controller/dialogs/ChartTypeDialogController.hxx#81

bSortByXValues brings there:
http://opengrok.libreoffice.org/xref/core/chart2/source/view/main/ChartView.cxx#784

Searching about how is defined data point gives this:
STR_TIP_DATAPOINT which leads there:
http://opengrok.libreoffice.org/xref/core/chart2/source/controller/dialogs/ObjectNameProvider.cxx#498

But then, I'm a bit stuck.

Kohei/Markus/Eike: any idea here?

bSortByXValues brings there:
http://opengrok.libreoffice.org/xref/core/chart2/source/view/main/ChartView.cxx#784

Searching about how is defined data point gives this:
STR_TIP_DATAPOINT which leads there:
http://opengrok.libreoffice.org/xref/core/chart2/source/controller/dialogs/ObjectNameProvider.cxx#498

But then, I'm a bit stuck.

Kohei/Markus/Eike: any idea here?

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice (5.0.0.5 or later)
   https://www.libreoffice.org/download/

   If the bug is present, please leave a comment that includes the version of LibreOffice and your operating system, and any changes you see in the bug behavior

 If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:

1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.

4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for your help!

-- The LibreOffice QA Team This NEW Message was generated on: 2015-09-03

Confirmed with attachment.

Win 7 Pro 64-bit Version: 5.1.0.0.alpha1+
Build ID: b216cc1b8096eb60c27f67e8c27b7cd756c75e38
TinderBox: Win-x86@62-merge-TDF, Branch:MASTER, Time: 2015-11-12_00:06:20
Locale: fi-FI (fi_FI)

** Please read this message in its entirety before responding **

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present on a currently supported version of LibreOffice
(5.1.6 or 5.2.3 https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the version of LibreOffice and
your operating system, and any changes you see in the bug behavior

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave
a short comment that includes your version of LibreOffice and Operating System

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3)

http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to "inherited from OOo";
4b. If the bug was not present in 3.3 - add "regression" to keyword

Feel free to come ask questions or to say hello in our QA chat: http://webchat.freenode.net/?channels=libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug-20170103

Dear Christopher M. Penalver,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from http://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://kiwiirc.com/nextclient/irc.freenode.net/#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

The bug is still present in version: 7.1.0.0.alpha1+

I had a look, it is due to the "sort by X value" being done in the view part (in VDataSeries::doSortByXValues()) without updating the model data, while the tooltip text is generated by lcl_getDataPointValueText in ObjectNameProvider.cxx in the controller part, which has access to the model data, but not the view data and the VDataSeries correctly sorted.

Does it mean the sort should be done elsewhere and apply to the model data as well?

(In reply to Leyan from comment #14)
> The bug is still present in version: 7.1.0.0.alpha1+
>
> I had a look, it is due to the "sort by X value" being done in the view part
> (in VDataSeries::doSortByXValues()) without updating the model data, while
> the tooltip text is generated by lcl_getDataPointValueText in
> ObjectNameProvider.cxx in the controller part, which has access to the model
> data, but not the view data and the VDataSeries correctly sorted.
>
> Does it mean the sort should be done elsewhere and apply to the model data
> as well?

Good job! Would you be interested in proposing a patch?
Indeed, it seems you made most of the way for this since I suppose you:
- downloaded LO sources
- built it
- analyzed the code + found root cause
- began to think about a fix
So the only things to do would be:
- provide license statement (just an email on LO dev)
- create gerrit account
- submit a patch
If yes, here's a link to take a look:
https://wiki.documentfoundation.org/Development/GetInvolved

I do have a Gerrit account and a license statement, but it seems you are missing one tiny little step, which is to actually write the correction. I haven't done it.

It is probably not very hard for someone familiar with the code, but I am not sure how to go about it, hence the question.

(In reply to Leyan from comment #16)
> ...
> It is probably not very hard for someone familiar with the code, but I am
> not sure how to go about it, hence the question.

Indeed, I should have taken a look at git history, I would have seen https://cgit.freedesktop.org/libreoffice/core/commit/?id=c1b96424b65aed2401a3e86d53a48cc12284de7c.

Dear Christopher M. Penalver,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.

If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not
appropriate in this case)

If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword

Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug

I can confirm that the bug is present in

Version: 7.5.5.1 (X86_64) / LibreOffice Community
Build ID: 2c5e46c1980ec5241359fd65d751dc518205e7af
CPU threads: 4; OS: Linux 6.3; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

*** Bug 86706 has been marked as a duplicate of this bug. ***

Present in OOo 3.3, so inherited.

*** Bug 156237 has been marked as a duplicate of this bug. ***

Setting priority back to normal, and changing the summary, as this does not affect only the tooltips.
As shown by duplicate reports:
- static data point labels are also wrong (bug 156237)
- linked data in cells does not match (bug 86706)

Hossein, is this in the realm of easyHack or not at all?