Ubuntu
libdbusmenu package

Accelerators broken in Firefox menus with dbusmenu 0.5.99-0ubuntu2

Bug #982656 reported by Chris Coulson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
DBus Menu
Fix Released
High
Ted Gould
DBus Menu 0.6.2
libdbusmenu (Ubuntu)
Fix Released
High
Unassigned
Precise
Fix Released
High
Unassigned

Bug Description

I just noticed this evening that accelerators are missing from the History and Bookmarks menus in Firefox. After downgrading dbusmenu a few times, it seems that this worked last in 0.5.99-0ubuntu1 (and stopped working in 0.5.99-0ubuntu2).

The attached screenshot shows the issue. The "Show All History" item should have an accelerator item that says "Ctrl+Shift+H". The attached output from dbusmenu-dumper shows that Firefox is setting the correct shortcut property on this menuitem

Related branches

lp://staging/~ted/libdbusmenu/lp982656
Charles Kerr (community): Approve
Diff: 23 lines (+1/-2)
1 file modified
libdbusmenu-gtk/genericmenuitem.c (+1/-2)
lp://staging/ubuntu/precise-proposed/libdbusmenu
lp://staging/libdbusmenu/12.10
lp://staging/~dbusmenu-team/ubuntu/precise/libdbusmenu/upstream
Ken VanDine: Pending requested
Diff: 11864 lines (+11365/-22)
62 files modified
ChangeLog (+32/-0)
configure (+11/-11)
configure.ac (+3/-3)
debian/changelog (+10/-0)
docs/libdbusmenu-glib/reference/html/annotation-glossary.html (+83/-0)
docs/libdbusmenu-glib/reference/html/api-index-deprecated.html (+31/-0)
docs/libdbusmenu-glib/reference/html/api-index-full.html (+593/-0)
docs/libdbusmenu-glib/reference/html/ch01.html (+50/-0)
docs/libdbusmenu-glib/reference/html/index.html (+49/-0)
docs/libdbusmenu-glib/reference/html/index.sgml (+176/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuClient.html (+607/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html (+1893/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitemProxy.html (+166/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuServer.html (+412/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-Types.html (+276/-0)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib.devhelp2 (+161/-0)
docs/libdbusmenu-glib/reference/html/object-tree.html (+32/-0)
docs/libdbusmenu-glib/reference/html/style.css (+266/-0)
docs/libdbusmenu-glib/reference/tmpl/client.sgml (+228/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem-proxy.sgml (+59/-0)
docs/libdbusmenu-glib/reference/tmpl/menuitem.sgml (+721/-0)
docs/libdbusmenu-glib/reference/tmpl/server.sgml (+171/-0)
docs/libdbusmenu-glib/reference/tmpl/types.sgml (+109/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-1)
docs/libdbusmenu-glib/reference/xml/annotation-glossary.xml (+80/-0)
docs/libdbusmenu-glib/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-glib/reference/xml/api-index-full.xml (+153/-0)
docs/libdbusmenu-glib/reference/xml/client.xml (+448/-0)
docs/libdbusmenu-glib/reference/xml/menuitem-proxy.xml (+114/-0)
docs/libdbusmenu-glib/reference/xml/menuitem.xml (+1331/-0)
docs/libdbusmenu-glib/reference/xml/server.xml (+309/-0)
docs/libdbusmenu-glib/reference/xml/types.xml (+192/-0)
docs/libdbusmenu-gtk/reference/html/annotation-glossary.html (+47/-0)
docs/libdbusmenu-gtk/reference/html/api-index-deprecated.html (+31/-0)
docs/libdbusmenu-gtk/reference/html/api-index-full.html (+119/-0)
docs/libdbusmenu-gtk/reference/html/ch01.html (+45/-0)
docs/libdbusmenu-gtk/reference/html/index.html (+44/-0)
docs/libdbusmenu-gtk/reference/html/index.sgml (+43/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkClient.html (+347/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-DbusmenuGtkMenu.html (+187/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-menuitem.html (+274/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk-parser.html (+118/-0)
docs/libdbusmenu-gtk/reference/html/libdbusmenu-gtk.devhelp2 (+38/-0)
docs/libdbusmenu-gtk/reference/html/object-tree.html (+32/-0)
docs/libdbusmenu-gtk/reference/html/style.css (+266/-0)
docs/libdbusmenu-gtk/reference/tmpl/client.sgml (+110/-0)
docs/libdbusmenu-gtk/reference/tmpl/menu.sgml (+56/-0)
docs/libdbusmenu-gtk/reference/tmpl/menuitem.sgml (+86/-0)
docs/libdbusmenu-gtk/reference/tmpl/parser.sgml (+42/-0)
docs/libdbusmenu-gtk/reference/version.xml (+1/-1)
docs/libdbusmenu-gtk/reference/xml/annotation-glossary.xml (+32/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-deprecated.xml (+8/-0)
docs/libdbusmenu-gtk/reference/xml/api-index-full.xml (+32/-0)
docs/libdbusmenu-gtk/reference/xml/client.xml (+238/-0)
docs/libdbusmenu-gtk/reference/xml/menu.xml (+133/-0)
docs/libdbusmenu-gtk/reference/xml/menuitem.xml (+178/-0)
docs/libdbusmenu-gtk/reference/xml/parser.xml (+77/-0)
libdbusmenu-glib/enum-types.h (+1/-1)
libdbusmenu-glib/enum-types.h.in (+1/-1)
libdbusmenu-gtk/genericmenuitem-enum-types.h (+1/-1)
libdbusmenu-gtk/genericmenuitem-enum-types.h.in (+1/-1)
libdbusmenu-gtk/genericmenuitem.c (+2/-2)
lp://staging/ubuntu/quantal/libdbusmenu
lp://staging/~ubuntu-desktop/libdbusmenu/ubuntu (Merged)
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
Revision history for this message
Chris Coulson (chrisccoulson) wrote :
Changed in libdbusmenu (Ubuntu Precise):
importance: Undecided → Medium
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

@@ -287,11 +312,15 @@
  if (labelw == NULL) {
   /* Build it */
   labelw = GTK_LABEL(gtk_accel_label_new(local_label));
- gtk_label_set_use_underline(GTK_LABEL(labelw), TRUE);
   gtk_label_set_use_markup(GTK_LABEL(labelw), TRUE);
   gtk_misc_set_alignment(GTK_MISC(labelw), 0.0, 0.5);
- gtk_accel_label_set_accel_widget(GTK_ACCEL_LABEL(labelw), GTK_WIDGET(menu_item));
- gtk_label_set_markup_with_mnemonic(labelw, local_label);
+
+ if (has_mnemonic(in_label, FALSE)) {
+ gtk_label_set_use_underline(GTK_LABEL(labelw), TRUE);
+ gtk_accel_label_set_accel_widget(GTK_ACCEL_LABEL(labelw), GTK_WIDGET(menu_item));
+ gtk_label_set_markup_with_mnemonic(labelw, local_label);
+ }
+
   gtk_widget_show(GTK_WIDGET(labelw));

   /* Check to see if it needs to be in the bin for this

Surely the call to gtk_accel_label_set_accel_widget() should be outside of this conditional?

Sebastien Bacher (seb128)
Changed in libdbusmenu (Ubuntu Precise):
importance: Medium → High
Changed in dbusmenu:
importance: Undecided → High
Revision history for this message
Charles Kerr (charlesk) wrote :

Chris, both the display and activation of ctrl-shift-h works for me under:

  * firefox 11.0+build1-0ubuntu4
  * libdbusmenu-gtk4 0.6.1-0ubuntu2

The code block you reference in comment #3 is differs from current trunk after ted's two patches http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk.0.6/revision/411 and http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk.0.6/revision/413

Can you test out whether or not the bug you're seeing is reproductible for you in libdbusmenu-gtk4 0.6.1-0ubuntu2 ?

Changed in dbusmenu:
status: New → Incomplete
Changed in libdbusmenu (Ubuntu Precise):
status: New → Incomplete
Revision history for this message
Charles Kerr (charlesk) wrote :
Revision history for this message
Charles Kerr (charlesk) wrote :

Ignore comments #4 and #5, I had a different version of dbusmenu hardwired into /usr/lib over the weekend and forgot to revert to stock settings before testing this.

Changed in dbusmenu:
status: Incomplete → New
Changed in libdbusmenu (Ubuntu Precise):
status: Incomplete → New
Ted Gould (ted)
Changed in dbusmenu:
status: New → Confirmed
assignee: nobody → Ted Gould (ted)
milestone: none → 0.6.2
Sebastien Bacher (seb128)
Changed in libdbusmenu (Ubuntu Precise):
status: New → Fix Committed
Charles Kerr (charlesk)
summary: - Accelarators broken in Firefox menus with dbusmenu 0.5.99-0ubuntu2
+ Accelerators broken in Firefox menus with dbusmenu 0.5.99-0ubuntu2
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libdbusmenu - 0.6.1-0ubuntu3

---------------
libdbusmenu (0.6.1-0ubuntu3) precise-proposed; urgency=low

  * Backport fix for keybindings not showing in menus bug (lp: #982656)
 -- Sebastien Bacher <email address hidden> Mon, 16 Apr 2012 21:28:05 +0200

Changed in libdbusmenu (Ubuntu Precise):
status: Fix Committed → Fix Released
Ted Gould (ted)
Changed in dbusmenu:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.