libavg version 1.5.4-0ubuntu2 failed to build in oneiric

Dear Colin, can we keep in touch? It's possible that we may manage to fix this bug upstream during the weekend, although we still have no assessment upon it (no time until now).

The changes seem relatively straightforward (at least if you've spent much of the last couple of weeks bulk-porting everything that still relied on the old API ...). Would you like to review the attached patch?

Dear Colin,
it looks great, thanks.
We'll integrate it upstream and prepare an up to date package for 12.04.

Excellent, thanks for checking it. Am I OK to go ahead and upload this
as an Ubuntu patch for Oneiric?

Colin, I've just tested it on a up to date oneiric and I got this:

Making all in video
make[3]: Entering directory `/home/xi/devel/oneiric/libavg-1.5.4/src/video'
/bin/bash ../../libtool --tag=CXX --mode=link g++ -Wno-invalid-offsetof -msse2 -g -O2 -rdynamic -o testvideo testvideo.o ./libvideo.la ../audio/libaudio.la ../graphics/libgraphics.la ../base/libbase.la -lxml2 -lboost_thread -lavutil -lavcodec -lavformat -lswscale -lGraphicsMagick++ -lGraphicsMagick -lrt
libtool: link: g++ -Wno-invalid-offsetof -msse2 -g -O2 -rdynamic -o testvideo testvideo.o ./.libs/libvideo.a ../audio/.libs/libaudio.a ../graphics/.libs/libgraphics.a ../base/.libs/libbase.a /usr/lib/libxml2.so -lboost_thread -lavutil -lavcodec -lavformat -lswscale -lGraphicsMagick++ -lGraphicsMagick -lrt
./.libs/libvideo.a(FFMpegDecoder.o): In function `avg::FFMpegDecoder::getStreamPF() const':
/home/xi/devel/oneiric/libavg-1.5.4/src/video/FFMpegDecoder.cpp:1144: undefined reference to `av_get_pix_fmt_name(PixelFormat)'

but:

xi@oneiric-a3-phy:~/devel/oneiric/libavg-1.5.4$ nm -D /usr/lib/libavformat.so | grep av_get_pix_fmt_name
                 U av_get_pix_fmt_name

$ dpkg -S /usr/lib/libavformat.so
libavformat-dev: /usr/lib/libavformat.so

$ dpkg -l libavformat-dev
ii libavformat-dev 4:0.7.1-3ubuntu1 Development files for libavformat

$ uname -a
Linux oneiric-a3-phy 3.0.0-9-generic #14-Ubuntu SMP Tue Aug 23 17:03:26 UTC 2011 x86_64 x86_64 x86_64 GNU/Linux

I don't get it..

Sorry about that - I'm not sure how that got past my testing. There were two problems. Firstly, the link line was in the wrong order; libraries should come after the objects/libraries that use symbols from them, so the PKG_CHECK_MODULES ordering in configure.in was wrong. This didn't actually fix the problem but I've included it in my updated patch anyway for completeness. Secondly, <libavutil/pixdesc.h> was being included as a C++ header rather than as a C header; the clue here was that the undefined reference was to av_get_pix_fmt_name(PixelFormat) rather than just to av_get_pix_fmt_name.

Please try the attached patch.

Clear! And thanks to you the fixes are also committed upstream.
The package compiles and all the tests are green. Please go ahead!

This bug was fixed in the package libavg - 1.5.4-0ubuntu3

---------------
libavg (1.5.4-0ubuntu3) oneiric; urgency=low

  * Port to libav 0.7 API (LP: #831190).
 -- Colin Watson <email address hidden> Mon, 29 Aug 2011 23:32:13 +0100