Ubuntu
libavg package

Setting CXXFLAGS drops the autoconf default "-g -O2"

Bug #752924 reported by OXullo Intersecans
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libavg (Ubuntu)
Fix Released
Undecided
OXullo Intersecans

Bug Description

Since version 1.0.1-1ubuntu1, CXXFLAGS is set, in order to add a define (__STDC_CONSTANT_MACROS) to fix a FTBFS caused by ffmpeg-related libraries c++ compilation. This broke the expected behavior of AC_PROG_CXX macro, which sets CXXFLAGS to "-g -O2" when CXXFLAGS is unset [1].

In this way, libavg binaries are compiled with no optimizations, which may lead to unexpected behavior (under linux, libavg is extensively tested with -O2).

[1]: http://www.gnu.org/software/autoconf/manual/autoconf.html (5.10.4)

OXullo Intersecans (oxullo)
Changed in libavg (Ubuntu):
status: New → In Progress
assignee: nobody → OXullo Intersecans (oxullo)
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Revision history for this message
OXullo Intersecans (oxullo) wrote :
Changed in libavg (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
OXullo Intersecans (oxullo) wrote :

The uploaded package source contain a fix for Bug #735548 (and its duplicate Bug #745868). Can anybody kindly upload?

Thanks!

Chase Douglas (chasedouglas)
Changed in libavg (Ubuntu):
status: Fix Committed → New
Revision history for this message
Scott Kitterman (kitterman) wrote :

Chase: Why did you change the status?

Revision history for this message
Chase Douglas (chasedouglas) wrote :

Hi Scott,

My understanding was that if you needed a package uploaded to Ubuntu, you should subscribe ubuntu-sponsors and set the status to new. Maybe I'm confusing the procedures for uploading with a freeze exception?

(To be clear, I don't think a freeze exception is needed here. I think ubuntu-release has been subscribed by mistake.)

Revision history for this message
Scott Kitterman (kitterman) wrote :

I dropped ubuntu-release (agree it's not needed).

That's a fine reason for setting it to New. Generally it's good to leave a comment explaining why you changed it.

Revision history for this message
OXullo Intersecans (oxullo) wrote :

Sorry, my fault. Actually it's the same mistake I made to get libavg upstream upgrade uploaded.

My apologies

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libavg - 1.5.4-0ubuntu2

---------------
libavg (1.5.4-0ubuntu2) natty; urgency=low

  * Build arch restricted to the supported i386 and amd64 (LP: #735548)
  * STDC macros define moved from CXXFLAGS to CPPFLAGS in order to autoconf
    to set correctly the default (LP: #752924)
 -- OXullo Intersecans <email address hidden> Wed, 06 Apr 2011 23:46:15 +0200

Changed in libavg (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.