Add upstream fix for Dell PCIeSSD devices
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ledmon (Debian) |
Fix Released
|
Unknown
|
|||
ledmon (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Raring |
Fix Released
|
Low
|
Unassigned |
Bug Description
[Impact]
* The ledmon version included in Raring contained a bug that broke PCIe SSD devices
on Dell Server Hardware. The Dell PCIE SSDs do not have a 'hostN' field in their sysfs paths as they are block devices directly connected to their host PCI device.
* The bug caused these devices to stop being recognized properly in the OS.
[Test Case]
* Install ledmon 0.74-1 onto a raring server with the appropriate PCIE SSD hardware.
* run 'sudo ledmon' to start the led monitor.
* Look in /var/log/
ledmon[2449]: Device (null) : No host_id!
ledmon[2449]: DETACHED DEV '(null)' in failed state
* With the upstream patch in place and after restarting ledmon, the "no host_id" and "DETACHED_DEV" messages will go away and the PCIe SSD devices are detected correctly.
[Regression Potential]
* Low. This fix is very targeted to the PCIE SSD hardware on Dell systems, and should not break any other devices.
* Tested by me on the specific hardware to ensure that the regression has gone away.
[Other Info]
Here is the upstream commit that eventually went into upstream ledmon 0.75:
Related branches
- Sebastien Bacher: Approve
- Ubuntu branches: Pending requested
-
Diff: 937 lines (+879/-2)6 files modified.pc/applied-patches (+1/-0)
.pc/fix-dell-devices.patch/src/ledmon.c (+833/-0)
debian/changelog (+6/-0)
debian/patches/fix-dell-devices.patch (+31/-0)
debian/patches/series (+1/-0)
src/ledmon.c (+7/-2)
description: | updated |
Changed in ledmon (Ubuntu): | |
importance: | Undecided → Low |
description: | updated |
Changed in ledmon (Ubuntu Raring): | |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in ledmon (Ubuntu): | |
status: | Confirmed → Fix Committed |
Changed in ledmon (Debian): | |
status: | Unknown → New |
Changed in ledmon (Debian): | |
status: | New → Fix Released |
Without the fix, here's how to reproduce:
1) install ledmon on a Dell PowerEdge system with PCIe SSD hardware. syslog. .you'll see messages such as the following repeated several times:
2) Startup ledmon (sudo ledmon)
3) Look in /var/log/
ledmon[2449]: Device (null) : No host_id!
ledmon[2449]: DETACHED DEV '(null)' in failed state
4) With the upstream patch in place and after restarting ledmon, the "no host_id" and "DETACHED_DEV" messages will go away and the PCIe SSD devices are detected correctly.