Completely replace lcms1 by lcms2 in Ubuntu

While running 'configure' I see these lines in its screen output:

    154 checking lcms.h usability... no
    155 checking lcms.h presence... no
    156 checking for lcms.h... no
    157 checking lcms/lcms.h usability... no
    158 checking lcms/lcms.h presence... no
    159 checking for lcms/lcms.h... no
.

According to http://sourceforge.net/projects/lcms/files/ at the moment the latest tarball is lcms2-2.0a.tar.gz and its header files (when installed) are:

"
sergei@amdam2:~/junk> ls -ltr /mnt/sdb8/sergei/AFSWD_debug/install/lcms-2.0/include/
total 117
-rw-r--r-- 1 qemu users 24622 2010-07-05 03:59 lcms2_plugin.h
-rw-r--r-- 1 qemu users 91214 2010-07-05 03:59 lcms2.h
sergei@amdam2:~/junk>
".

I.e. configure should check for version 2.0 or later and check existence of 'lcms2.h' rather than 'lcms.h' file.

Which distributions include lcms2?

(In reply to comment #1)
> Which distributions include lcms2?

As far as I could tell, no distribution carries lcms2 in a primary package repository, although Fedora seems to have it in updates-candidate and Gentoo carries an ebuild marked as testing.

Then this is not a bug at all, at the most just an enhancement request.

(In reply to comment #1)
> Which distributions include lcms2?

I have no idea and I don't care. I build and install everything I need in the directories I want, which are not system directories. From time to time I upgrade packages versions.

So, less than a month ago I discovered the new lcms version and upgraded.

(In reply to comment #3)
> Then this is not a bug at all, at the most just an enhancement request.

Maybe.

But then I see a chicken-egg problem. A distro can't start supporting 'lcms2' because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no distro includes it.

(In reply to comment #5)
> But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> distro includes it.

Not really. Distributions don't care what version of packages Wine supports.
Besides, there are many other projects that use lcms.

> But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> distro includes it.

lcms2 can be installed alongside lcms1 exactly for this reason.

(In reply to comment #7)
> > But then I see a chicken-egg problem. A distro can't start supporting 'lcms2'
> > because 'wine' doesn't support it and 'wine' won't support 'lcms2' because no
> > distro includes it.
>
> lcms2 can be installed alongside lcms1 exactly for this reason.

I know. And my environment can cope with it. Other packages which use 'lcms' silently accepted 'lcms2', so other than for 'wine' I have no need to keep both versions.

Probably in half year the issue will become relevant for 'wine'.

Created attachment 36970
initial support

Work in progress, but not sure when I'll pick it up, so leaving here for now in case someone else wants to finish it.

It seems this is no longer a mere enhancement request and needs some escalation in priority - liblcms1 is deprecated upstream, not receiving fixes, and is being slated for removal from distributions. See, for instance, https://bugs.launchpad.net/ubuntu/+source/lcms/+bug/885324

(In reply to comment #10)
> It seems this is no longer a mere enhancement request and needs some escalation
> in priority - liblcms1 is deprecated upstream, not receiving fixes, and is
> being slated for removal from distributions. See, for instance,
> https://bugs.launchpad.net/ubuntu/+source/lcms/+bug/885324

When will liblcms1 be removed from which distributions? How about 32-bit
versions of liblcms2 for current 64-bit distros? I doubt we want to support
both version 1 and version 2 of liblcms in Wine.

On Ubuntu, we'd like to migrate everything away from liblcms1 by 12.04, which means this would need to be done in the 1.4 timetable.

At a distro level, supporting 32-on-64 lcms2 is just as easy as lcms1. On Ubuntu 12.04, for instance, it's already multiarched and you can just apt-get install liblcms2-2:i386. So I'd expect it to be quite available.

(In reply to comment #12)
> On Ubuntu, we'd like to migrate everything away from liblcms1 by 12.04, which
> means this would need to be done in the 1.4 timetable.
>
> At a distro level, supporting 32-on-64 lcms2 is just as easy as lcms1. On
> Ubuntu 12.04, for instance, it's already multiarched and you can just apt-get
> install liblcms2-2:i386. So I'd expect it to be quite available.

Sure, but I asked about *current* distro versions. Without a reasonable
transition period Wine is forced to support both versions of liblcms.

Fair enough, but without supporting both versions for a bit we will _never_ be able to migrate and will end up using a deprecated unsupported library forever.

To answer your question as far as Ubuntu goes, 11.10, 11.04, 10.10, and 10.04 rely on ia32-libs, so in order to support them I'll have to update the ia32-libs in the PPA to include liblcms2 (this isn't hard).

Cmake configuration trace is different between libkdcraw and digiKam :

-- -------------------------------------------------------------------------
-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- Found JPEG: /usr/lib64/libjpeg.so
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp

...

---------------------------------------------------------------------------
-- Starting CMake configuration for: digikam
-- Found Jasper: /usr/lib64/libjasper.so
-- Check for Kdcraw library in local sub-folder...
...
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
-- found lcms2, version 2.3
-- Found LCMS2: lcms2
-- Identified libjpeg version: 80+
-- Found MySQL server executable at: /usr/sbin/mysqld
-- Found MySQL install_db executable at: /usr/bin/mysql_install_db
...

Why ?

Gilles Caulier

Note : I started cmake configuration script with "-DENABLE_LCMS2=on"

Gilles

(In reply to comment #29)
> Note : I started cmake configuration script with "-DENABLE_LCMS2=on"
>
> Gilles

Strange, works fine for me, either together (digikam-sc) or separately (libkdcraw, digikam). Here is separately:

-- Starting CMake configuration for: libkdcraw
...
-- Check for LCMS2 availability...
-- Found lcms version 2.03, c:/kderoot/lib/lcms-2.lib
-- Found LCMS2: c:/kderoot/lib/lcms-2.lib c:/kderoot/include

-- Found JPEG: c:/kderoot/lib/jpeg.lib
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP C flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP CXX flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: /openmp

----------------------------------------

-- Starting CMake configuration for: digikam
...
-- Check for LCMS2 availability...
-- Found lcms version 2.03, c:/kderoot/lib/lcms-2.lib
-- Found LCMS2: c:/kderoot/lib/lcms-2.lib c:/kderoot/include

-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP C flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Failed
-- Try OpenMP CXX flag = [/openmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: /openmp

Git commit b0cfc14a4dad0bd137fdf8d9493c378dbecca652 by Ananta Palani.
Committed on 03/03/2012 at 08:11.
Pushed by palani into branch 'master'.

Give libkdcraw cmake modules preference over pre-existing ones.

M +1 -1 CMakeLists.txt

http://commits.kde.org/libkdcraw/b0cfc14a4dad0bd137fdf8d9493c378dbecca652

Gilles,

Could you have another version of FindLCMS2.cmake on your system somewhere? Your 'found' message does not look consistent with the file included in libkdcraw/digikam:

Found lcms version ${LCMS2_MAJOR_VERSION}.${LCMS2_MINOR_VERSION}, ${LCMS2_LIBRARIES}

so maybe cmake is using the wrong one? The commit I just made may fix your problem regardless.

-Ananta

No other lcms2 cmake find script is on my computer.

I updated my local git and cleaned cmake cache. trace is better :

-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
-- found lcms2, version 2.3
-- Found lcms version 2.03, /usr/lib64/liblcms2.so
-- Found LCMS2: /usr/lib64/liblcms2.so /usr/include
-- Found JPEG: /usr/lib64/libjpeg.so
-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * LCMS2 - A small-footprint color management engine
   * libjpeg - JPEG image format support

...

-- Starting CMake configuration for: digikam
-- Found Jasper: /usr/lib64/libjasper.so
-- Check for Kdcraw library in local sub-folder...
-- Found Kdcraw library in local sub-folder: /mnt/data/Devel/GIT/2.x/extra/libkdcraw
-- Check Kexiv2 library in local sub-folder...
-- Found Kexiv2 library in local sub-folder: /mnt/data/Devel/GIT/2.x/extra/libkexiv2
-- Check Kipi library in local sub-folder...
-- Found Kipi library in local sub-folder: /mnt/data/Devel/GIT/2.x/extra/libkipi
-- Check Kface library in local sub-folder...
-- Found Kface library in local sub-folder: /mnt/data/Devel/GIT/2.x/extra/libkface
-- Check for KGeoMap library in local sub-folder...
-- Found KGeoMap library in local sub-folder: /mnt/data/Devel/GIT/2.x/extra/libkgeomap
-- checking for module 'libpgf'
-- package 'libpgf' not found
-- Could NOT find any working clapack installation
-- Check for LCMS2 availability...
-- Found lcms version 2.03, /usr/lib64/liblcms2.so
-- Found LCMS2: /usr/lib64/liblcms2.so /usr/include
-- Identified libjpeg version: 80+
-- Found MySQL server executable at: /usr/sbin/mysqld
...

i need to check OSX now...

Gilles Caulier

Work fine under MACOSX :

-- ----------------------------------------------------------------------------------
-- Starting CMake configuration for: libkdcraw
-- Check for LCMS2 availability...
-- checking for module 'lcms2'
-- found lcms2, version 2.2
-- Found lcms version 2.02, /opt/local/lib/liblcms2.dylib
-- Found LCMS2: /opt/local/lib/liblcms2.dylib /opt/local/include
-- Found JPEG: /opt/local/lib/libjpeg.dylib

-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
   * LCMS2 - A small-footprint color management engine
   * libjpeg - JPEG image format support

...

-- ----------------------------------------------------------------------------------
-- Starting CMake configuration for: digikam
-- Found Jasper: /opt/local/lib/libjasper.dylib
-- Check for Kdcraw library in local sub-folder...
-- Found Kdcraw library in local sub-folder: /Users/gilles/Devel/2.x/extra/libkdcraw
-- Check Kexiv2 library in local sub-folder...
-- Found Kexiv2 library in local sub-folder: /Users/gilles/Devel/2.x/extra/libkexiv2
-- Check Kipi library in local sub-folder...
-- Found Kipi library in local sub-folder: /Users/gilles/Devel/2.x/extra/libkipi
-- Check Kface library in local sub-folder...
-- Found Kface library in local sub-folder: /Users/gilles/Devel/2.x/extra/libkface
-- Check for KGeoMap library in local sub-folder...
-- Found KGeoMap library in local sub-folder: /Users/gilles/Devel/2.x/extra/libkgeomap
-- checking for module 'libpgf'
-- package 'libpgf' not found
-- Found clapack includes: /System/Library/Frameworks/vecLib.framework/Headers
-- Found clapack library: /usr/lib/libclapack.dylib
-- Check for LCMS2 availability...
-- Found lcms version 2.02, /opt/local/lib/liblcms2.dylib
-- Found LCMS2: /opt/local/lib/liblcms2.dylib /opt/local/include
-- Identified libjpeg version: 80+
...

Gilles Caulier

All compile fine under MACOSX through macport :

[ 56%] Building C object core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/lsame.c.o
[ 57%] Building C object core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/sfe.c.o
[ 57%] Building C object core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/util.c.o
[ 57%] Building C object core/digikam/CMakeFiles/digikamcore.dir/__/libs/3rdparty/clapack/xerbla.c.o
[ 57%] Building CXX object core/digikam/CMakeFiles/digikamcore.dir/__/libs/dklcms/digikam-lcms.cpp.o
[ 57%] Building CXX object core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgbuiltinfilter.cpp.o
[ 57%] Building CXX object core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgthreadedfilter.cpp.o
[ 57%] Building CXX object core/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/filters/dimgfiltermanager.cpp.o

I close this file now...

Gilles Caulier

I send a patch to add support for lcms2 with a fallback to lcms v1:
http://source.winehq.org/patches/data/96110

As info for distribution support for lcms2:
Ubuntu 11.10 has liblcms2-2 as a "main" package (section libs).

--
By by ... Detlef

(In reply to comment #15)
> I send a patch to add support for lcms2 with a fallback to lcms v1:
> http://source.winehq.org/patches/data/96110

BUG: The patch was still using the includes for lcms v1
     To fix compilation while using lcms2.h,
     add a #include <icc34.h> after the #include <lcms2.h>
     (icc34.h comes with the liblcms v1 dev package)

I prepare a better patch in the near future.

--
By by .. Detlef

Fixed by d40c91262b91f72c44151a1481a77acfe71ba044.

Closing bugs fixed in 1.7.0.

Roadmap says:

# future plans:
# 2.7 will compile against lcms2 by default but lcms1 will stay as a fallback
# 2.8 will support lcms2 only, probably ENABLE_LCMS2 will be removed too
# unless we decide to support another color managment library

Any plan to make lcms2 the default now, if both are found?

Nominating for 1.6.2 so I can put it into Ubuntu 14.04 LTS and Wine won't be the only package still using old lcms.

Removing 1.6.x milestone from bugs included in 1.6.2.