Translation domain confusion

Bug #1762253 reported by Gunnar Hjalmarsson
This bug affects 1 person
Affects Status Importance Assigned to Milestone
language-selector (Ubuntu)
Fix Released
Gunnar Hjalmarsson

Bug Description

In this upload:

the domain in setup.cfg was changed from "language-selector" to "gnome-language-selector". This appears to have resulted in a new unnecessary translation template:

Probably the domain in setup.cfg should be changed back to "language-selector" and the extra "gnome-language-selector" template deleted.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

@Jeremy: Since you made that upload, I'd appreciate your comment before doing anything.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

Oh I see.

If the domain does not need to match the .desktop (and I don't think it does), I'm fine with you changing the gettext domain. Sorry about that!

I think there is even a way to fix the original bug without renaming the .desktop by adding a StartupWMClass field to the .desktop. I wasn't really aware of that at the time; I just knew that Python apps commonly had a problem when the .desktop file name didn't match the binary filename.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Thanks, then I'll go ahead and change the gettext domain.

Let's keep the rest of the changes you did. I suppose that "if it ain't broke, don't fix it" applies. :)

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

Uploaded to queue, and the gnome-language-selector template deactivated, so we stop translators from wasting time.

Changed in language-selector (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package language-selector - 0.187

language-selector (0.187) bionic; urgency=medium

  * setup.cfg:
    Change the gettext domain back to "language-selector". Most of the
    translations are for that template, and the additional
    "gnome-language-selector" template can then be removed
    (LP: #1762253).

 -- Gunnar Hjalmarsson <email address hidden> Mon, 09 Apr 2018 00:38:00 +0200

Changed in language-selector (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.