landscape programs wake up far too much.

Thanks for reporting this. We had another open bug about this issue, but I'm closing that one in favor of this one because more details were given here.

On a related note, landscape-client is *not* installed by default. What is installed by default on servers is landscape-common, which has the landscape-sysinfo program. Do you confirm you got landscape-client installed by default on jaunty?

This machine was upgraded from 8.10; so somewhere between then and now it got installed. My logs must not go far enough back to find out when it was installed, but the earliest I could find was an upgrade on September 10th, 2008: landscape-client (0.1) to 1.0.18-0ubuntu1. I don't remember installing it myself, but as I said, my logs can neither confirm nor deny this (they go back to June 2, 2008).

Actually that 0.1 -> 1.0.18 upgrade does tell us something.

Did you do this upgrade using apt-get? Or do-release-upgade, while Ubuntu 8.10 was still not released?

lanscape-client-0.1 was a placeholder package, not really containing any files. The do-release-upgrade program was at some point during the 8.10 development cycle modified to *not* upgrade this placeholder package to the real one, but if you did the upgrade before this change, that would explain how you ended up with the landscape-client daemons installed and running.

So, no, Ubuntu desktop or server don't install landscape-client by default. The closest to this is ubuntu server, which installs landscape-common by default, but that does not run any daemon and just provides the landscape-sysinfo tool responsible for some machine statistics that is shown during login (via motd).

I mix the command line and gui tools quite frequently, so there's really no telling what happened unless apt logs which program does the install. I will remove the other landscape-[^common] packages, but the bug is still valid, I assume. (I have Ubuntu server running as well, and you're right, I found no daemons running).

Yes, the bug is still valid.

Decoupling server bugs from client ones.

This is ready to review in the attached branch. I've created a custom reactor and raised the timeout from 100ms to 1s.

The branch looks fine, +1. It'd be good to run a client with this
change on one of our test machines for a while, to make sure this
change doesn't introduce unwanted side-effects.

The custom reactor doesn't look to be unit-tested, but I guess the only way would be to mock everything up, and it wouldn't be that meaningful. So I second that we should check this on our test machines. I will trigger a build after this is merged.

Very nice change, +1!

Thanks, merged in r152.

With older landscape-client packages I was getting 10+ wakeups per second (as shown by powertop). With this new code, I get between 0 and 1 wakeups per second \o/

This bug was fixed in the package landscape-client - 1.4.0-0ubuntu0.10.04.0

---------------
landscape-client (1.4.0-0ubuntu0.10.04.0) lucid; urgency=low

  * New upstream release with several bug fixes:
    - Fix landscape daemons fail to start when too many groups are
      available (LP: #456124)
    - Fix landscape programs wake up far too much. (LP: #340843)
    - Fix Package manager fails with 'no such table: task' (LP #465846)
    - Fix test suite leaving temporary files around (LP #476418)
    - Fix the 1hr long wait for user data to be uploaded following a
      resynchronisation (LP #369000)

  * Add support for Ubuntu release upgrades:
    - Add helper function to fetch many files at once (LP: #450629)
    - Handle release-upgrade messages in the packagemanager
      plugin (LP: #455217)
    - Add a release-upgrader task handler (LP: #462543)
    - Support upgrade-tool environment variables (LP: #463321)

  * Add initial support for Smart package locking:
    - Detect and report changes about Smart package locks (#488108)

  * Packaging fixes:
    - Turn unnecessary Pre-Depends on python-gobject into a regular Depends
    - If it's empty, remove /etc/landscape upon purge
 -- Free Ekanayaka <email address hidden> Wed, 16 Dec 2009 10:50:05 +0100

Accepted landscape-client into intrepid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Accepted landscape-client into jaunty-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Accepted landscape-client into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

This bug was fixed in the package landscape-client - 1.4.0-0ubuntu0.8.10.0

---------------
landscape-client (1.4.0-0ubuntu0.8.10.0) intrepid-proposed; urgency=low

  * New upstream release (LP: #497351)

  * Bug fixes:
    - Fix landscape daemons fail to start when too many groups are
      available (LP: #456124)
    - Fix landscape programs wake up far too much. (LP: #340843)
    - Fix Package manager fails with 'no such table: task' (LP #465846)
    - Fix test suite leaving temporary files around (LP #476418)
    - Fix the 1hr long wait for user data to be uploaded following a
      resynchronisation (LP #369000)

  * Add support for Ubuntu release upgrades:
    - Add helper function to fetch many files at once (LP: #450629)
    - Handle release-upgrade messages in the packagemanager
      plugin (LP: #455217)
    - Add a release-upgrader task handler (LP: #462543)
    - Support upgrade-tool environment variables (LP: #463321)

  * Add initial support for Smart package locking:
    - Detect and report changes about Smart package locks (#488108)

  * Packaging fixes:
    - Turn unnecessary Pre-Depends on python-gobject into a regular Depends
    - If it's empty, remove /etc/landscape upon purge
 -- Free Ekanayaka <email address hidden> Wed, 16 Dec 2009 10:50:05 +0100

This bug was fixed in the package landscape-client - 1.4.0-0ubuntu0.9.04.0

---------------
landscape-client (1.4.0-0ubuntu0.9.04.0) jaunty-proposed; urgency=low

  * New upstream release (LP: #497351)

  * Bug fixes:
    - Fix landscape daemons fail to start when too many groups are
      available (LP: #456124)
    - Fix landscape programs wake up far too much. (LP: #340843)
    - Fix Package manager fails with 'no such table: task' (LP #465846)
    - Fix test suite leaving temporary files around (LP #476418)
    - Fix the 1hr long wait for user data to be uploaded following a
      resynchronisation (LP #369000)

  * Add support for Ubuntu release upgrades:
    - Add helper function to fetch many files at once (LP: #450629)
    - Handle release-upgrade messages in the packagemanager
      plugin (LP: #455217)
    - Add a release-upgrader task handler (LP: #462543)
    - Support upgrade-tool environment variables (LP: #463321)

  * Add initial support for Smart package locking:
    - Detect and report changes about Smart package locks (#488108)

  * Packaging fixes:
    - Turn unnecessary Pre-Depends on python-gobject into a regular Depends
    - If it's empty, remove /etc/landscape upon purge
 -- Free Ekanayaka <email address hidden> Wed, 16 Dec 2009 10:50:05 +0100

This bug was fixed in the package landscape-client - 1.4.0-0ubuntu0.9.10.0

---------------
landscape-client (1.4.0-0ubuntu0.9.10.0) karmic-proposed; urgency=low

  * New upstream release (LP: #497351)

  * Bug fixes:
    - Fix landscape daemons fail to start when too many groups are
      available (LP: #456124)
    - Fix landscape programs wake up far too much. (LP: #340843)
    - Fix Package manager fails with 'no such table: task' (LP #465846)
    - Fix test suite leaving temporary files around (LP #476418)
    - Fix the 1hr long wait for user data to be uploaded following a
      resynchronisation (LP #369000)

  * Add support for Ubuntu release upgrades:
    - Add helper function to fetch many files at once (LP: #450629)
    - Handle release-upgrade messages in the packagemanager
      plugin (LP: #455217)
    - Add a release-upgrader task handler (LP: #462543)
    - Support upgrade-tool environment variables (LP: #463321)

  * Add initial support for Smart package locking:
    - Detect and report changes about Smart package locks (#488108)

  * Packaging fixes:
    - Turn unnecessary Pre-Depends on python-gobject into a regular Depends
    - If it's empty, remove /etc/landscape upon purge
 -- Free Ekanayaka <email address hidden> Wed, 16 Dec 2009 10:50:05 +0100