Kopete jabber groupchat history only shown for currently present members

Bug #94022 reported by dystopianray
2
Affects Status Importance Assigned to Milestone
KDE Network
Fix Released
Medium
kdenetwork (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: kopete

When entering a jabber groupchat, the history provided by the server is filtered by kopete so it only shows history from members who are currently present in the groupchat.

This makes the history nearly useless as significant portions of it may be missing depending on who is currently in the room.

It should show the entire history that is given, regardless of who may or may not be in the room at the time of joining it. It had this behaviour in previous versions but it seems to have been changed in one of the 0.12.x releases.

The filtered history results in error messages being printed in ~/.xsession-errors

kopete (jabber): WARNING: [virtual void JabberGroupContact::handleIncomingMessage(const XMPP::Message&)] the contact is not in the list : lounge at rooms.jabber.org.au/Clax

This behaviour is a regression in kopete 0.12.x that was not present in previous versions.

The reason this behaviour occurs is becuase of an erroneous 'return' statement present directly before the code that handles groupchat members who are not currently present in the room.

I have reported this many months ago as kde bug #135211 (http://bugs.kde.org/show_bug.cgi?id=135211) and provided a patch to fix this problem, however there has been no response from kopete developers.

I have tested the patch and I use jabber groupchats almost every day, I have not encountered any adverse affects from using the patch and the history is correctly shown.

Revision history for this message
dystopianray (dystopianray) wrote :
Changed in kdenetwork:
status: Unknown → Unconfirmed
Changed in kdenetwork:
status: Unconfirmed → Fix Released
Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

fixed in gutsy, thanks.

Changed in kdenetwork:
status: Unconfirmed → Fix Released
Revision history for this message
dystopianray (dystopianray) wrote :

This bug is still present in gutsy tribe 3 with kdenetwork-3.5.7-2ubuntu1 and judging from the changelog a fix was never committed for this issue.

Changed in kdenetwork:
status: Fix Released → New
Changed in kdenetwork:
assignee: nobody → hobbsee
Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

Hmmm. I could have sworn i picked this patch up.

Committed into bzr.

Changed in kdenetwork:
status: New → Fix Committed
Revision history for this message
dystopianray (dystopianray) wrote :

Will this patch eventually make it into a gutsy package? It's been several weeks and I'm rather keen for this fix to be in gutsy. I'm getting a little worried that it might be overlooked.

Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

yes. i'm hoping to grab a few more patches before making an upload.

it'd help if i actually had time to do that, of course.

Revision history for this message
Sarah Kowalik (hobbsee-deactivatedaccount) wrote :

kdenetwork (4:3.5.7-2ubuntu2) gutsy; urgency=low

  * Added 01_branch_kopete-groupchat-history.patch (LP: #94022)
  * Moved rdesktop from suggests to recommends of krdc. (LP: #51766)
  * Added kubuntu_09_fix_translation_plugin.diff. Thanks to Francesco Rossi
  <email address hidden> for this patch

 -- Sarah Hobbs <email address hidden> Fri, 14 Sep 2007 01:35:01 +1000

Changed in kdenetwork:
status: Fix Committed → Fix Released
Changed in kdenetwork:
importance: Unknown → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.