drop oneiric /run compatibility link

Bug #1485752 reported by Andy Whitcroft
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cloud-initramfs-tools (Ubuntu)
Fix Released
Fix Released
Scott Moser
initramfs-tools (Ubuntu)
Fix Released
Andy Whitcroft

Bug Description

=== Begin SRU Template ===
overlayfs writes some log information to the tmpfs that was intended
to be then viewable after the pivot_root to the real root.
The path used was /dev/.initramfs. Due to changes in initramfs-tools
under this bug, that path was no longer supported. And the logging
was busted.

There was no functional problem with this except in the crypt use
case as described in bug 1634310.

[Test Case]
1.) Start an instance of a cloud image.

2.) Enable proposed and install overlayroot to show fix.
    $ rel=$(lsb_release -sc)
    $ echo "deb http://archive.ubuntu.com/ubuntu $rel-proposed main" |
    $ sudo tee /etc/apt/sources.list.d/proposed.list
    $ sudo apt update -qy && sudo apt install -qy overlayroot </dev/null
    $ dpkg-query --show overlayroot
    overlayroot 0.27ubuntu1.3

3.) Enable overlayroot and reboot
    $ echo "overlayroot=tmpfs:debug=1" | sudo tee /etc/overlayroot.local.conf
    $ sudo reboot

4.) log back in and look around.
   a.) check that 'overlayroot' is in /proc/mounts
       $ awk '$1 == "overlayroot" { print $0 }' /proc/mounts
       overlayroot / overlay rw,relatime,lowerdir=/media/root-ro,upperdir=/media/root-rw/overlay,workdir=/media/root-rw/overlay-workdir/_ 0 0

   b.) check /run/initramfs/overlayroot.log exists.

[Regression Potential]
A regression here is somewhat unlikely. Most likely would be inadvertant failure.
As you can see in the fix, the code looks for a dir /run/initramfs /dev/.initramfs
and picks the first one that exists. If neither existed for some reason,
then debug would remain busted.

[Other Info]
The full overlayroot/init-bottom/overlayroot can be seen at [1]. The
specific change that fixed the issue is in revision 112 at [2].

[1] http://bazaar.launchpad.net/~cloud-initramfs-tools/cloud-initramfs-tools/trunk/view/head:/overlayroot/scripts/init-bottom/overlayroot
[2] http://bazaar.launchpad.net/~cloud-initramfs-tools/cloud-initramfs-tools/trunk/revision/112

=== End SRU Template ===

Drop: Maintain compatibility with pre- /run configurations -- this was for compatibility with oneiric which is now long gone.

Andy Whitcroft (apw)
Changed in initramfs-tools (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Andy Whitcroft (apw)
milestone: none → ubuntu-15.08
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package initramfs-tools - 0.120ubuntu3

initramfs-tools (0.120ubuntu3) wily; urgency=medium

  * hook-functions: fix PowerPC NX Crypto Coprocessor support (LP:
  * Drop: Maintain compatibility with pre- /run configurations (LP:
  * Drop: Ignore errors from iscan and iscan-data hooks (LP: #1485562)

 -- Andy Whitcroft <email address hidden> Tue, 18 Aug 2015 12:15:28 +0100

Changed in initramfs-tools (Ubuntu):
status: In Progress → Fix Released
Scott Moser (smoser)
Changed in cloud-initramfs-tools (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Changed in cloud-initramfs-tools (Ubuntu Xenial):
importance: Undecided → Medium
status: New → In Progress
assignee: nobody → Scott Moser (smoser)
no longer affects: initramfs-tools (Ubuntu Xenial)
Scott Moser (smoser)
description: updated
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Andy, or anyone else affected,

Accepted cloud-initramfs-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cloud-initramfs-tools/0.27ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in cloud-initramfs-tools (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Scott Moser (smoser) wrote :

I've verified this using the steps described in the SRU template
$ dpkg-query --show overlayroot
overlayroot 0.27ubuntu1.3

description: updated
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cloud-initramfs-tools - 0.27ubuntu1.3

cloud-initramfs-tools (0.27ubuntu1.3) xenial; urgency=medium

  * sync with upstream at 0.32ubuntu1 (revno 129)
    * overlayroot: fix overlayroot=crypt with newer initramfs-tools
      (LP: #1634310)
    * overlayroot: support random seed from systemd systemd-random-seed.service
    * cloud-initramfs-dyn-netconf: Further adjustments to support
      IPV6 and the new DEVICE6 and net6-DEVICE.conf files. (LP: #1621615)
    * overlayroot: support 'overlay' filesystem explicitly rather than
      relying on ubuntu specific kernel module 'overlayfs'. (LP: #1493188)
    * overlayroot: write debug to /run/initramfs not /dev/.initramfs but
      support writing to /dev/.initramfs if that is all there is. (LP: #1485752)
    * overlayroot: fix overlayroot if recurse=0 was not provided.
      This fuctionality was lost since workdir support was added. (LP: #1619459)
    * whitespace cleanup.

 -- Scott Moser <email address hidden> Mon, 28 Nov 2016 20:12:51 -0500

Changed in cloud-initramfs-tools (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Update Released

The verification of the Stable Release Update for cloud-initramfs-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.