Ubuntu
indicator-application-gtk2 package

[FTBFS] Don't treat -Wdeprecated-declarations as errors

Bug #1810742 reported by Khurshid Alam on 2019-01-07

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	indicator-application-gtk2 (Ubuntu)	Confirmed	Undecided	Unassigned

Bug Description

Don't treat -Wdeprecated-declarations as errors.

But we should really use G_DECLARE_TYPE_PRIVATE for this.

The launchpad bzr repo is not in sync with ubuntu source.

Hence attaching a patch here.

See original description

Tags:

Khurshid Alam (khurshid-alam) on 2019-01-07

Changed in indicator-application-gtk2 (Ubuntu):
status:	New → Confirmed

Revision history for this message

Khurshid Alam (khurshid-alam) wrote on 2019-01-11:

deprecated_declarations.patch Edit (1.7 KiB, text/plain)

The patch is attached.

Khurshid Alam (khurshid-alam) on 2019-01-11

description:

updated

Revision history for this message

Ubuntu Foundations Team Bug Bot (crichton) wrote on 2019-01-11:

The attachment "deprecated_declarations.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags:

added: patch

Revision history for this message

Sebastien Bacher (seb128) wrote on 2019-01-17:

The patch doesn't do what the title/description claims, you remove -Werror (which is fine) which has impact on warning other than the 'deprecated-declarations' ones

Revision history for this message

Sebastien Bacher (seb128) wrote on 2019-01-17:

Also what vcs are you talking about? Did we have one for the gtk2 compat version? If so could you share the url, maybe we can get that one updated?

Revision history for this message

Sebastien Bacher (seb128) wrote on 2019-01-17:

oh, also do we still need that package? it was added for xubuntu/lubuntu which were still using gtk2 at the time but xubuntu switched to gtk3 since no? (and is lubuntu still a thing?)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2019-01-17:

(see bug #1811489)