Ginn should subscribe only to gestures requested
Bug #740213 reported by
Chase Douglas
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ginn |
Triaged
|
Low
|
Unassigned | ||
ginn (Ubuntu) |
Triaged
|
Low
|
Unassigned |
Bug Description
Two finger trackpad scrolling has historically generated motion in the opposite direction of what would be correct for a touchscreen. However, when ginn is running it assumes all devices are direct touch devices and causes scrolling to be inverted for trackpads.
The first step is to have ginn subscribe only to the gestures requested in the wishes.
Related branches
lp://staging/~bijanbina/ginn/GIR
Rejected
for merging
into
lp://staging/ginn
- Chase Douglas (community): Disapprove
- Stephen M. Webb (community): Needs Fixing
-
Diff: 2447 lines (+1339/-977)18 files modified.directory (+6/-0)
configure.ac (+1/-0)
src/Makefile.am (+3/-2)
src/README (+5/-0)
src/bamf.c (+0/-48)
src/bamf.cpp (+48/-0)
src/config.c (+0/-200)
src/config.cpp (+202/-0)
src/config.h (+70/-27)
src/ginn.c (+0/-592)
src/ginn.cpp (+555/-0)
src/ginn.h (+60/-0)
src/gir.cpp (+47/-0)
src/gir.h (+70/-0)
src/header.h (+38/-0)
src/main.cpp (+137/-0)
src/xt.c (+0/-108)
src/xt.cpp (+97/-0)
Changed in ginn: | |
importance: | Undecided → High |
Changed in ginn: | |
status: | Triaged → In Progress |
assignee: | nobody → Josh Fee (joshfee) |
summary: |
- Two finger trackpad scrolling inverted when using ginn + Ginn should subscribe only to gestures requested |
description: | updated |
Changed in ginn: | |
importance: | High → Medium |
Changed in ginn: | |
status: | In Progress → Fix Committed |
milestone: | none → 0.2.6 |
status: | Fix Committed → In Progress |
Changed in ginn (Ubuntu): | |
status: | New → Triaged |
Changed in ginn: | |
assignee: | Bijan Binaee (bijanbina) → nobody |
Changed in ginn (Ubuntu): | |
importance: | Undecided → Low |
Changed in ginn: | |
importance: | Medium → Low |
Changed in ginn: | |
milestone: | 0.2.6 → none |
To post a comment you must log in.
The correct solution is to subscribe to two finger scroll events only on direct touch devices. Currently, the code subscribes to all reasonable gestures on all devices. It needs to subscribe only to the gestures that are listed in the wishes file and only on the applicable device types for those wishes.