On Sat, 16 Jul 2011 13:55:33 -0000
Jacob Nevins <email address hidden> wrote:

> @Karl:
> > Are you after a fix for the released ubuntus?
> 
> If it's possible to get it in as an SRU, that would be ideal. It is a
> "severe regression from the previous release of Ubuntu" (severe for
> Freeciv, not for the whole system). It affects "an application rather
> than critical infrastructure packages", although it's less clear that
> the patch will be "obviously safe".

I expect we could make it safe enough, but i'll have to find out from
someone in ubuntu who can be authoritive :)

> As upstream, I'd love to not have to keep pointing people at this bug
> and the workaround (and get bad reviews in Software Centre because of
> it).

I can understand that.

> It's most critical for Natty, where Unity is the default on the
> desktop. On Maverick I think it only affects the netbook edition by
> default (but we know people play Freeciv on netbooks). Fortunately,
> the workaround should be version-agnostic.

ok. so we might need up to 3 versions patched specially for ubuntu in
that case.

> However, if an SRU isn't possible, at a minimum, I think we should
> plan to get the workaround in Oneiric, in case we haven't worked out
> a proper fix by then. (Assuming it's not already too late to get a
> new version in Oneiric!)

I expect we could get in a patch/wrapper still.

> > We have 2.2.5 packaged in git, but I was holding off on 2.3 for a
> > new
> upload (don't know if this is a sane idea or not tbh).
> 
> Not sure. We're hoping 2.3.0 will go gold RSN (RC1 this weekend), but
> we've thought that before ;) It mainly depends when the window closes
> for Oneiric, I think.

Debian import freeze has passed, so i suspect it would be harder to go
up a full new version at this stage.

https://wiki.ubuntu.com/OneiricReleaseSchedule

> If 2.3.0 slips, I recommend you go to 2.2.7 (not yet released, also
> due RSN, but with higher confidence). I wouldn't bother with 2.2.6;
> while it has valuable fixes, it also has an embarrassing regression.
> (As does 2.2.5, actually.)

guess we dodged a bullet by not releasing 2.2.5 then (I didn't know
2.2.6 was out yet, i rely on the /topic and people of #freeciv on
freenode for that sort of news).

> > we would have to replace the freeciv binary with a wrapper script,
> > or force people to use a .desktop file
> 
> I think the .desktop fix would catch >90% of users, but a wrapper
> script would be better, obviously.

We could include a wrapper going forward, but how long would it be used
for? I hope these UI regressions are nailed down pretty quick. Either
way, i'll write one up later (it should be trivial) and attach it here.

> > (i assume these can export environment pre launch).
> 
> Should be able to change "Exec=freeciv-gtk2" to "Exec=env
> UBUNTU_MENUPROXY= freeciv-gtk", or something like that, I'd expect.
> (Warning: completely unchecked.)

Validates ok, don't have ubuntu installed anyware to test yet.
$ desktop-file-validate z.freeciv.desktop
$ grep Exec $_ Exec=env
UBUNTU_MENUPROXY=freeciv-gtk2

> > Additionally, does anyone know if SDL and XAW3D clients are
> > affected,
> or if its just GTK?
> 
> I wouldn't expect SDL to be affected, since it draws its own widgets
> with custom code, and appmenu won't be able to hook into it. Don't
> know about Xaw, and can't conveniently check right now (but I
> wouldn't hold up a Gtk patch for lack of an Xaw patch, personally).

Thats what I was thinking too, but if i remember i'll test it in a VM
later (assuming the vm installs ok ;))
kk

-- 
Karl Goetz, (Kamping_Kaiser / VK5FOSS)
Debian contributor / gNewSense Maintainer
http://www.kgoetz.id.au
No, I won't join your social networking group