Crash in extract_mp4
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
foremost (Ubuntu) |
New
|
Undecided
|
Unassigned |
Bug Description
I recently used your tool for the first time after accidentally deleting some mp4 files. When I ran the tool, it would crash after a little while. I build the source and tried again. It was crashing with a buffer over run in extract_mp4. Looking at the gdb output I saw it had run the loop too long. Not being familiar with code, I'm not sure how that happened, but I was able to fix the crash and get a complete run by adding the following to the while(1) loop.
if(foundat-buf >= buflen)
{
return NULL;
}
I'm not sure if that is the correct way to handle it, probably not since the files I was looking for did not show up in the final output.
First of all, you might try using PhotoRec to recover the files. The less you use the computer after deleting the files, the better.
Thank you for this bug report!