Ubuntu
evolution-data-server package

UOA integration always creates new evolution-data-server accounts on login

Bug #1373908 reported by Michael Blennerhassett
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
evolution-data-server (Ubuntu)
Fix Released
High
Unassigned
Trusty
Fix Released
Undecided
Iain Lane

Bug Description

* Impact:
e-d-s prompts for password at login when it shouldn't

* Test case:
- add a google account in the unity online accounts panel
- log in
-> you shouldn't be prompted for a calendar password

* Regression potential:
make sure online calendars keep working as they should

------------------

(This is probably the source of all those 'have to enter password again after login' bugs for UOA that are floating around)

Bug symtoms:
1. Have to enter password at every login again for EDS
2. loads of accounts pile up in .config/evolution/sources (a new one on every login)

What's going on:
ubuntu_online_accounts_bus_acquired_cb() in eds/modules/ubuntu-online-accounts/module-ubuntu-online-accounts.c gets connected to the "bus-aquired" signal.

Note also that evolution_source_registry_load_sources() from eds/services/evolution-source-registry/evolution-source-registry.c is connected to the same signal. Given when the plugins are loaded, UOA connects to the signal first, so UOA tries to match up EDS accounts to UOA accounts before the EDS accounts (sources) have been loaded.

The patch is simply to use g_signal_connect_after in module-ubuntu-online-accounts.c, which fixes the problem for me.

Note though that this change means a whole bunch of code in module-ubuntu-online-accounts.c that has never run will now be run...

ProblemType: Bug
DistroRelease: Ubuntu 14.10
Package: evolution-data-server 3.12.6-0ubuntu2 [modified: usr/lib/evolution/evolution-source-registry]
ProcVersionSignature: Ubuntu 3.16.0-17.23-generic 3.16.3
Uname: Linux 3.16.0-17-generic x86_64
ApportVersion: 2.14.7-0ubuntu2
Architecture: amd64
CurrentDesktop: Unity
Date: Thu Sep 25 22:08:54 2014
InstallationDate: Installed on 2014-09-03 (22 days ago)
InstallationMedia: Ubuntu 14.10 "Utopic Unicorn" - Alpha amd64 (20140902)
SourcePackage: evolution-data-server
UpgradeStatus: No upgrade log present (probably fresh install)

See original description
Revision history for this message
Michael Blennerhassett (mjblenner) wrote :
Revision history for this message
Michael Blennerhassett (mjblenner) wrote :

Use g_signal_connect_after() on "bus-acquired" so that EDS can load all the accounts first, before UOA tries to match them to UOA accounts.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "startup-fix.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
Matthew Barnes (mbarnes.redhat) wrote :

Mardy alerted me to this and I applied the patch upstream already for E-D-S 3.12 and 3.13.

Thanks Michael!

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in evolution-data-server (Ubuntu):
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the debugging work there!

Changed in evolution-data-server (Ubuntu):
importance: Undecided → High
status: Confirmed → In Progress
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks Michael and Matthew, I've uploaded a backport of that patch to utopic!

Revision history for this message
Sebastien Bacher (seb128) wrote :

that change is a good candidate for a lts SRU as well, once it has been tested/confirmed to work in utopic

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package evolution-data-server - 3.12.6-0ubuntu3

---------------
evolution-data-server (3.12.6-0ubuntu3) utopic; urgency=medium

  * debian/patches/git_password_prompt_on_start.patch:
    - "Fix UOA accounts accumulating on startup.",
      thanks Michael Blennerhassett for debugging that issue and providing
      the fix for it (lp: #1373908)
 -- Sebastien Bacher <email address hidden> Thu, 02 Oct 2014 15:25:40 +0200

Changed in evolution-data-server (Ubuntu):
status: In Progress → Fix Released
Sebastien Bacher (seb128)
summary: - UOA integration always creates new evolution-datat-server accounts on
+ UOA integration always creates new evolution-data-server accounts on
login
description: updated
Iain Lane (laney)
Changed in evolution-data-server (Ubuntu Trusty):
status: New → In Progress
assignee: nobody → Iain Lane (laney)
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted evolution-data-server into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/evolution-data-server/3.10.4-0ubuntu1.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in evolution-data-server (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Iain Lane (laney) wrote :

It seems to work for me

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package evolution-data-server - 3.10.4-0ubuntu1.5

---------------
evolution-data-server (3.10.4-0ubuntu1.5) trusty; urgency=medium

  * debian/patches/0001-Fix-UOA-accounts-accumulating-on-startup.patch:
    - "Fix UOA accounts accumulating on startup.",
      thanks Michael Blennerhassett for debugging that issue and providing
      the fix for it (LP: #1373908)
 -- Iain Lane <email address hidden> Mon, 20 Oct 2014 20:43:25 +0100

Changed in evolution-data-server (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for evolution-data-server has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Alexander Hall (compuguy1088) wrote :

I believe this or a derivative of this issue still effects 14.10 when using google/google app accounts.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.