[MIR] Main inclusion request for evas
Bug #488923 reported by
Jamie Bennett
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
evas (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
This package is needed by the mobile team to make the 2D non-accelerated netbook launcher environment available to ARM architectures.
affects: | ubuntu → evas (Ubuntu) |
Changed in evas (Ubuntu): | |
assignee: | nobody → Loïc Minier (lool) |
Changed in evas (Ubuntu): | |
assignee: | Loïc Minier (lool) → nobody |
To post a comment you must log in.
Issues I found while reviewing evas with evas: maintainer- mode, --disable- silent- rules, --disable-rpath box.c:86: warning: 'opt' may be used uninitialized in this function text.c: 1269: warning: pointer targets in passing argument 1 of 'evas_common_ font_utf8_ get_len' differ in signedness rgb_8.c: 28: warning: right shift count is negative load.c: 106: warning: passing argument 1 of 'evas_module_ foreach_ image_loader' from incompatible pointer type main.c: 156: warning: implicit declaration of function 'evas_cserve_ image_free'
* configure: WARNING: unrecognized options: --disable-
--disable-rpath is set in debian/rules and should be dropped, you might want to send that fix to Debian; not worth diverging here though
* there are various warnings during build which would be worth forwarding upstream, samples:
evas_object_
evas_object_
evas_convert_
evas_image_
* this class of warnings is actually serious and should definitely be reported upstream; it's likely to cause segfaults on 64-bits architectures if this code path is under use:
evas_image_
I didn't review ALL warnings, since there are way too many of these: I think the source deserves some cleanup
* I'm a bit worried that fb_setvt() calls chown(vtname, getuid(), getgid()); on a /dev/tty node; I don't think that's the expected use case for Debian/Ubuntu where we usually manage device permissions via udev only
* the build should disable valgrind support explicitly as it might be picked up automatically if installed in the build env and that might end up in the evas.pc file
Overall, the only thing I'm concerned with are the serious warnings above, but these code pathes might or might not be used at runtime.
Since the package is copied verbatim from Debian and the Debian maintainer is also an Ubuntu developer subscribed to the evas bugs in Ubuntu, I'm fine with promoting evas to main. However I think the serious warnings and the chmod() question should be considered important bugs to look at quickly.
Thanks,