erroneous reassignment to variable (keypunch?)

Bug #600896 reported by Stuart R Balfour
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
dvd+rw-tools (Ubuntu)
New
Undecided
Unassigned

Bug Description

Binary package hint: dvd+rw-tools

dvd+rw-tools-7.1-6, kubuntu 10.04.

The following code in poor_man_rewritable() in growisofs_mmc.cpp
contains a coding error:

    else if (profile==0x1A || // DVD+RW
             profile==0x2A || // DVD+RW Double Layer
             (profile&=0xF0)==0x40) // BD-R[E]
    { fprintf (stderr,"%s: flushing cache\n",ioctl_device);
        if (flush_cache(cmd)) exit (errno);
    }

The expression (profile&=0x40) should almost certainly not be
an embedded assignment. Even if it is not causing an existing bug,
this is the kind of thing someone in the future will trip over.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.