simple networking mode (net-meta) does not account for device names
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
curtin |
Fix Released
|
Medium
|
Scott Moser | ||
curtin (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
* Users which do not use a customized network configuration rely
on curtin's fallback/automatic configuration. On Xenial and newer
systems the network configuration that is generated doesn't always
work due to the persistent nic names which do not match between
initial install environment and booting the system after
installation.
This affects all curtin releases which use auto configure
networking and an Ubuntu release which uses persistent network
device nameing.
* This SRU resolves the bug by ensuring auto configured networking
includes nic naming rules to ensure the network device names match
what is generated in the config.
[Test Case]
* On a Xenial 16.04 system
- % apt-get install curtin
- % OUTPUT_
FAIL: Systems with the error will print an interfaces file to stdout
PASS: Systems with the fix with emit host networking config to the file
[Regression Potential]
* Users that use auto configuration may find that the persistent nic
names in the target system are no longer ethN, but named based on
location.
[Original Description]
I ran
nosetests3 -v tests/vmtests/
and was seeing failures.
That does an install without network config, so it relies on 'net-meta' of 'auto'.
The install worked, but boot failed as networking was not configured.
The issue is that the net-meta was writing /etc/network/
I'll attach logs just for completeness.
Related branches
- Ryan Harper (community): Approve
- Server Team CI bot: Approve (continuous-integration)
-
Diff: 124 lines (+44/-28)2 files modifiedcurtin/commands/net_meta.py (+39/-28)
curtin/net/__init__.py (+5/-0)
- Scott Moser: Approve
-
Diff: 2457 lines (+1095/-323)35 files modifiedcurtin/block/__init__.py (+9/-3)
curtin/commands/block_meta.py (+7/-2)
curtin/commands/curthooks.py (+19/-3)
curtin/commands/net_meta.py (+39/-28)
curtin/net/__init__.py (+25/-5)
curtin/reporter/handlers.py (+4/-13)
curtin/util.py (+56/-0)
debian/changelog (+19/-0)
examples/tests/basic_network.yaml (+6/-0)
examples/tests/basic_scsi.yaml (+72/-0)
examples/tests/bonding_network.yaml (+2/-0)
examples/tests/multipath.yaml (+38/-0)
examples/tests/simple.yaml (+3/-0)
helpers/common (+14/-6)
tests/unittests/test_net.py (+49/-1)
tests/unittests/test_reporter.py (+23/-2)
tests/vmtests/__init__.py (+121/-58)
tests/vmtests/helpers.py (+169/-0)
tests/vmtests/image_sync.py (+16/-2)
tests/vmtests/releases.py (+5/-0)
tests/vmtests/test_basic.py (+121/-4)
tests/vmtests/test_bcache_basic.py (+4/-0)
tests/vmtests/test_bonding.py (+6/-44)
tests/vmtests/test_lvm.py (+4/-4)
tests/vmtests/test_mdadm_bcache.py (+24/-24)
tests/vmtests/test_multipath.py (+63/-0)
tests/vmtests/test_network.py (+19/-57)
tests/vmtests/test_nvme.py (+4/-4)
tests/vmtests/test_raid5_bcache.py (+8/-4)
tests/vmtests/test_simple.py (+40/-0)
tests/vmtests/test_uefi_basic.py (+8/-8)
tools/jenkins-runner (+10/-0)
tools/launch (+74/-44)
tools/vmtest-sync-images (+5/-1)
tools/xkvm (+9/-6)
Changed in curtin: | |
status: | In Progress → Fix Committed |
description: | updated |
Hello Scott, or anyone else affected,
Accepted curtin into xenial-proposed. The package will build now and be available at https:/ /launchpad. net/ubuntu/ +source/ curtin/ 0.1.0~bzr399- 0ubuntu1~ 16.04.1 in a few hours, and then in the -proposed repository.
Please help us by testing this new package. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification- failed. In either case, details of your testing will help us make a better decision.
Further information regarding the verification process can be found at https:/ /wiki.ubuntu. com/QATeam/ PerformingSRUVe rification . Thank you in advance!