Fix race condition in ConfigureWindow
Bug #893467 reported by
Sam Spilsbury
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| compiz (Ubuntu) |
In Progress
|
Medium
|
Sam Spilsbury | ||
Bug Description
Fix a race condition when configuring windows which are being moved by the
user by not allowing synchronous window movement at all, and instead mandating
that all movement is done by configureXWindow and immediate position updates
are done through the composite plugin
Related branches
lp://staging/~smspillaz/compiz-core/fix-893467
- Daniel van Vugt: Needs Fixing
- Alan Griffiths: Needs Fixing
- Thomi Richards (community): Needs Fixing
-
Diff: 3374 lines (+1052/-787)26 files modifiedinclude/core/core.h (+0/-1)
include/core/screen.h (+2/-2)
include/core/window.h (+72/-45)
plugins/compiztoolbox/src/compiztoolbox.cpp (+7/-7)
plugins/composite/include/composite/composite.h (+22/-7)
plugins/composite/src/privates.h (+5/-0)
plugins/composite/src/screen.cpp (+2/-2)
plugins/composite/src/window.cpp (+51/-12)
plugins/decor/src/decor.cpp (+19/-22)
plugins/move/src/move.cpp (+33/-25)
plugins/move/src/move.h (+4/-0)
plugins/opengl/src/paint.cpp (+20/-9)
plugins/opengl/src/privates.h (+2/-1)
plugins/opengl/src/window.cpp (+35/-12)
plugins/place/src/place.cpp (+8/-46)
plugins/resize/src/resize.cpp (+27/-36)
plugins/rotate/src/rotate.cpp (+5/-6)
plugins/switcher/src/switcher.cpp (+22/-12)
plugins/water/src/water.cpp (+1/-1)
plugins/wobbly/src/wobbly.cpp (+125/-29)
plugins/wobbly/src/wobbly.h (+45/-5)
src/event.cpp (+30/-47)
src/privatewindow.h (+33/-11)
src/screen.cpp (+5/-5)
src/window.cpp (+428/-437)
src/windowgeometry.cpp (+49/-7)
| Changed in cairo-dock-plug-ins: | |
| assignee: | nobody → Sam Spilsbury (smspillaz) |
| status: | New → In Progress |
Revision history for this message
| Matthieu Baerts (matttbe) wrote | #1 |
| affects: | cairo-dock-plug-ins → compiz |
| affects: | compiz → compiz (Ubuntu) |
| Changed in compiz (Ubuntu): | |
| importance: | Undecided → Medium |
To post a comment you must log in.
@Sam: It seems you still have a problem with your script ;-)
(I can understand that you love so much our Cairo-Dock project, that you want to join us and of course you want to use it instead of Unity but please be careful: this report is public :P )
But don't hesitate to report any idea/bug about Cairo-Dock and its plug-ins ;)
PS: sorry, I'm tired :)