[callgrind] compiz spends ~7% of its time inserting into and destructing the events list in PrivateScreen::processEvents()
Bug #1006335 reported by
Daniel van Vugt
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Compiz |
Fix Released
|
Medium
|
Compiz Maintainers | ||
Compiz Core |
Fix Released
|
Medium
|
Łukasz Zemczak | ||
compiz (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Precise |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Test Case]
Performance improvement, no obvious test case possible. Check for visible regressions.
[Regression Potential]
Broken compiz debugging, broken XEvent handling
Original description:
Compiz spends ~7% of its time inserting XEvents into the events list, and destroying the events list, in PrivateScreen:
Related branches
lp://staging/~compiz-team/compiz/compiz.fix_1006335
- Daniel van Vugt: Approve
- Compiz Maintainers: Pending requested
-
Diff: 303 lines (+98/-47)4 files modifiedsrc/privatescreen.h (+22/-2)
src/privatestackdebugger.h (+9/-4)
src/screen.cpp (+37/-30)
src/stackdebugger.cpp (+30/-11)
lp://staging/~sil2100/compiz-core/cherry_3243
- Daniel van Vugt: Approve
-
Diff: 319 lines (+97/-54)5 files modifiedsrc/main.cpp (+0/-8)
src/privatescreen.h (+22/-2)
src/privatestackdebugger.h (+9/-4)
src/screen.cpp (+36/-29)
src/stackdebugger.cpp (+30/-11)
summary: |
- [callgrind] compiz spends ~7% of its time constructing/destructing the - events list in PrivateScreen::processEvents() + [callgrind] compiz spends ~7% of its time inserting into and destructing + the events list in PrivateScreen::processEvents() |
description: | updated |
Changed in compiz: | |
assignee: | nobody → Compiz Maintainers (compiz-team) |
status: | Triaged → In Progress |
Changed in compiz-core: | |
status: | Triaged → In Progress |
assignee: | nobody → Łukasz Zemczak (sil2100) |
milestone: | none → 0.9.7.10 |
description: | updated |
Changed in compiz-core: | |
status: | In Progress → Confirmed |
status: | Confirmed → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
Changed in compiz: | |
status: | Fix Committed → Fix Released |
Changed in compiz-core: | |
status: | Fix Committed → Fix Released |
Changed in compiz-core: | |
status: | Fix Released → Fix Committed |
Changed in compiz-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is of most concern when graphics drivers have sync-to-vblank disabled by default (like nvidia, nouveau). In this case, 3D apps will emit damage events to the server unthrottled, and compiz has to deal with lots more events than it really should.