Ubuntu
bzr package

LP: #xxxx in the commit message should trigger --fixes lp:xxxx

Bug #684764 reported by Didier Roche-Tolomelli
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Confirmed
Wishlist
Unassigned
Breezy
Triaged
Wishlist
Unassigned
bzr (Ubuntu)
Triaged
Wishlist
Unassigned

Bug Description

Binary package hint: bzr

So, when I bzr log, I don't see the bug launchpad link as before. (it was implicitely linked when I had LP: #XXXX in the commit message). Even trying it expictely doesn't work:
$ bzr commit -m "foo" --fixes lp:XXXX

I tried to ditch ~/.bazaar without any success either.

$ bzr --version
Bazaar (bzr) 2.3b2
  Python interpreter: /usr/bin/python 2.6.6
  Python standard library: /usr/lib/python2.6
  Platform: Linux-2.6.37-6-generic-i686-with-Ubuntu-11.04-natty
  bzrlib: /usr/lib/python2.6/dist-packages/bzrlib
  Bazaar configuration: /home/didrocks/.bazaar
  Bazaar log file: /home/didrocks/.bzr.log
[…]

$ bzr plugins -v | grep launchpad
launchpad 2.3b2
   /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: bzr 2.3.0~beta2-1
ProcVersionSignature: Ubuntu 2.6.37-6.17-generic 2.6.37-rc3
Uname: Linux 2.6.37-6-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Fri Dec 3 15:50:14 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha i386 (20100918)
ProcEnviron:
 PATH=(custom, user)
 LANG=fr_FR.utf8
 SHELL=/bin/bash
SourcePackage: bzr

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :
Revision history for this message
James Westby (james-w) wrote :

I suspect, given that you don't get an error on commit, that this is a problem with /showing/ the
links, rather than recording them. I'm not sure what the best way to inspect the revision to check
that is though.

Thanks,

James

Revision history for this message
Vincent Ladeuil (vila) wrote :

@Didier: Do you still encounter the issue ?

Changed in bzr:
status: New → Incomplete
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Hey Vincent, seems to be good now with latest natty bzr version.
$ bzr commit -m "foo" --fixes lp:1234
$ bzr log -r -1
[…]
fixes bug(s): https://launchpad.net/bugs/1234

However, this is no more the case for inline comment, like:
bzr commit -m "fix bug LP: #1234"
Wasn't there a shortcut for that, appending --fixes lp: in that case?

Revision history for this message
Vincent Ladeuil (vila) wrote :

I never heard about such shortcut :)

Was it builddeb specific may be ?

This could be a nice addition but I don't quite see how to generalize it if it doesn't follow the lp:1234 notation...

Changed in bzr:
importance: Undecided → Wishlist
status: Incomplete → Confirmed
summary: - --fixes lp:<number> doesn't link to launchpad bug number
+ LP: #xxxx in the commit message should trigger --fixes lp:xxxx
Jelmer Vernooij (jelmer)
Changed in bzr (Ubuntu):
status: New → Confirmed
Revision history for this message
Samuel Bronson (naesten) wrote :

Do we really want *every* launchpad bug mentioned in a commit message to be considered fixed by the commit in question? Couldn't one be mentioned in any other capacity?

Revision history for this message
James Westby (james-w) wrote : Re: [Bug 684764] Re: LP: #xxxx in the commit message should trigger --fixes lp:xxxx

On Wed, 09 Feb 2011 20:36:56 -0000, Samuel Bronson <email address hidden> wrote:
> Do we really want *every* launchpad bug mentioned in a commit message to
> be considered fixed by the commit in question? Couldn't one be mentioned
> in any other capacity?

Yes, but if you say "LP: #XXXXX" then it will close the bug on
upload. It's a specially defined syntax to mean "closes this
bug". Therefore I think this change would be appropriate. If you want to
talk about a bug but not close it then use a different syntax (I have
done this many times).

Thanks,

James

Jelmer Vernooij (jelmer)
Changed in bzr (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Wishlist
Jelmer Vernooij (jelmer)
tags: added: check-for-breezy
Jelmer Vernooij (jelmer)
tags: removed: check-for-breezy
Jelmer Vernooij (jelmer)
Changed in brz:
status: New → Triaged
importance: Undecided → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.