bzr-builddeb --export-upstream uses bzr revision from changelog and not from config/command-line

example branch: https://code.edge.launchpad.net/~asac/+junk/LP415572.example

just branch it and run bzr bd;

Result: revision 9 is exported as orig.tar.gz, while an upstream revision is configured in default.conf

we worked around this by using "rev" rather than "bzr" token in changelog for now: https://code.launchpad.net/~ubuntu-dev/firefox-extensions/bindwood.ubuntu

Alexander Sack wrote:
> Public bug reported:
>
> Binary package hint: bzr-builddeb
>
>
> 1. use a .bzr-builddeb/default.conf with proper export-upstream-revision and export-upstream = .
> 2. use a bzrREV in changelog version
> 3. run bzr bd --merge
>
> result: it produces orig.tar.gz from bzrREV
> expected result: produce orig.tar.gz based on default.conf values
>
> This bug feels like a general design problem. As a rule of thumb,
> command line arguments should strictly dominate config files which in
> turn should strictly dominate implicit automagic.

I don't know why you think it is a design problem, that is the rule.
This was simply a bug, which is now fixed.

Thanks,

James

yay bugfixes!

thanks.

re: why a design problem ... all i wanted to say is that we might want to check if this applies for other settings as well.

This bug was fixed in the package bzr-builddeb - 2.2~ubuntu3

---------------
bzr-builddeb (2.2~ubuntu3) karmic; urgency=low

  [ Jelmer Vernooij ]
  * Automatically use merge mode if there's only a debian/ directory in
    the packaging branch. Closes: #529816.

  [ James Westby ]
  * Merge merge-package command from Muharem Hrnjadovic to allow merging
    another branch of the same package in a way that will avoid spurious
    conflicts from divergent upstream histories. Thanks Muharem.
  * Don't crash on merge-upstream due to API changes not being fully applied.
  * Add plugin information as parsed by "bzr plugin-info".
  * Improve the error when the upstream tag is missing during merge-upstream.
  * Also query the config file for the revision to use in export-upstream
    (LP: #415572)
  * Don't populate the commit message editor with all lines added to
    debian/changelog. Only use the stripped version of the "change" lines.
  * Always use the date from debian/changelog during import-dsc. Thanks
    Sveinung Kvilhaugsvik.
  * pristine-tar errors are no longer fatal for building the package.
    Thanks Muharem. (LP: #417153)
  * Refuse to build a conflicted tree. Thanks Muharem. (LP: #381303)
  * Don't crash if there are no deb-src lines when building. (LP: #375897)
  * Make import-dsc work against redirected URIs. Thanks Muharem (LP: #337209)

 -- James Westby <email address hidden> Sun, 26 Jul 2009 18:38:47 +0200