the hardware hook blows away /proc/$pid/cmdline details
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apparmor (Ubuntu) |
Fix Released
|
Low
|
Jamie Strandboge | ||
Lucid |
Fix Released
|
Low
|
Jamie Strandboge | ||
Maverick |
Fix Released
|
Low
|
Jamie Strandboge | ||
Natty |
Fix Released
|
Low
|
Jamie Strandboge | ||
apport (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Lucid |
Won't Fix
|
Undecided
|
Unassigned | ||
Maverick |
Won't Fix
|
Undecided
|
Unassigned | ||
Natty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
SRU Justification
1. impact of the bug is minimal for stable releases, since apport is disabled by default. However, being able to run 'ubuntu-bug', 'apport-bug' or 'apport-collect' is useful for developers trying to get more information from users.
2. This has been addressed in the development branch
3. Patch is very small. See comment #3.
4. TEST CASE:
$ sudo apport-bug apparmor --save /tmp/apport.txt
Examine /tmp/apport.txt. It should have something like:
ProcKernelCmdline: root=UUID=
5. The regression potential of the patch is very low, as it updates the apport hook which is not enabled by default in the stable releases.
Initial report
21:34 < kees> self['ProcCmdline'] = _read_file('/proc/' + pid + '/cmdline'
21:34 < kees> vs
21:34 < kees> ./apport/
The hardware hook is destroying the /proc/$pid/cmdline information.
ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: apport 1.14.1-0ubuntu8
ProcVersionSign
Uname: Linux 2.6.35-22-generic x86_64
ApportLog:
Architecture: amd64
CrashReports:
600:0:
600:0:
600:0:
Date: Fri Oct 8 14:35:30 2010
PackageArchitec
ProcEnviron:
LANGUAGE=en_US:en
PATH=(custom, user)
LANG=en_US.utf8
SHELL=/bin/bash
SourcePackage: apport
description: | updated |
Changed in apport (Ubuntu Lucid): | |
status: | New → Won't Fix |
Changed in apparmor (Ubuntu Lucid): | |
assignee: | nobody → Jamie Strandboge (jdstrand) |
importance: | Undecided → Low |
milestone: | none → lucid-updates |
status: | New → In Progress |
tags: |
added: verification-done removed: verification-needed |
tags: |
added: verification-done removed: verification-needed |
tags: | added: testcase |
Changed in apport (Ubuntu Maverick): | |
status: | Fix Committed → Won't Fix |
Fixed in bzr commit 1791.
=== modified file 'apport/ hookutils. py'
--- apport/hookutils.py 2010-06-23 08:05:56 +0000
+++ apport/hookutils.py 2010-10-08 21:36:25 +0000
@@ -109,7 +109,7 @@
attach_ file(report, '/proc/interrupts', 'ProcInterrupts') file(report, '/proc/cpuinfo', 'ProcCpuinfo') ine') file(report, '/proc/modules', 'ProcModules') file(report, '/var/log/udev', 'UdevLog')
attach_
- attach_file(report, '/proc/cmdline', 'ProcCmdLine')
+ attach_file(report, '/proc/cmdline', 'ProcKernelCmdL
attach_
attach_