the WifiSyslog apport hook (used in firefox/tb) includes SSID informations

Thank you for your bug report, that indeed seems an issue

What apport does is provide a 'attach_wifi' that includes
" report['WifiSyslog'] = recent_syslog(re.compile(r'(NetworkManager|modem-manager|dhclient|kernel|wpa_supplicant)(\[\d+\])?:'))"

Some though
- the n-m stack should probably not include those info in syslog/journal by default
- the apport hook should anonymize the log in that such info are there
- firefox/tb uses that function, maybe that's not needed?

I removed the attach_wifi() call in the apport hook. This will make it to the next firefox stable update.

@osomon +1, thanks!

This bug was fixed in the package firefox - 64.0+build1-0ubuntu1

---------------
firefox (64.0+build1-0ubuntu1) disco; urgency=medium

  * New upstream stable release (64.0build1)

  [ Olivier Tilloy ]
  * Do not attach Wi-Fi syslog to apport reports (LP: #1801383)
    - update debian/apport/source_firefox.py.in
  * Update debian/patches/unity-menubar.patch

  [ Rico Tzschichholz ]
  * Explicitly set HOME=/tmp
    - update debian/build/rules.mk
  * Bump build-dep on rustc >= 1.29.0 and cargo >= 0.30
    - update debian/control{,.in}
  * Bump cbindgen dependency to 0.6.7
    - update debian/build/create-tarball.py
  * Ship removed onboarding watermark.svg to keep using it as symbolic icon
    - add debian/symbolic.svg
    - update debian/build/rules.mk
  * Drop upstreamed patches
    - remove debian/patches/fix-armhf-aom-build.patch
  * Update patches
    - update debian/patches/dont-treat-tilde-as-special.patch
    - update debian/patches/update-gn-mozbuild.patch

 -- Olivier Tilloy <email address hidden> Tue, 04 Dec 2018 22:39:30 +0100

This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:

apport-collect 1801383

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the Ubuntu Kernel Team.

`apport-bug linux` uploads WifiSyslog.txt, so this also affects apport hook for the linux package.

The linux kernel apport hook is provided by apport directly, so needs to be fixed there:

  $ grep -i Wifi /usr/share/apport/package-hooks/source_linux.py
    apport.hookutils.attach_wifi(report)
  $ dpkg -S /usr/share/apport/package-hooks/source_linux.py
    apport: /usr/share/apport/package-hooks/source_linux.py

Hi Brian,

Is this bug on your radar?

Thanks!

Olivier,

Did this fix make it to Thunderbird?

Thanks!

Marc, the version currently in eoan-proposed has the fix. I'm working on addressing autopkgtest issues in related packages that prevent thunderbird from migrating to the release pocket.

Once sorted out in eoan, I'll proceed to preparing updates for all stable releases, including this fix.

WifiSyslog does contain SSID information. While this will be removed from the thunderbird and firefox packages, I don't think it would be appropriate to remove it from the linux kernel apport reports.

For linux packages, this information is helpful in debugging wireless driver issues.

While a list of access point information can be viewed as a privacy issue, the user is prompted when Apport runs if the information is suitable to be attached to the bug or not. In environments where there are privacy concerns, the user can choose to not attach the information when submitting the bug report.

I am therefore closing the Apport task for this bug. Thanks!

This bug was fixed in the package thunderbird - 1:68.1.1+build1-0ubuntu1

---------------
thunderbird (1:68.1.1+build1-0ubuntu1) eoan; urgency=medium

  * New upstream stable release (68.1.1build1)

  * Build thunderbird against the system-wide version of sqlite3 (LP: #1845929)
    - update debian/config/mozconfig.in
    - update debian/control{,.in}

 -- Olivier Tilloy <email address hidden> Tue, 01 Oct 2019 14:47:00 +0200