created account displayName not always shown after successful creation

Bug #1231697 reported by Mike McCracken
This bug affects 2 people
Affects Status Importance Assigned to Milestone
accounts-qml-module (Ubuntu)
Fix Released
Alberto Mardegan

Bug Description

When creating a UOA account (either by logging in or registering anew) using the UbuntuOne provider from lp:ubuntuone-credentials (in online-accounts-provider/ in trunk ), after success, when the provider signals 'finished()', the Accounts page is shown with the newly created account listed, but the displayName is not shown.

If I exit to the main system-settings page and click on "Accounts" again to get back to the accounts list, the displayName is shown correctly.

This appears to be a regression, although I'm not sure how. Here's some background:

The displayName wasn't updating correctly a couple of weeks ago, and I found that it was an issue with our provider creating a new account instead of using the one created by the code in NewAccountPage.qml in ubuntu-system-settings-online-accounts.

I made changes to our code to make sure we find that account and update it instead of creating a new one.
I also made our code set the display name, then call account.sync() and connect the synced signal to the finished signal, so we don't signal finished until the account has been synced, and thus the displayName should definitely be set.
Here are those changes:

As of that MP, the displayName displayed correctly after success. It no longer does.

Tags: qa-touch u1

Related branches

Mike McCracken (mikemc)
Changed in ubuntu-system-settings-online-accounts:
assignee: nobody → Alberto Mardegan (mardy)
Leo Arias (elopio)
Changed in ubuntu-system-settings-online-accounts:
status: New → Confirmed
tags: added: qa-touch u1
Revision history for this message
Alberto Mardegan (mardy) wrote :
affects: ubuntu-system-settings-online-accounts → accounts-qml-module
Changed in accounts-qml-module:
importance: Undecided → High
affects: accounts-qml-module → accounts-qml-module (Ubuntu)
Changed in accounts-qml-module (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package accounts-qml-module - 0.4+14.04.20140305-0ubuntu1

accounts-qml-module (0.4+14.04.20140305-0ubuntu1) trusty; urgency=low

  [ CI bot ]
  * No change rebuild against Qt 5.2.1.

  [ Albert Astals Cid ]
  * Merge from upstream Do not pass negative ranges to model calls. (LP:
    #1231697, #1271039, #1255343)

  [ Alberto Mardegan ]
  * Merge from upstream Do not pass negative ranges to model calls. (LP:
    #1231697, #1271039, #1255343)
  * Merge from upstream Fix a regression introduced with latest fix,
    where empty models wrongly emit the rowsInserted signal. (LP:
    #1231697, #1271039, #1255343)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Wed, 05 Mar 2014 09:15:03 +0000

Changed in accounts-qml-module (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.