[Browser] No way to navigate both in private and 'clear' mode at the same time
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UX |
In Progress
|
Medium
|
James Mulholland | ||
| webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Olivier Tilloy | ||
Bug Description
I expect to be able to have some tabs in private mode and some tabs in 'classic' mode at the same time, and navigate on both.
Also, I expect on desktop that private mode is opened in a new window, as for all desktop browser
--- --- --- ---
UX Comment:
For windowed environments (once multi-window mode is supported) we should open a new instance of the browser App for Private Mode.
For mobile we would not want to introduce mixed private and non private mode tabs in the tab spread.
That said, we should perhaps reconsider our current approach where exiting private mode causes all private mode tabs to be closed (after confirmation) and consider allowing private mode tabs to persist within private mode until the private mode tab itself is closed by the user.
This would conform to the behaviour observed in/ expected from the vast majority of mobile browsers and address the issues highlighted in this bug.
Related branches
- Andrew Hayzen (community): Approve
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 2873 lines (+946/-1059)35 files modifiedsrc/Ubuntu/Web/UbuntuWebContext.qml (+5/-2)
src/Ubuntu/Web/UserAgent02.qml (+3/-3)
src/app/BrowserView.qml (+2/-5)
src/app/BrowserWindow.qml (+0/-13)
src/app/CMakeLists.txt (+0/-1)
src/app/actions/OpenLinkInNewWindow.qml (+23/-0)
src/app/actions/OpenLinkInPrivateWindow.qml (+23/-0)
src/app/browserapplication.cpp (+10/-45)
src/app/browserapplication.h (+3/-7)
src/app/webbrowser-window.cpp (+0/-51)
src/app/webbrowser-window.h (+0/-57)
src/app/webbrowser/Browser.qml (+95/-418)
src/app/webbrowser/BrowserTab.qml (+6/-0)
src/app/webbrowser/LeavePrivateModeDialog.qml (+0/-43)
src/app/webbrowser/webbrowser-app.cpp (+34/-6)
src/app/webbrowser/webbrowser-app.desktop.in.in (+9/-0)
src/app/webbrowser/webbrowser-app.h (+4/-1)
src/app/webbrowser/webbrowser-app.qml (+424/-49)
src/app/webcontainer/WebApp.qml (+2/-0)
src/app/webcontainer/WebViewImplOxide.qml (+5/-7)
src/app/webcontainer/WebappContainerWebview.qml (+5/-1)
src/app/webcontainer/webapp-container.cpp (+51/-26)
src/app/webcontainer/webapp-container.h (+7/-2)
src/app/webcontainer/webapp-container.qml (+12/-3)
tests/autopilot/webbrowser_app/__init__.py (+4/-1)
tests/autopilot/webbrowser_app/emulators/browser.py (+0/-55)
tests/autopilot/webbrowser_app/tests/__init__.py (+22/-0)
tests/autopilot/webbrowser_app/tests/test_contextmenu.py (+29/-0)
tests/autopilot/webbrowser_app/tests/test_fullscreen.py (+0/-54)
tests/autopilot/webbrowser_app/tests/test_keyboard.py (+22/-0)
tests/autopilot/webbrowser_app/tests/test_multiple_windows.py (+40/-0)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+0/-49)
tests/autopilot/webbrowser_app/tests/test_private.py (+0/-115)
tests/autopilot/webbrowser_app/tests/test_tabs.py (+0/-45)
tests/unittests/qml/tst_BrowserWindow.qml (+106/-0)
| tags: | added: design-gap |
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| assignee: | nobody → James Mulholland (jamesjosephmulholland) |
| no longer affects: | webbrowser-app |
| summary: |
- No way to navigate both in private and 'clear' mode at the same time + [Browser] No way to navigate both in private and 'clear' mode at the + same time |
| description: | updated |
| Changed in ubuntu-ux: | |
| status: | Triaged → In Progress |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → In Progress |
| assignee: | nobody → Olivier Tilloy (osomon) |
| importance: | Undecided → Medium |
| tags: | added: multiwindows |
| tags: |
added: windows removed: multiwindows |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
Note that multi-window mode is not yet supported (well one can have several instances of the app running, but only the session of the first instance will be saved/restored, and concurrent writes to the history and bookmarks databases will result in undefined behaviour).
This private browsing mode spec is initially targetted at mobile, we’ll have to adapt it to desktop.