[music] Use new page head sections from new sdk
Bug #1447428 reported by
Victor Thompson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Music App |
Fix Released
|
Low
|
Victor Thompson | ||
| Ubuntu UX |
Fix Committed
|
High
|
Jouni Helminen | ||
Bug Description
The ubuntu-ui-toolkit is getting revamped to include improved page head section and an overall improved header. I've attached the view of some initial testing to use "sections". The developers need design input prior to moving forward with this change.
Related branches
lp://staging/~vthompson/music-app/prototype-page-head-sections
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
- Music App Developers: Pending requested
-
Diff: 143 lines (+33/-23)3 files modifiedMusicNowPlaying.qml (+19/-10)
common/Themes/Ambiance/PageHeadStyle.qml (+7/-0)
music-app.qml (+7/-13)
lp://staging/~music-app-dev/music-app/prototype-page-head-sections-2
- Music App Developers: Pending requested
-
Diff: 1110 lines (+134/-128)61 files modifiedapp/components/BlurredBackground.qml (+1/-1)
app/components/BlurredHeader.qml (+1/-1)
app/components/CoverGrid.qml (+1/-1)
app/components/Delegates/Card.qml (+1/-1)
app/components/Delegates/ListItemWithActions.qml (+1/-1)
app/components/Delegates/MusicListItem.qml (+1/-1)
app/components/Dialog/ContentHubErrorDialog.qml (+1/-1)
app/components/Dialog/ContentHubNotFoundDialog.qml (+1/-1)
app/components/Dialog/ContentHubWaitDialog.qml (+1/-1)
app/components/Dialog/EditPlaylistDialog.qml (+1/-1)
app/components/Dialog/NewPlaylistDialog.qml (+1/-1)
app/components/Dialog/RemovePlaylistDialog.qml (+1/-1)
app/components/Flickables/CardView.qml (+1/-1)
app/components/Flickables/MultiSelectListView.qml (+1/-1)
app/components/Flickables/MusicListView.qml (+1/-1)
app/components/HeadState/MultiSelectHeadState.qml (+1/-1)
app/components/HeadState/PlaylistsHeadState.qml (+1/-1)
app/components/HeadState/SearchHeadState.qml (+1/-1)
app/components/HeadState/SearchableHeadState.qml (+1/-1)
app/components/Helpers/ContentHubHelper.qml (+1/-1)
app/components/Helpers/UriHandlerHelper.qml (+1/-1)
app/components/Helpers/UserMetricsHelper.qml (+1/-1)
app/components/ListItemActions/AddToPlaylist.qml (+1/-1)
app/components/ListItemActions/AddToQueue.qml (+1/-1)
app/components/ListItemActions/CheckBox.qml (+1/-1)
app/components/ListItemActions/Remove.qml (+1/-1)
app/components/ListItemReorderComponent.qml (+1/-1)
app/components/LoadingSpinnerComponent.qml (+1/-1)
app/components/MusicPage.qml (+1/-1)
app/components/MusicRow.qml (+1/-1)
app/components/MusicToolbar.qml (+1/-1)
app/components/NowPlayingFullView.qml (+1/-1)
app/components/NowPlayingToolbar.qml (+1/-1)
app/components/PlaylistsEmptyState.qml (+1/-1)
app/components/Queue.qml (+1/-1)
app/components/Style.qml (+1/-1)
app/components/Themes/Ambiance/BubbleShape.qml (+1/-1)
app/components/Themes/Ambiance/UbuntuBlueSliderStyle.qml (+1/-1)
app/components/ViewButton/PlayAllButton.qml (+1/-1)
app/components/ViewButton/QueueAllButton.qml (+1/-1)
app/components/ViewButton/ShuffleButton.qml (+1/-1)
app/components/Walkthrough/FirstRunWalkthrough.qml (+1/-1)
app/components/Walkthrough/Slide1.qml (+1/-1)
app/components/Walkthrough/Slide2.qml (+1/-1)
app/components/Walkthrough/Slide3.qml (+1/-1)
app/components/Walkthrough/Walkthrough.qml (+1/-1)
app/components/WorkerWaiter.qml (+1/-1)
app/music-app.qml (+3/-14)
app/ui/AddToPlaylist.qml (+1/-1)
app/ui/Albums.qml (+1/-1)
app/ui/ArtistView.qml (+1/-1)
app/ui/Artists.qml (+1/-1)
app/ui/Genres.qml (+1/-1)
app/ui/LibraryEmptyState.qml (+1/-1)
app/ui/NowPlaying.qml (+22/-9)
app/ui/Playlists.qml (+1/-1)
app/ui/Recent.qml (+1/-1)
app/ui/Songs.qml (+1/-1)
app/ui/SongsView.qml (+1/-1)
music-app.qmltheme (+1/-1)
po/com.ubuntu.music.pot (+51/-47)
lp://staging/~vthompson/music-app/music-uc1.3-now-playing-fix-1447428
- Jenkins Bot: Approve (continuous-integration)
- Victor Thompson: Approve
- Andrew Hayzen: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 427 lines (+87/-70)5 files modifiedapp/music-app.qml (+3/-9)
app/ui/NowPlaying.qml (+25/-10)
debian/changelog (+1/-0)
po/com.ubuntu.music.pot (+51/-47)
tests/autopilot/music_app/__init__.py (+7/-4)
Revision history for this message
| Victor Thompson (vthompson) wrote | #1 |
| Changed in music-app: | |
| importance: | Undecided → Low |
| Changed in ubuntu-ux: | |
| status: | New → Triaged |
| assignee: | nobody → Jouni Helminen (jounihelminen) |
| Changed in ubuntu-ux: | |
| importance: | Undecided → High |
Revision history for this message
| Jouni Helminen (jounihelminen) wrote | #2 |
| Changed in ubuntu-ux: | |
| status: | Triaged → In Progress |
Revision history for this message
| Jouni Helminen (jounihelminen) wrote | #3 |
Revision history for this message
| Victor Thompson (vthompson) wrote | #4 |
Revision history for this message
| Jouni Helminen (jounihelminen) wrote | #5 |
| Changed in ubuntu-ux: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| assignee: | nobody → Victor Thompson (vthompson) |
| status: | New → In Progress |
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote | #6 |
| Changed in music-app: | |
| status: | In Progress → Fix Committed |
| Changed in music-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We have done some further work on the sections and those are landing soon. Let's review next week together Victor