[SDK] MainView.backgroundColor is not usable any more
Bug #1356779 reported by
Michael Zanetti
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Released
|
High
|
Jouni Helminen | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri |
Bug Description
Since the latest SDK updates, MainView.
For example setting a dark background causes:
* Text in Dialogs to be unreadable
* Header Popovers (the new ones) to turn purple(!)
* Active ListItem's text color to be unreadable
And the situation seems to get worse with each uitk update... Maybe the *color properties of the MainView should just be removed? If you think that should be kept but all the places that break should be fixed instead to make it work again, please let me know and I'll do my best to collect all the places it broke.
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/app-theming
Rejected
for merging
into
lp://staging/ubuntu-ui-toolkit/rtm
- Tim Peeters: Approve (quick look)
- Cris Dywan: Approve
-
Diff: 529 lines (+370/-21)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+4/-2)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+15/-1)
lp://staging/~zsombi/ubuntu-ui-toolkit/app-theming-to-staging
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 518 lines (+368/-20)16 files modifiedexamples/customtheme/customtheme.apparmor (+8/-0)
examples/customtheme/customtheme.desktop (+8/-0)
examples/customtheme/customtheme.qmlproject (+59/-0)
examples/customtheme/main.qml (+103/-0)
examples/customtheme/manifest.json (+15/-0)
examples/customtheme/theme/Palette.qml (+24/-0)
examples/customtheme/theme/parent_theme (+1/-0)
modules/Ubuntu/Components/MainView.qml (+16/-0)
modules/Ubuntu/Components/Themes/Ambiance/MainViewStyle.qml (+0/-17)
modules/Ubuntu/Components/plugin/uctheme.cpp (+3/-1)
tests/unit_x11/tst_components/tst_theming.qml (+60/-0)
tests/unit_x11/tst_theme_engine/AppTheme/Palette.qml (+24/-0)
tests/unit_x11/tst_theme_engine/AppTheme/parent_theme (+1/-0)
tests/unit_x11/tst_theme_engine/TestApp.qml (+29/-0)
tests/unit_x11/tst_theme_engine/tst_theme_engine.pro (+3/-1)
tests/unit_x11/tst_theme_engine/tst_theme_enginetest.cpp (+14/-1)
summary: |
- MainView.bacgroundColor is not usable any more + MainView.backgroundColor is not usable any more |
description: | updated |
description: | updated |
Changed in ubuntu-ui-toolkit: | |
status: | New → Triaged |
importance: | Undecided → Critical |
assignee: | nobody → Zsombor Egri (zsombi) |
Changed in ubuntu-ui-toolkit: | |
milestone: | none → 11.07 |
Changed in ubuntu-ui-toolkit: | |
status: | Triaged → Incomplete |
Changed in ubuntu-ui-toolkit: | |
status: | Incomplete → Confirmed |
Changed in ubuntu-ui-toolkit: | |
importance: | Critical → High |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Confirmed |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ux: | |
importance: | Undecided → High |
status: | New → Triaged |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
summary: |
- MainView.backgroundColor is not usable any more + [SDK] MainView.backgroundColor is not usable any more |
Changed in ubuntu-ux: | |
assignee: | Giorgio Venturi (giorgio-venturi) → nobody |
assignee: | nobody → Jouni Helminen (jounihelminen) |
Changed in ubuntu-ux: | |
status: | Triaged → Fix Released |
no longer affects: | ubuntu-ui-toolkit (Ubuntu Vivid) |
no longer affects: | ubuntu-ui-toolkit (Ubuntu RTM) |
To post a comment you must log in.
The biggest problem is that it is not possible to know what color should be used in the labels due to the fact that we don't necessarily know what is the color the label is rendered on, unfortunately Text/Label does not support chameleon colors.
OTOH, I would be glad to see those colors which cause trouble, so we can see what luminosity or other color tone we should use to chose the proper theme.