[Toolbar] Bottom edge swipe is detected 2gu away from edge
Bug #1130446 reported by
Oren Horev
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Invalid
|
Undecided
|
Tim Peeters | ||
Ubuntu UX |
Fix Committed
|
Critical
|
Oren Horev | ||
manhattan |
Fix Released
|
High
|
Olivier Tilloy | ||
webbrowser-app |
Invalid
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
currently I can grab the toolbar with an initial touch at more than 10GU away from the edge, a natural position to flick a web page.
This makes the bottom edge swipe conflict with scrolls
expected behaviour
-----------------
edge detection area shouldn't exceed the shell threshold of 2gu
Update
------
This issue is occurring across all apps. Seems that edge detection / toolbar triggering with a bottom edge swipe is not consistent with detection other behaviours of other edges
Related branches
lp://staging/~osomon/webbrowser-app/sdk-generic-toolbar
- Ugo Riboni (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 392 lines (+71/-229)5 files modifiedsrc/Ubuntu/Browser/Browser.qml (+51/-48)
src/Ubuntu/Browser/Chrome.qml (+1/-1)
src/Ubuntu/Browser/RevealingBar.qml (+0/-112)
tests/autopilot/webbrowser_app/tests/__init__.py (+4/-26)
tests/autopilot/webbrowser_app/tests/test_toolbar.py (+15/-42)
description: | updated |
summary: |
- [SDK] Bottom edge swipe is detected more than 10gu away from edge + [browser] Bottom edge swipe is detected more than 10gu away from edge |
tags: | removed: must-have |
Changed in manhattan: | |
status: | New → Confirmed |
Changed in manhattan: | |
status: | Confirmed → In Progress |
Changed in manhattan: | |
status: | In Progress → Fix Committed |
Changed in manhattan: | |
status: | Fix Committed → Fix Released |
Changed in webbrowser-app: | |
status: | New → Invalid |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | New → Invalid |
To post a comment you must log in.
This is happening because the browser currently doesn’t use the SDK’s toolbar, it implements its custom solution.
This will change in the future. In the meantime, we need to ensure the trigger zone has the same height as in the SDK. That’s currently 2 grid units.