[textarea] TextArea focus is not handled correctly
Bug #1163371 reported by
Ugo Riboni
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Zsombor Egri | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Unassigned |
Bug Description
Refer to the attached example, running on a phone.
(1) touch the red button: the top text field is focused and the OSK comes up
(2) touch the green button: the bottom text field is focused but the OSK doesn't come up
What should happen is obviously that at step (2) the OSK comes up.
The problem is that somehow focus is not proxied correctly inside of the TextArea or the OSK is not invoked correctly when the inner text component received activeFocus.
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/textinput-focus
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu SDK team: Pending requested
-
Diff: 182 lines (+109/-2)4 files modifiedmodules/Ubuntu/Components/TextArea.qml (+9/-1)
modules/Ubuntu/Components/TextField.qml (+9/-1)
tests/unit/tst_components/tst_textarea.qml (+46/-0)
tests/unit/tst_components/tst_textfield.qml (+45/-0)
lp://staging/~ken-vandine/ubuntu-ui-toolkit/raring.0.1.43
- Timo Jyrinki: Approve
-
Diff: 552 lines (+312/-55)9 files modifieddebian/changelog (+14/-0)
demos/ListItems.qml (+9/-0)
modules/Ubuntu/Components/TextArea.qml (+17/-10)
modules/Ubuntu/Components/TextField.qml (+0/-10)
modules/Ubuntu/Components/plugin/quickutils.cpp (+28/-0)
modules/Ubuntu/Components/plugin/quickutils.h (+5/-0)
tests/unit/tst_components/tst_textarea.qml (+125/-3)
tests/unit/tst_components/tst_textfield.qml (+90/-13)
themes/Ambiance/qmltheme/TextAreaDelegate.qml (+24/-19)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Zsombor Egri (zsombi) |
importance: | Undecided → High |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit: | |
importance: | High → Critical |
Changed in ubuntu-ui-toolkit: | |
status: | Confirmed → In Progress |
description: | updated |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
importance: | Undecided → High |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The problem is that when (2) is executed, setting focus on t2 removes focus from t1, resulting in removing OSK. This removal is happening because we remove the OSK explicitly when focus is lost (TextArea lines 923->930). In order to control that, we need to expose a property which drives the automatic OSK removal upon focus loss.