Ubuntu theme

Applications using client-side decorations are not resizable in Unity

Bug #1276177 reported by Lars Karlitski on 2014-02-04

This bug affects 8 people

	Status	Importance	Assigned to	Milestone
Ubuntu theme	In Progress	Medium	Leo Iannacone
Unity	Fix Released	Medium	Marco Trevisan (Treviño)	Unity 7.3.1
7.2	Fix Released	Medium	Unassigned	Unity 7.2.4 "14.04 SRU 4"
unity (Ubuntu)	Fix Released	Medium	Marco Trevisan (Treviño)
Trusty	Fix Released	Undecided	Unassigned

Bug Description

[ Impact ]

GNOME applications that use client-side decorations can't be resized on Unity. I think it's because the frame extents hint is not supported.

gnome-clocks and gnome-tweak-tool are two apps in the archive that have this problem.

[ Test Case ]

Run one of the abovementioned applications. Their windows should be resizable.

[ Regression Potential ]

Any modifications to the Unity desktop shell could potentially introduce new crashes or lockups.

[ Other Info ]

The Unity SRU fix for Ubuntu 14.04 LTS was cherry-picked from upstream Unity, where it has been in production use in Ubuntu "Vivid Vervet" dev release for some time without apparent regression.

See original description

Tags:

Related branches

lp://staging/~3v1n0/unity/decoration-edges-improvements

Merged into lp://staging/unity at revision 3882

PS Jenkins bot (community): Approve (continuous-integration) on 2014-10-10

Brandon Schaefer (community): Approve on 2014-10-01

lp://staging/~unity-team/unity/7.2.4

Merged into lp://staging/unity/7.2 at revision 3806

Marco Trevisan (Treviño): Approve on 2014-12-17

Diff: 6023 lines (+2168/-709)

105 files modified

CMakeLists.txt (+1/-0)
UnityCore/DBusIndicators.cpp (+11/-0)
UnityCore/DBusIndicators.h (+1/-0)
UnityCore/DesktopUtilities.cpp (+12/-0)
UnityCore/DesktopUtilities.h (+1/-0)
UnityCore/GLibDBusProxy.cpp (+100/-3)
UnityCore/GLibDBusProxy.h (+6/-0)
UnityCore/GLibWrapper-inl.h (+12/-0)
UnityCore/GLibWrapper.h (+1/-0)
UnityCore/GnomeSessionManager.cpp (+0/-1)
UnityCore/Indicators.h (+1/-0)
dash/FilterBasicButton.cpp (+6/-3)
dash/previews/ActionButton.cpp (+5/-2)
dash/previews/ErrorPreview.cpp (+1/-0)
dash/previews/PaymentPreview.cpp (+3/-1)
data/CMakeLists.txt (+1/-0)
data/pam/CMakeLists.txt (+1/-0)
data/pam/unity (+2/-0)
debian/changelog (+59/-0)
debian/rules (+1/-1)
debian/unity.install (+1/-0)
debian/unity.migrations (+1/-0)
decorations/DecoratedWindow.cpp (+155/-64)
decorations/DecorationsEdgeBorders.cpp (+32/-19)
decorations/DecorationsForceQuitDialog.cpp (+17/-3)
decorations/DecorationsManager.cpp (+17/-26)
decorations/DecorationsPriv.h (+12/-3)
decorations/DecorationsTitle.cpp (+1/-0)
decorations/DecorationsWidgets.cpp (+13/-1)
decorations/DecorationsWidgets.h (+5/-0)
doc/unity.1 (+35/-10)
hud/HudIconTextureSource.cpp (+0/-5)
hud/HudIconTextureSource.h (+0/-1)
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/DesktopLauncherIcon.cpp (+13/-1)
launcher/DesktopLauncherIcon.h (+2/-0)
launcher/Launcher.cpp (+1/-3)
launcher/LauncherIcon.cpp (+117/-104)
launcher/LauncherIcon.h (+12/-8)
launcher/MockLauncherIcon.h (+0/-5)
launcher/SwitcherView.cpp (+9/-1)
launcher/Tooltip.cpp (+5/-4)
lockscreen/BackgroundSettings.cpp (+13/-11)
lockscreen/BackgroundSettings.h (+0/-1)
lockscreen/CMakeLists.txt (+2/-0)
lockscreen/CofView.cpp (+15/-2)
lockscreen/CofView.h (+3/-1)
lockscreen/LockScreenAbstractShield.h (+14/-1)
lockscreen/LockScreenController.cpp (+54/-14)
lockscreen/LockScreenController.h (+12/-3)
lockscreen/LockScreenPanel.cpp (+31/-2)
lockscreen/LockScreenSettings.cpp (+2/-0)
lockscreen/LockScreenSettings.h (+2/-1)
lockscreen/LockScreenShield.cpp (+60/-29)
lockscreen/LockScreenShield.h (+10/-3)
lockscreen/LockScreenShieldFactory.cpp (+7/-2)
lockscreen/LockScreenShieldFactory.h (+12/-2)
lockscreen/ShutdownNotifier.cpp (+152/-0)
lockscreen/ShutdownNotifier.h (+51/-0)
lockscreen/SuspendNotifier.cpp (+153/-0)
lockscreen/SuspendNotifier.h (+51/-0)
lockscreen/UserAuthenticatorPam.cpp (+1/-2)
lockscreen/UserPromptView.cpp (+96/-17)
lockscreen/UserPromptView.h (+5/-4)
panel/PanelIndicatorEntryView.cpp (+1/-1)
panel/PanelMenuView.cpp (+83/-38)
panel/PanelMenuView.h (+1/-1)
plugins/unityshell/src/unityshell.cpp (+29/-35)
plugins/unityshell/src/unityshell.h (+2/-2)
services/panel-main.c (+8/-0)
services/panel-service.c (+15/-0)
services/panel-service.h (+2/-0)
tests/CMakeLists.txt (+1/-1)
tests/mock_indicators.h (+1/-0)
tests/test_lockscreen_controller.cpp (+10/-2)
tests/test_main_xless.cpp (+4/-5)
tests/test_previews_music_payment.cpp (+1/-0)
tests/test_text_input.cpp (+1/-0)
tools/migration-scripts/03_unity_first_run_stamp_move (+35/-0)
unity-shared/CompizUtils.cpp (+77/-58)
unity-shared/CompizUtils.h (+36/-5)
unity-shared/DashStyle.cpp (+8/-11)
unity-shared/DecorationStyle.cpp (+2/-2)
unity-shared/GnomeKeyGrabber.cpp (+9/-0)
unity-shared/IconRenderer.cpp (+73/-43)
unity-shared/IconRenderer.h (+0/-2)
unity-shared/IconTexture.cpp (+1/-1)
unity-shared/IconTextureSource.cpp (+37/-1)
unity-shared/IconTextureSource.h (+10/-4)
unity-shared/LayoutSystem.cpp (+28/-4)
unity-shared/LayoutSystem.h (+2/-1)
unity-shared/PluginAdapter.cpp (+39/-2)
unity-shared/PluginAdapter.h (+3/-0)
unity-shared/SearchBar.cpp (+18/-12)
unity-shared/SearchBar.h (+9/-9)
unity-shared/SearchBarSpinner.h (+0/-2)
unity-shared/SpreadFilter.cpp (+3/-1)
unity-shared/StandaloneWindowManager.h (+2/-0)
unity-shared/TextInput.cpp (+138/-76)
unity-shared/TextInput.h (+17/-19)
unity-shared/UScreen.cpp (+26/-4)
unity-shared/UScreen.h (+0/-1)
unity-shared/UnitySettings.cpp (+9/-1)
unity-shared/WindowManager.h (+5/-0)
unity-shared/XWindowManager.cpp (+1/-1)

lp://staging/~l3on/ubuntu-themes/csd-fix-resize-and-shadow

Ready for review for merging into lp://staging/ubuntu-themes

Ubuntu Artwork Packagers: Pending requested 2015-03-15

Lars Karlitski (larsu) on 2014-02-04

Changed in unity (Ubuntu):
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)

Marco Trevisan (Treviño) (3v1n0) on 2014-02-04

tags:

added: new-decorations

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-05-13:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity (Ubuntu):
status:	New → Confirmed

Tim Lunn (darkxst) on 2014-06-27

tags:

added: ubuntugnome-blocker

Stephen M. Webb (bregma) on 2014-06-27

Changed in unity:
milestone:	none → 7.3.1

Adolfo Jayme Barrientos (fitojb) on 2014-06-27

Changed in unity (Ubuntu):
status:	Confirmed → Triaged
importance:	Undecided → Medium

Marco Trevisan (Treviño) (3v1n0) on 2014-10-01

Changed in ubuntu-themes:
assignee:	nobody → Leo Iannacone (l3on)
status:	New → In Progress
importance:	Undecided → High
importance:	High → Medium
Changed in unity:
importance:	Undecided → Medium
assignee:	nobody → Marco Trevisan (Treviño) (3v1n0)
status:	New → In Progress

Revision history for this message

Vlad Orlov (monsta) wrote on 2014-10-05:

It seems to me that these CSD apps aren't resizable anywhere except for Gnome Shell.

Bug Watch Updater (bug-watch-updater) on 2014-10-05

Changed in gtk+3.0 (Debian):
status:	Unknown → Confirmed

Revision history for this message

Vlad Orlov (monsta) wrote on 2014-10-15:

Follow-up: it turned out that these CSD apps are resizable in Cinnamon, at least in version 2.2.

Marco Trevisan (Treviño) (3v1n0) on 2014-10-19

Changed in unity:
status:	In Progress → Fix Committed
Changed in unity (Ubuntu):
status:	Triaged → Fix Released

Stephen M. Webb (bregma) on 2014-12-08

Changed in unity (Ubuntu):
status:	Fix Released → Invalid
status:	Invalid → Fix Released

Revision history for this message

Stephen M. Webb (bregma) wrote on 2015-01-06:

debdiff between unity_7.2.3+14.04.20140826-0ubuntu1 and unity_7.2.4+14.04.20141217-0ubuntu1 Edit (232.7 KiB, text/plain)

Attached debdiff between trusty-updates and SRU.

description:

updated

Revision history for this message

Chris J Arges (arges) wrote on 2015-01-14: Please test proposed package

Hello Lars, or anyone else affected,

Accepted unity into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/unity/7.2.4+14.04.20141217-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in unity (Ubuntu Trusty):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Jim Nelson (yorba-jim) wrote on 2015-01-15:

This update solves this specific Unity problem for California.

Marco Trevisan (Treviño) (3v1n0) on 2015-01-15

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-02-04:

This bug was fixed in the package unity - 7.2.4+14.04.20141217-0ubuntu1

---------------
unity (7.2.4+14.04.20141217-0ubuntu1) trusty; urgency=medium

  [ Andrea Azzarone ]
  * Share lockscreen password between screens (lp: #1308540)
  * Allow a distinct pam config file for greeter and for lock-screen.
    (lp: #1305440)
  * Add an arrow activator in the lockscreen. (lp: #1332509)
  * Make sure GetScreenGeometry returns the correct value (lp: #1374785).
  * unmapped all windows prior to shutdown (lp: #1370017) (lp: #1375271)

  [ Brandon Schaefer ]
  * fix tooltip for the "Show Desktop / Restore Windows" icon in the Alt-Tab
    switcher (lp: #1237132)
  * Use CONFIG instead of CACHE to store the first_run.stamp (lp: #1328677)

  [ Eleni Maria Stea ]
  * LayoutSystem: make sure the exposed open windows are displayed in the
    preserved order (lp: #1349281).

  [ handsome_feng ]
  * added support for getting the distro name from /etc/os-release
    (lp: #1329584)

  [ Iain Lane ]
  * When grabbing keys, try prefixing "XF86" if the key isn't found. GNOME
    gives us unprefixed keys sometimes (lp: #1302885).

  [ Marco Trevisan (Treviño) ]
  * make the Launcher icon count badge width depend on the text value width
    and scaling (lp: #1353070) (lp: #1354498) (lp: #796527) (lp: #1066971)
    (lp: #1361713)
  * DecoratedWindow: make edges independent from borders and properly update
    them on actions change (lp: #1276177), (lp: #1299741), (lp: #1301776),
    (lp: #1324104), (lp: #1364225), (lp: #1373695)
  * Lockscreen: scale the UI elements based on current monitor scaling
    (lp: #1292218)
  * UnityScreen: when filtering out windows in spread, make sure we unscale
    them (lp: #1316265).
  * PanelMenuView: ensure that proper window tiles and buttons are shown at
    the right place (lp: #1384910) (lp: #1384958) (lp: #1385285)
  * SearchBar, ActionButtons, IconRenderer: include the font scaling when
    scaling textual items (lp: #1332947) (lp: #1361751) (lp: #1362162)
    (lp: #1362346).
  * ApplicationLauncherIcon: make sure we close the dash if DnD is accepted
    and the application window is about to be focused (lp: #1350331).
  * SwitcherView: set progress on icon render args (lp: #1361679).
  * LockScreenController: wait for the primary shield to get the grab
    before setting the session locked (lp: #1368427) (lp: #1371764).
  * added decorations to windows in non-focused workspaces (lp: #1383468)

  [ Stephen M. Webb ]
  * updated the unity(1) manpage to match the actual command (lp: #1059275)
  * bumped package version to match upstream

[ Marco Trevisan (Treviño) ]
* Preparing for unity 7.2.4
-- Ubuntu daily release <email address hidden> Wed, 17 Dec 2014 20:52:10 +0000

This bug was fixed in the package unity - 7.2.4+14.04.20141217-0ubuntu1

---------------
unity (7.2.4+14.04.20141217-0ubuntu1) trusty; urgency=medium

[ Eleni Maria Stea ]
  * LayoutSystem: make sure the exposed open windows are displayed in the
    preserved order (lp: #1349281).

[ handsome_feng ]
  * added support for getting the distro name from /etc/os-release
    (lp: #1329584)

[ Iain Lane ]
  * When grabbing keys, try prefixing "XF86" if the key isn't found. GNOME
    gives us unprefixed keys sometimes (lp: #1302885).

[ Stephen M. Webb ]
  * updated the unity(1) manpage to match the actual command (lp: #1059275)
  * bumped package version to match upstream

[ Marco Trevisan (Treviño) ]
  * Preparing for unity 7.2.4
 -- Ubuntu daily release <ps-jenkins@lists.canonical.com>   Wed, 17 Dec 2014 20:52:10 +0000

Changed in unity (Ubuntu Trusty):
status:	Fix Committed → Fix Released

Revision history for this message

Chris J Arges (arges) wrote on 2015-02-04: Update Released

The verification of the Stable Release Update for unity has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Stephen M. Webb (bregma) on 2015-02-11