"Phone" app settings are oddly in System Settings
Bug #1447601 reported by
Matthew Paul Thomas
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UX |
Fix Committed
|
Medium
|
Olga Kemmet | ||
ubuntu-system-settings |
New
|
Undecided
|
Unassigned | ||
dialer-app (Ubuntu) |
In Progress
|
Low
|
Gustavo Pichorim Boiko | ||
ubuntu-system-settings (Ubuntu) |
In Progress
|
Low
|
Gustavo Pichorim Boiko |
Bug Description
In System Settings, most of the "Phone" settings are about things that happen inside, or (in the case of ringtone) when you are about to use, the Phone app.
Therefore it is weird for those settings to be accessed from System Settings. They should be moved to the Phone app.
[Realized during discussion of bug 1306078.]
<https:/
Related branches
lp://staging/~phablet-team/dialer-app/phone_settings
- Renato Araujo Oliveira Filho (community): Approve
-
Diff: 3554 lines (+2449/-153)58 files modifiedTODO (+1/-0)
debian/dialer-app.install (+1/-0)
po/dialer-app.pot (+253/-111)
src/qml/AccountsModel.qml (+1/-1)
src/qml/CMakeLists.txt (+1/-0)
src/qml/ContactsPage/ContactsPage.qml (+1/-1)
src/qml/ContactsPage/KeyboardRectagle.qml (+1/-1)
src/qml/DialerPage/CallButton.qml (+1/-1)
src/qml/DialerPage/CustomButton.qml (+1/-1)
src/qml/DialerPage/DialerBottomEdge.qml (+1/-1)
src/qml/DialerPage/DialerPage.qml (+12/-3)
src/qml/DialerPage/KeypadButton.qml (+1/-1)
src/qml/DialerPage/KeypadEntry.qml (+1/-1)
src/qml/Dialogs/DisableFlightModeDialog.qml (+1/-1)
src/qml/Dialogs/FlightModeProgressDialog.qml (+1/-1)
src/qml/Dialogs/NoDefaultSIMCardDialog.qml (+1/-1)
src/qml/Dialogs/NotificationDialog.qml (+1/-1)
src/qml/Dialogs/SetDefaultSIMCardDialog.qml (+1/-1)
src/qml/Dialogs/SimLockedDialog.qml (+1/-1)
src/qml/Dialogs/UssdErrorDialog.qml (+1/-1)
src/qml/Dialogs/UssdProgressDialog.qml (+1/-1)
src/qml/Dialogs/UssdResponseDialog.qml (+1/-1)
src/qml/HistoryPage/ExpandableButton.qml (+1/-1)
src/qml/HistoryPage/HistoryDelegate.qml (+1/-1)
src/qml/HistoryPage/HistoryDetailsPage.qml (+1/-1)
src/qml/HistoryPage/HistoryPage.qml (+1/-1)
src/qml/HistoryPage/SwipeItemDemo.qml (+1/-1)
src/qml/InputInfo.qml (+1/-1)
src/qml/LiveCallPage/ConferenceCallDisplay.qml (+1/-1)
src/qml/LiveCallPage/HangupButton.qml (+1/-1)
src/qml/LiveCallPage/LiveCall.qml (+12/-4)
src/qml/LiveCallPage/LiveCallKeypadButton.qml (+1/-1)
src/qml/LiveCallPage/MultiCallDisplay.qml (+1/-1)
src/qml/LiveCallPage/StopWatch.qml (+1/-1)
src/qml/MMI/IMEI.qml (+1/-1)
src/qml/MMI/IMEIDialog.qml (+1/-1)
src/qml/SettingsPage/AccountSettings/CMakeLists.txt (+6/-0)
src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml (+177/-0)
src/qml/SettingsPage/AccountSettings/sip.qml (+30/-0)
src/qml/SettingsPage/CMakeLists.txt (+8/-0)
src/qml/SettingsPage/CallForwardItem.qml (+240/-0)
src/qml/SettingsPage/CallForwarding.qml (+393/-0)
src/qml/SettingsPage/CallWaiting.qml (+108/-0)
src/qml/SettingsPage/KeyboardRectangle.qml (+77/-0)
src/qml/SettingsPage/MultiSim.qml (+113/-0)
src/qml/SettingsPage/NoSims.qml (+46/-0)
src/qml/SettingsPage/Ofono.qml (+69/-0)
src/qml/SettingsPage/OnlineAccountsHelper.qml (+96/-0)
src/qml/SettingsPage/ServiceInfo.qml (+133/-0)
src/qml/SettingsPage/Services.qml (+74/-0)
src/qml/SettingsPage/SettingsItemTitle.qml (+44/-0)
src/qml/SettingsPage/SettingsPage.qml (+158/-0)
src/qml/SettingsPage/SettingsTextField.qml (+29/-0)
src/qml/SettingsPage/SingleSim.qml (+69/-0)
src/qml/SettingsPage/VCardParser.qml (+55/-0)
src/qml/SettingsPage/callForwardingUtils.js (+126/-0)
src/qml/SettingsPage/dateUtils.js (+69/-0)
src/qml/dialer-app.qml (+19/-5)
Superseded
for merging
into
lp://staging/dialer-app
- Renato Araujo Oliveira Filho (community): Needs Fixing
-
Diff: 3160 lines (+2439/-120)28 files modifieddebian/dialer-app.install (+1/-0)
po/dialer-app.pot (+253/-111)
src/qml/CMakeLists.txt (+1/-0)
src/qml/DialerPage/DialerPage.qml (+11/-2)
src/qml/LiveCallPage/LiveCall.qml (+11/-3)
src/qml/SettingsPage/AccountSettings/CMakeLists.txt (+6/-0)
src/qml/SettingsPage/AccountSettings/SipNumberRewrite.qml (+177/-0)
src/qml/SettingsPage/AccountSettings/sip.qml (+30/-0)
src/qml/SettingsPage/CMakeLists.txt (+8/-0)
src/qml/SettingsPage/CallForwardItem.qml (+240/-0)
src/qml/SettingsPage/CallForwarding.qml (+393/-0)
src/qml/SettingsPage/CallWaiting.qml (+108/-0)
src/qml/SettingsPage/KeyboardRectangle.qml (+77/-0)
src/qml/SettingsPage/MultiSim.qml (+113/-0)
src/qml/SettingsPage/NoSims.qml (+46/-0)
src/qml/SettingsPage/Ofono.qml (+69/-0)
src/qml/SettingsPage/OnlineAccountsHelper.qml (+96/-0)
src/qml/SettingsPage/ServiceInfo.qml (+133/-0)
src/qml/SettingsPage/Services.qml (+74/-0)
src/qml/SettingsPage/SettingsItemTitle.qml (+44/-0)
src/qml/SettingsPage/SettingsPage.qml (+158/-0)
src/qml/SettingsPage/SettingsTextField.qml (+29/-0)
src/qml/SettingsPage/SingleSim.qml (+69/-0)
src/qml/SettingsPage/VCardParser.qml (+55/-0)
src/qml/SettingsPage/callForwardingUtils.js (+126/-0)
src/qml/SettingsPage/dateUtils.js (+69/-0)
src/qml/SettingsPage/phone.settings (+24/-0)
src/qml/dialer-app.qml (+18/-4)
lp://staging/~phablet-team/ubuntu-system-settings/remove_dialer_settings
Ready for review
for merging
into
lp://staging/ubuntu-system-settings
- system-apps-ci-bot: Approve (continuous-integration)
- Ubuntu Touch System Settings: Pending requested
-
Diff: 2121 lines (+0/-2004)22 files modifiedplugins/CMakeLists.txt (+0/-1)
plugins/phone/CMakeLists.txt (+0/-29)
plugins/phone/CallForwardItem.qml (+0/-240)
plugins/phone/CallForwarding.qml (+0/-397)
plugins/phone/CallWaiting.qml (+0/-103)
plugins/phone/KeyboardRectangle.qml (+0/-77)
plugins/phone/MultiSim.qml (+0/-120)
plugins/phone/NoSims.qml (+0/-46)
plugins/phone/Ofono.qml (+0/-69)
plugins/phone/PageComponent.qml (+0/-106)
plugins/phone/ServiceInfo.qml (+0/-124)
plugins/phone/Services.qml (+0/-76)
plugins/phone/SingleSim.qml (+0/-74)
plugins/phone/VCardParser.qml (+0/-55)
plugins/phone/callForwardingUtils.js (+0/-126)
plugins/phone/dateUtils.js (+0/-69)
plugins/phone/phone.settings (+0/-24)
plugins/phone/plugin/CMakeLists.txt (+0/-6)
plugins/phone/plugin/phone-plugin.cpp (+0/-83)
plugins/phone/plugin/phone-plugin.h (+0/-38)
plugins/phone/settings-phone.svg (+0/-82)
plugins/phone/sims.js (+0/-59)
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Matthew Paul Thomas (mpt) |
description: | updated |
Changed in ubuntu-system-settings (Ubuntu): | |
importance: | Undecided → Low |
status: | New → Won't Fix |
status: | Won't Fix → Confirmed |
Changed in ubuntu-ux: | |
assignee: | nobody → Olga Kemmet (olga-kemmet) |
importance: | Undecided → Medium |
status: | New → Triaged |
description: | updated |
Changed in ubuntu-ux: | |
assignee: | Olga Kemmet (olga-kemmet) → Matthew Paul Thomas (mpt) |
status: | Fix Committed → In Progress |
status: | In Progress → Fix Committed |
Changed in ubuntu-system-settings (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Gustavo Pichorim Boiko (boiko) |
Changed in dialer-app (Ubuntu): | |
importance: | Undecided → Low |
assignee: | nobody → Gustavo Pichorim Boiko (boiko) |
Changed in ubuntu-system-settings (Ubuntu): | |
status: | Triaged → In Progress |
Changed in dialer-app (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
Marking as fix committed as design solution is provided in the bug description.