two applications mixed into one in OA applications screen
Bug #1384314 reported by
Kyle Nitzsche
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
| Online Accounts setup for Ubuntu Touch |
Fix Released
|
High
|
Alberto Mardegan | ||
| The Savilerow project |
Fix Released
|
High
|
Unassigned | ||
Bug Description
The photos aggregator scope includes the facebook photos scope. The fb scope requires OA authentication and uses the OnlineAccountClient to display a scope result with the button to Login via online accounts when needed.
Naturally, the fb photos scope has an .application file. Photos needs one too and has one in my dev area.
Problem: When the user is in the photos agg scope and clicks the fb photos child scope's Login button, it works, but when you view the Facebook account in System Settings > Online Accounts on touch, the two applications are merged into one, with layers of text and a single checkbox (for enabling, disabling).
Please see attached png.
Expectation:
System Settings > Accounts > Facebook displays separate entries for every application using the service.
Related branches
lp://staging/~mardy/ubuntu-system-settings-online-accounts/lp1384314
Merged
into
lp://staging/~online-accounts/ubuntu-system-settings-online-accounts/master
at
revision 220
- David Barth (community): Approve
-
Diff: 20 lines (+1/-2)1 file modifiedplugins/module/ServiceItem.qml (+1/-2)
lp://staging/~mardy/ubuntu-system-settings-online-accounts/rtm-fixes
- David Barth (community): Approve
-
Diff: 1412 lines (+753/-50)27 files modifieddebian/changelog (+11/-0)
debian/control (+1/-0)
online-accounts-service/mir-helper-stub.cpp (+2/-2)
online-accounts-service/mir-helper.cpp (+23/-12)
online-accounts-service/mir-helper.h (+4/-1)
online-accounts-service/request.cpp (+15/-1)
online-accounts-service/request.h (+3/-0)
online-accounts-service/ui-proxy.cpp (+24/-12)
online-accounts-ui/dialog-request.cpp (+286/-0)
online-accounts-ui/dialog-request.h (+54/-0)
online-accounts-ui/ipc.h (+1/-0)
online-accounts-ui/online-accounts-ui.pro (+3/-0)
online-accounts-ui/provider-request.cpp (+7/-11)
online-accounts-ui/qml/ProviderRequest.qml (+14/-0)
online-accounts-ui/qml/SignOnUiDialog.qml (+115/-0)
online-accounts-ui/request.cpp (+15/-1)
online-accounts-ui/request.h (+2/-0)
online-accounts-ui/signonui-request.cpp (+32/-2)
online-accounts-ui/ui-server.cpp (+1/-0)
online-accounts-ui/ui.qrc (+1/-0)
plugins/OnlineAccountsPlugin/application-manager.cpp (+11/-1)
plugins/module/ServiceItem.qml (+1/-2)
tests/online-accounts-service/mock/request-mock.cpp (+13/-0)
tests/online-accounts-service/mock/request-mock.h (+1/-0)
tests/online-accounts-service/tst_ui_proxy.cpp (+71/-1)
tests/online-accounts-ui/tst_signonui_request.pro (+1/-0)
tests/plugin/tst_application_manager.cpp (+41/-4)
Revision history for this message
| Kyle Nitzsche (knitzsche) wrote | #1 |
| summary: |
- two applications mixed into one in oa FB on touch + two applications mixed into one in OA FB on touch |
| Changed in ubuntu-system-settings-online-accounts: | |
| status: | New → Confirmed |
Revision history for this message
| Chris Wayne (cwayne) wrote | #2 |
| Changed in savilerow: | |
| status: | New → Confirmed |
| summary: |
- two applications mixed into one in OA FB on touch + two applications mixed into one in OA applications screen |
| Changed in savilerow: | |
| importance: | Undecided → High |
| Changed in canonical-devices-system-image: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
| milestone: | none → ww05-2015 |
Revision history for this message
| Alberto Mardegan (mardy) wrote | #3 |
| Changed in ubuntu-system-settings-online-accounts: | |
| assignee: | nobody → Alberto Mardegan (mardy) |
| importance: | Undecided → High |
| status: | Confirmed → In Progress |
| Changed in ubuntu-system-settings-online-accounts: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Timo Jyrinki (timo-jyrinki) wrote | #4 |
| Changed in ubuntu-system-settings-online-accounts: | |
| status: | Fix Committed → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Released |
| Changed in savilerow: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
We're seeing this 100% of the time now when adding an online account from an aggregator scope. That is, both the child scope (say fitbit) and the aggregator (today) both have a .application file, and we grant access from the aggregator