Ubuntu system image

There is no way to stop a check for update for ubuntu images

Bug #1272313 reported by Diego Sarmentero
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu system image
Triaged
Low
Unassigned
ubuntu-system-settings (Ubuntu)
Fix Committed
Low
Unassigned

Bug Description

The designs requires to stop the process of "checking for updates".
But the system image update service doesn't provide anyway to call a function to do that.

<https://wiki.ubuntu.com/SoftwareUpdates#check-interactive-mobile>: "At the top of the screen (replacing the “Install All” button, if it was present) should be a “Checking for updates…” spinner and a “Stop” button."

See original description
Tags: client updates

Related branches

lp://staging/~jonas-drange/ubuntu-system-settings/updates-rewrite
system-apps-ci-bot: Needs Fixing (continuous-integration)
Ken VanDine: Needs Fixing
Matthew Paul Thomas: Pending (design) requested
PS Jenkins bot: Pending (continuous-integration) requested
Diff: 19868 lines (+13831/-3824)
170 files modified
debian/control (+4/-2)
plugins/about/CMakeLists.txt (+2/-1)
plugins/about/PageComponent.qml (+10/-8)
plugins/about/Version.qml (+6/-7)
plugins/about/plugin.cpp (+10/-0)
plugins/cellular/Components/MultiSim.qml (+0/-5)
plugins/system-update/CMakeLists.txt (+67/-22)
plugins/system-update/ChangelogExpander.qml (+77/-0)
plugins/system-update/ClickUpdateDelegate.qml (+26/-0)
plugins/system-update/Configuration.qml (+3/-3)
plugins/system-update/DownloadHandler.qml (+204/-0)
plugins/system-update/EntryComponent.qml (+24/-19)
plugins/system-update/Global.qml (+142/-0)
plugins/system-update/ImageUpdatePrompt.qml (+52/-0)
plugins/system-update/InstallationFailed.qml (+34/-0)
plugins/system-update/NotAuthenticatedNotification.qml (+62/-0)
plugins/system-update/PageComponent.qml (+400/-679)
plugins/system-update/UpdateDelegate.qml (+412/-0)
plugins/system-update/click/apiclient.h (+67/-0)
plugins/system-update/click/apiclient_impl.cpp (+215/-0)
plugins/system-update/click/apiclient_impl.h (+56/-0)
plugins/system-update/click/manager.h (+67/-0)
plugins/system-update/click/manager_impl.cpp (+562/-0)
plugins/system-update/click/manager_impl.h (+122/-0)
plugins/system-update/click/manifest.h (+47/-0)
plugins/system-update/click/manifest_impl.cpp (+97/-0)
plugins/system-update/click/manifest_impl.h (+47/-0)
plugins/system-update/click/sessiontoken.h (+42/-0)
plugins/system-update/click/sessiontoken_impl.cpp (+48/-0)
plugins/system-update/click/sessiontoken_impl.h (+48/-0)
plugins/system-update/click/sso.h (+56/-0)
plugins/system-update/click/sso_impl.cpp (+55/-0)
plugins/system-update/click/sso_impl.h (+54/-0)
plugins/system-update/click/tokendownloader.h (+74/-0)
plugins/system-update/click/tokendownloader_factory.h (+44/-0)
plugins/system-update/click/tokendownloader_factory_impl.cpp (+36/-0)
plugins/system-update/click/tokendownloader_factory_impl.h (+37/-0)
plugins/system-update/click/tokendownloader_impl.cpp (+81/-0)
plugins/system-update/click/tokendownloader_impl.h (+47/-0)
plugins/system-update/download_tracker.cpp (+0/-204)
plugins/system-update/download_tracker.h (+0/-106)
plugins/system-update/helpers.cpp (+108/-0)
plugins/system-update/helpers.h (+47/-0)
plugins/system-update/image/imagemanager.h (+46/-0)
plugins/system-update/image/imagemanager_impl.cpp (+188/-0)
plugins/system-update/image/imagemanager_impl.h (+67/-0)
plugins/system-update/network.cpp (+0/-314)
plugins/system-update/network.h (+0/-85)
plugins/system-update/network/accessmanager.h (+46/-0)
plugins/system-update/network/accessmanager_impl.cpp (+47/-0)
plugins/system-update/network/accessmanager_impl.h (+41/-0)
plugins/system-update/plugin.cpp (+31/-17)
plugins/system-update/plugin.h (+0/-1)
plugins/system-update/plugin/CMakeLists.txt (+0/-14)
plugins/system-update/plugin/update-plugin.cpp (+0/-98)
plugins/system-update/plugin/update-plugin.h (+0/-39)
plugins/system-update/qmldir (+0/-2)
plugins/system-update/qmldir.in (+2/-0)
plugins/system-update/system_update.cpp (+0/-281)
plugins/system-update/system_update.h (+0/-106)
plugins/system-update/update-notification.settings (+1/-2)
plugins/system-update/update.cpp (+0/-179)
plugins/system-update/update.h (+0/-161)
plugins/system-update/update_manager.cpp (+0/-398)
plugins/system-update/update_manager.h (+0/-181)
plugins/system-update/updatedb.cpp (+418/-0)
plugins/system-update/updatedb.h (+77/-0)
plugins/system-update/updatemanager.cpp (+217/-0)
plugins/system-update/updatemanager.h (+120/-0)
plugins/system-update/updatemodel.cpp (+597/-0)
plugins/system-update/updatemodel.h (+177/-0)
src/CMakeLists.txt (+12/-4)
src/systemimage.cpp (+487/-0)
src/systemimage.h (+196/-0)
tests/CMakeLists.txt (+21/-2)
tests/autopilot/ubuntu_system_settings/__init__.py (+4/-0)
tests/autopilot/ubuntu_system_settings/tests/__init__.py (+29/-1)
tests/autopilot/ubuntu_system_settings/tests/systemimage.py (+71/-37)
tests/autopilot/ubuntu_system_settings/tests/test_system_updates.py (+3/-100)
tests/autopilot/ubuntu_system_settings/utils/mock_update_click_server.py (+74/-28)
tests/mocks/CMakeLists.txt (+1/-0)
tests/mocks/QMenuModel/CMakeLists.txt (+25/-0)
tests/mocks/QMenuModel/QDBusActionGroup.qml (+52/-0)
tests/mocks/QMenuModel/actiondata.h (+54/-0)
tests/mocks/QMenuModel/actionstateparser.cpp (+19/-0)
tests/mocks/QMenuModel/actionstateparser.h (+35/-0)
tests/mocks/QMenuModel/dbus-enums.h (+52/-0)
tests/mocks/QMenuModel/plugin.cpp (+40/-0)
tests/mocks/QMenuModel/plugin.h (+34/-0)
tests/mocks/QMenuModel/qmldir (+4/-0)
tests/mocks/Ubuntu/CMakeLists.txt (+3/-0)
tests/mocks/Ubuntu/Connectivity/CMakeLists.txt (+15/-0)
tests/mocks/Ubuntu/Connectivity/MockNetworkingStatus.cpp (+83/-0)
tests/mocks/Ubuntu/Connectivity/MockNetworkingStatus.h (+78/-0)
tests/mocks/Ubuntu/Connectivity/plugin.cpp (+40/-0)
tests/mocks/Ubuntu/Connectivity/plugin.h (+36/-0)
tests/mocks/Ubuntu/Connectivity/qmldir (+2/-0)
tests/mocks/Ubuntu/DownloadManager/CMakeLists.txt (+17/-0)
tests/mocks/Ubuntu/DownloadManager/MockDownloadManager.cpp (+90/-0)
tests/mocks/Ubuntu/DownloadManager/MockDownloadManager.h (+68/-0)
tests/mocks/Ubuntu/DownloadManager/MockMetadata.cpp (+73/-0)
tests/mocks/Ubuntu/DownloadManager/MockMetadata.h (+64/-0)
tests/mocks/Ubuntu/DownloadManager/MockSingleDownload.cpp (+206/-0)
tests/mocks/Ubuntu/DownloadManager/MockSingleDownload.h (+113/-0)
tests/mocks/Ubuntu/DownloadManager/plugin.cpp (+31/-0)
tests/mocks/Ubuntu/DownloadManager/plugin.h (+31/-0)
tests/mocks/Ubuntu/DownloadManager/qmldir (+2/-0)
tests/mocks/Ubuntu/OnlineAccounts/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/CMakeLists.txt (+19/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/MockSetup.cpp (+59/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/MockSetup.h (+59/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/plugin.cpp (+29/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/plugin.h (+33/-0)
tests/mocks/Ubuntu/OnlineAccounts/Client/qmldir (+2/-0)
tests/mocks/Ubuntu/SystemSettings/CMakeLists.txt (+1/-0)
tests/mocks/Ubuntu/SystemSettings/Update/CMakeLists.txt (+31/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemImage.cpp (+120/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockSystemImage.h (+91/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateManager.cpp (+48/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateManager.h (+39/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateModel.cpp (+44/-0)
tests/mocks/Ubuntu/SystemSettings/Update/MockUpdateModel.h (+48/-0)
tests/mocks/Ubuntu/SystemSettings/Update/plugin.cpp (+62/-0)
tests/mocks/Ubuntu/SystemSettings/Update/plugin.h (+33/-0)
tests/mocks/Ubuntu/SystemSettings/Update/qmldir (+2/-0)
tests/mocks/plugins/system-update/fakeapiclient.h (+78/-0)
tests/mocks/plugins/system-update/fakeclickmanager.h (+96/-0)
tests/mocks/plugins/system-update/fakeimagemanager.h (+59/-0)
tests/mocks/plugins/system-update/fakemanifest.h (+52/-0)
tests/mocks/plugins/system-update/fakesessiontoken.h (+53/-0)
tests/mocks/plugins/system-update/fakesso.h (+62/-0)
tests/mocks/plugins/system-update/faketokendownloader.h (+69/-0)
tests/mocks/plugins/system-update/faketokendownloader_factory.h (+52/-0)
tests/mocks/system-image-dbus/fakesystemimagedbus.cpp (+45/-0)
tests/mocks/system-image-dbus/fakesystemimagedbus.h (+64/-0)
tests/plugins/CMakeLists.txt (+35/-6)
tests/plugins/security-privacy/CMakeLists.txt (+1/-1)
tests/plugins/system-update/CMakeLists.txt (+81/-54)
tests/plugins/system-update/Source/qmldir (+9/-0)
tests/plugins/system-update/click.result (+12/-3)
tests/plugins/system-update/fakenetwork.cpp (+0/-50)
tests/plugins/system-update/fakenetwork.h (+0/-60)
tests/plugins/system-update/fakeprocess.cpp (+0/-63)
tests/plugins/system-update/fakeprocess.h (+0/-48)
tests/plugins/system-update/fakessoservice.cpp (+0/-27)
tests/plugins/system-update/fakessoservice.h (+0/-35)
tests/plugins/system-update/fakesystemupdate.cpp (+0/-28)
tests/plugins/system-update/fakesystemupdate.h (+0/-68)
tests/plugins/system-update/mockclickcommand (+15/-0)
tests/plugins/system-update/mockclickserver.h (+57/-0)
tests/plugins/system-update/mockclickserver.py (+220/-0)
tests/plugins/system-update/tst_clickclient.cpp (+165/-0)
tests/plugins/system-update/tst_clickmanager.cpp (+548/-0)
tests/plugins/system-update/tst_clickmanifest.cpp (+100/-0)
tests/plugins/system-update/tst_helpers.cpp (+71/-0)
tests/plugins/system-update/tst_imagemanager.cpp (+269/-0)
tests/plugins/system-update/tst_network.cpp (+0/-58)
tests/plugins/system-update/tst_systemupdate_download_handler.qml (+230/-0)
tests/plugins/system-update/tst_systemupdate_entrycomponent.qml (+108/-0)
tests/plugins/system-update/tst_systemupdate_global.qml (+297/-0)
tests/plugins/system-update/tst_systemupdate_noauthentication.qml (+71/-0)
tests/plugins/system-update/tst_systemupdate_pagecomponent.qml (+388/-0)
tests/plugins/system-update/tst_systemupdate_update.qml (+374/-0)
tests/plugins/system-update/tst_systemupdate_update_visuals.qml (+219/-0)
tests/plugins/system-update/tst_tokendownloader.cpp (+107/-0)
tests/plugins/system-update/tst_update.cpp (+0/-55)
tests/plugins/system-update/tst_updatedb.cpp (+303/-0)
tests/plugins/system-update/tst_updatemanager.cpp (+0/-162)
tests/plugins/system-update/tst_updatemodel.cpp (+681/-0)
tests/tst_systemimage.cpp (+287/-0)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report.

Hey Matthew, what would you recommend doing in the UI if we can't stop the check, just not have a button I guess?

Barry, I'm added the system image component to the bug, the design has a "stop" button for "check update", it might be a feature to add to the service?

Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Matthew Paul Thomas (mpt)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

What do you mean by "can't stop the check"? I understand why the ability to stop might not be implemented yet, but I don't see why it would be impossible to implement.

Compare the installation of packages in Ubuntu Software Center: even though the installation is performed by a separate service (aptdaemon), a Stop button is still present in the Progress screen.

Revision history for this message
Manuel de la Peña (mandel) wrote :

> What do you mean by "can't stop the check"? I understand why the ability to stop might not be implemented yet, but I don't see
> why it would be impossible to implement.
>
> Compare the installation of packages in Ubuntu Software Center: even though the installation is performed by a separate
> service (aptdaemon), a Stop button is still present in the Progress screen.

Probably means that there is no dbus method to stop the check and therefore cannot be stopped with the current implementation of the dbus service from the system-image-updates. Therefore there is going to be some time in which this feature in system settings cannot be implemented until a patch is sent to the code that really deals with updates.

I have talked with barry and the check is an operation with several steps and adding such a feature (cancelling/stopping the check) might take some time to land. Is not impossible and we should do it, is just hard and will take time and a possible plan B should be considered.

Diego, am I wrong?

Revision history for this message
Barry Warsaw (barry) wrote : Re: [Bug 1272313] Re: There is no way to stop a check for update for ubuntu images

On Feb 03, 2014, at 12:11 PM, Manuel de la Peña wrote:

>I have talked with barry and the check is an operation with several
>steps and adding such a feature (cancelling/stopping the check) might
>take some time to land. Is not impossible and we should do it, is just
>hard and will take time and a possible plan B should be considered.

Checking for whether an update is available is a complicated, multi-step
process. For example, there are potentially 4 gpg keyring files that must be
present, but only one that is shipped with the image, so the "check for update
available" process must be able to backtrack and download any missing keys.
It's surprisingly complicated!

The biggest challenge with adding a stop method during update available checks
is that all the various combinations and backtracking must be tested, so
that's a lot of additionally complicated test code to add. It's not
insurmountable -- I just have to find the cycles to tackle it.

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

If checking for an update is a multi-step process, that's excellent news, because it means the progress display can be determinate rather than just a spinner. Like the ability to stop, I guess that would require an extra dbus method to ask "how far through are you right now". Reported bug 1276061 for that.

In the meantime, let's treat the Stop button the same as anything else in System Settings that isn't implemented: don't show the UI until it is implemented.

Matthew Paul Thomas (mpt)
Changed in ubuntu-system-settings (Ubuntu):
assignee: Matthew Paul Thomas (mpt) → nobody
Revision history for this message
Barry Warsaw (barry) wrote :

On Feb 04, 2014, at 09:38 AM, Matthew Paul Thomas wrote:

>If checking for an update is a multi-step process, that's excellent
>news, because it means the progress display can be determinate rather
>than just a spinner. Like the ability to stop, I guess that would
>require an extra dbus method to ask "how far through are you right now".
>Reported bug 1276061 for that.

The tricky part is that we won't know how many steps are involved ahead of
time. For example, let's say we have three of the four keys already when we
start the check. The first thing we do is download the blacklist, and if one
of the three keys is now on the blacklist, we'll have an extra step to
download a replacement. Also, it's possible that once we've downloaded the
first key, it might make subsequent key checks fail validation.

There's an upper limit to the number of things we have to download during the
check though, so we could just emit something like:

step 1 of 7
step 2 of 7
(steps 3-5 can be skipped so...)
step 6 of 7
step 7 of 7

It might make the display a bit jumpy, but it would be feasible without much
work. For backward compatibility we'd have to add new dbus signals for these
progress steps.

Matthew Paul Thomas (mpt)
description: updated
Changed in ubuntu-system-settings (Ubuntu):
status: Confirmed → Triaged
Barry Warsaw (barry)
tags: added: client
Barry Warsaw (barry)
Changed in ubuntu-system-image:
status: New → Triaged
importance: Undecided → Low
Pat McGowan (pat-mcgowan)
tags: added: updates
Jonas G. Drange (jonas-drange)
Changed in ubuntu-system-settings (Ubuntu):
status: Triaged → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.