TextArea cursor does not regard font size
Bug #1391335 reported by
Michael Zanetti
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Medium
|
Cris Dywan | ||
Vivid |
New
|
Undecided
|
Unassigned | ||
ubuntu-ui-toolkit (Ubuntu RTM) |
New
|
Undecided
|
Unassigned |
Bug Description
Set this html text to a TextArea:
<!DOCTYPE html><html>
<p style=" margin-top:0px; margin-bottom:0px; margin-left:0px; margin-right:0px; padding-left:0px; text-indent:
move the cursor between the different sized text elements.
Actual:
The cursor stays the same
Expected:
The cursor should scale with the text size
Related branches
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/textHandlerCleanUpRTM
Rejected
for merging
into
lp://staging/ubuntu-ui-toolkit/rtm
- Zsombor Egri: Approve
-
Diff: 1349 lines (+395/-290)25 files modifiedexamples/ubuntu-ui-toolkit-gallery/TextInputs.qml (+5/-2)
modules/Ubuntu/Components/InputHandler.qml (+15/-37)
modules/Ubuntu/Components/TextArea.qml (+3/-5)
modules/Ubuntu/Components/TextCursor.qml (+70/-67)
modules/Ubuntu/Components/TextField.qml (+5/-9)
modules/Ubuntu/Components/TextInputPopover.qml (+6/-3)
modules/Ubuntu/Components/Themes/Ambiance/SelectionCursorStyle.qml (+0/-92)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+5/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextFieldStyle.qml (+1/-0)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarButtonStyle.qml (+3/-3)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-3)
modules/Ubuntu/Components/plugin/quickutils.cpp (+4/-1)
modules/Ubuntu/Components/plugin/quickutils.h (+1/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/popups.py (+5/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml (+69/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+42/-24)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml (+10/-1)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml (+11/-1)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml (+47/-12)
tests/launcher/launcher.cpp (+5/-3)
tests/unit/tst_quickutils/tst_quickutils.cpp (+60/-0)
tests/unit/tst_quickutils/tst_quickutils.pro (+2/-0)
tests/unit/unit.pro (+2/-1)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+22/-6)
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/textHandlerCleanUpVivid
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 1199 lines (+276/-291)19 files modifiedexamples/ubuntu-ui-toolkit-gallery/TextInputs.qml (+5/-2)
modules/Ubuntu/Components/InputHandler.qml (+15/-37)
modules/Ubuntu/Components/TextArea.qml (+3/-5)
modules/Ubuntu/Components/TextCursor.qml (+70/-67)
modules/Ubuntu/Components/TextField.qml (+5/-9)
modules/Ubuntu/Components/TextInputPopover.qml (+6/-3)
modules/Ubuntu/Components/Themes/Ambiance/SelectionCursorStyle.qml (+0/-92)
modules/Ubuntu/Components/Themes/Ambiance/TextAreaStyle.qml (+2/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+5/-10)
modules/Ubuntu/Components/Themes/Ambiance/TextFieldStyle.qml (+1/-0)
modules/Ubuntu/Components/Themes/Ambiance/ToolbarButtonStyle.qml (+3/-3)
modules/Ubuntu/Components/Themes/Ambiance/qmldir (+0/-3)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/popups.py (+5/-0)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.header.qml (+43/-3)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.py (+34/-24)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textarea.qml (+6/-2)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield.qml (+7/-2)
tests/autopilot/ubuntuuitoolkit/tests/components/test_textinput.textfield_custom.qml (+44/-13)
tests/unit_x11/tst_components/tst_textinput_touch.qml (+22/-6)
Changed in ubuntu-ui-toolkit: | |
assignee: | nobody → Christian Dywan (kalikiana) |
status: | New → Confirmed |
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Medium |
status: | Confirmed → In Progress |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
assignee: | nobody → Christian Dywan (kalikiana) |
importance: | Undecided → Medium |
status: | New → In Progress |
no longer affects: | ubuntu-ui-toolkit |
Changed in ubuntu-ui-toolkit (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
I pushed a branch for making the cursor change size depending on the cursor height. Note that apparently QML's TextInput always assumes the largest font size in any one line. So it seems this requires an additional upstream fix to work as requested.