Alarm Model is refreshed after creating/deleting an alarm
Bug #1380553 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
High
|
Zsombor Egri | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
| ubuntu-ui-toolkit (Ubuntu RTM) |
New
|
Undecided
|
Unassigned | ||
Bug Description
When creating a new alarm or deleting an existing alarm, the entire alarm model is refreshed which causes the listview showing the alarms to be repainted as well. This causes a glaring ui refresh since doing either of the tasks mentioned will result in the alarm switches to reset and then be set to the correct position which is a bad experience for the user. I was requested by design to check if this can be avoided.
This is strongly correlated to bug 1359112 where one use case has been fixed which is editing and saving an alarm avoids refreshing the entire alarm model.
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-data-adaptation
- PS Jenkins bot: Approve (continuous-integration)
- Cris Dywan: Approve
-
Diff: 4045 lines (+1417/-1493)18 files modifiedmodules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+540/-478)
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_p.h (+115/-33)
modules/Ubuntu/Components/plugin/alarmmanager_p.cpp (+36/-19)
modules/Ubuntu/Components/plugin/alarmmanager_p.h (+55/-107)
modules/Ubuntu/Components/plugin/alarmmanager_p_p.h (+13/-6)
modules/Ubuntu/Components/plugin/alarmrequest_p.cpp (+0/-84)
modules/Ubuntu/Components/plugin/alarmrequest_p.h (+0/-64)
modules/Ubuntu/Components/plugin/alarmrequest_p_p.h (+0/-50)
modules/Ubuntu/Components/plugin/plugin.pro (+0/-3)
modules/Ubuntu/Components/plugin/ucalarm.cpp (+128/-173)
modules/Ubuntu/Components/plugin/ucalarm.h (+6/-2)
modules/Ubuntu/Components/plugin/ucalarm_p.h (+27/-7)
modules/Ubuntu/Components/plugin/ucalarmmodel.cpp (+118/-93)
modules/Ubuntu/Components/plugin/ucalarmmodel.h (+16/-10)
tests/resources/alarm/AlarmDays.qml (+15/-24)
tests/resources/alarm/Alarms.qml (+174/-148)
tests/unit/tst_alarms/tst_alarms.cpp (+130/-167)
tests/unit_x11/tst_components/tst_alarms.qml (+44/-25)
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Zsombor Egri (zsombi) |
| Changed in ubuntu-ui-toolkit: | |
| status: | Triaged → In Progress |
| tags: | added: rtm14 |
| Changed in ubuntu-ui-toolkit: | |
| milestone: | none → 11.07 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → High |
| status: | New → In Progress |
| no longer affects: | ubuntu-ui-toolkit |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+
---------------
ubuntu-ui-toolkit (1.1.1347+
[ Zsombor Egri ]
* Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
Fixes LP: #1380559
* Alarm adaptation refactored to support change granular model
updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
LP: #1380553
* Fix Header thin divider margins, restored to original no-margins.
Fixes LP: #1380766.
[ Tim Peeters ]
* Add ensure_visible() function to header AP helper.
Fixes LP: #1363591
[ Albert Astals Cid ]
* Add context support for i18n.tr calls. This allows to have strings
like "All" translated to two different strings in the translated
language if different contexts are given. Fixes LP: #1394904
-- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000