Ubuntu RTM
ubuntu-ui-toolkit package

Reset an alarm doesn't return the properties to their default values

Bug #1370649 reported by Leo Arias
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Critical
Zsombor Egri
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
New
Undecided
Unassigned

Bug Description

When I reset a repeating alarm with multiple daysOfWeek set, daysOfWeek is not reset to Alarm.AutoDetect.

To reproduce:
Apply the patch in http://paste.ubuntu.com/8366602/ and run the tests.

FAIL! : qmltestrunner::AlarmAPI::test_resetAlarmMustSetDefaultPropertiesValues() property daysOfWeek
   Actual (): 4
   Expected (): 128
   Loc: [/home/elopio/workspace/canonical/ubuntu-ui-toolkit/trunk/tests/unit_x11/tst_components/tst_alarms.qml(266)]

Tags: alarm nik90

Related branches

lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-data-adaptation
PS Jenkins bot: Approve (continuous-integration)
Cris Dywan: Approve
Diff: 4045 lines (+1417/-1493)
18 files modified
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+540/-478)
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_p.h (+115/-33)
modules/Ubuntu/Components/plugin/alarmmanager_p.cpp (+36/-19)
modules/Ubuntu/Components/plugin/alarmmanager_p.h (+55/-107)
modules/Ubuntu/Components/plugin/alarmmanager_p_p.h (+13/-6)
modules/Ubuntu/Components/plugin/alarmrequest_p.cpp (+0/-84)
modules/Ubuntu/Components/plugin/alarmrequest_p.h (+0/-64)
modules/Ubuntu/Components/plugin/alarmrequest_p_p.h (+0/-50)
modules/Ubuntu/Components/plugin/plugin.pro (+0/-3)
modules/Ubuntu/Components/plugin/ucalarm.cpp (+128/-173)
modules/Ubuntu/Components/plugin/ucalarm.h (+6/-2)
modules/Ubuntu/Components/plugin/ucalarm_p.h (+27/-7)
modules/Ubuntu/Components/plugin/ucalarmmodel.cpp (+118/-93)
modules/Ubuntu/Components/plugin/ucalarmmodel.h (+16/-10)
tests/resources/alarm/AlarmDays.qml (+15/-24)
tests/resources/alarm/Alarms.qml (+174/-148)
tests/unit/tst_alarms/tst_alarms.cpp (+130/-167)
tests/unit_x11/tst_components/tst_alarms.qml (+44/-25)
lp://staging/ubuntu/vivid-proposed/ubuntu-ui-toolkit
Nekhelesh Ramananthan (nik90)
tags: added: alarm nik90
Revision history for this message
Zsombor Egri (zsombi) wrote :

Indeed the default value should be AutoDetect, but actually that one we cannot really keep. As the AutoDetect should update daysOfWeek immediately when set. Meaning that when someone sets that as value for daysOfWeek, and immediately checks the value of the property, it should never return AutoDetect alone, but a masked dsysOfWeek depending on the alarm date and type.

So in that sense the paste bin test is wrong.

Changed in ubuntu-ui-toolkit:
status: New → Confirmed
assignee: nobody → Zsombor Egri (zsombi)
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: Undecided → Low
Revision history for this message
Zsombor Egri (zsombi) wrote :

Thinking a bit on the topic, I think you are right, if the alarm default dow is auto detect, then we should return to that, and not keep on a specific date as AutoDetect dow depends on the date set. Raising importance to high.

Changed in ubuntu-ui-toolkit:
importance: Low → High
status: Confirmed → In Progress
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: High → Critical
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
milestone: none → 11.07
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → Critical
status: New → In Progress
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+15.04.20141126-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1347+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
    Fixes LP: #1380559
  * Alarm adaptation refactored to support change granular model
    updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
    LP: #1380553
  * Fix Header thin divider margins, restored to original no-margins.
    Fixes LP: #1380766.

  [ Tim Peeters ]
  * Add ensure_visible() function to header AP helper.
    Fixes LP: #1363591

  [ Albert Astals Cid ]
  * Add context support for i18n.tr calls. This allows to have strings
    like "All" translated to two different strings in the translated
    language if different contexts are given. Fixes LP: #1394904
 -- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.