Ubuntu RTM
ubuntu-ui-toolkit package

[Performance] Alarm Model is reloaded after creating/deleting an alarm instead of just appending to it causing unnecessary listview repaint

Bug #1360359 reported by Nekhelesh Ramananthan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Medium
Unassigned
Vivid
New
Undecided
Unassigned
ubuntu-ui-toolkit (Ubuntu RTM)
New
Undecided
Unassigned

Bug Description

Once https://code.launchpad.net/~zsombi/ubuntu-ui-toolkit/30-alarm-update-fix has landed, when you create/delete an alarm, you will notice that the entire list view is repainted due to the alarm model being refreshed. It would better performance and user experience wise to just append to alarm model since it can be a bit jarring for the user to see all the alarm switched being reinitialized after creating/deleting an alarm.

It is not critical, but could perhaps be considered as Medium Priority bug.

Related branches

lp://staging/~zsombi/ubuntu-ui-toolkit/alarm-data-adaptation
PS Jenkins bot: Approve (continuous-integration)
Cris Dywan: Approve
Diff: 4045 lines (+1417/-1493)
18 files modified
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_organizer.cpp (+540/-478)
modules/Ubuntu/Components/plugin/adapters/alarmsadapter_p.h (+115/-33)
modules/Ubuntu/Components/plugin/alarmmanager_p.cpp (+36/-19)
modules/Ubuntu/Components/plugin/alarmmanager_p.h (+55/-107)
modules/Ubuntu/Components/plugin/alarmmanager_p_p.h (+13/-6)
modules/Ubuntu/Components/plugin/alarmrequest_p.cpp (+0/-84)
modules/Ubuntu/Components/plugin/alarmrequest_p.h (+0/-64)
modules/Ubuntu/Components/plugin/alarmrequest_p_p.h (+0/-50)
modules/Ubuntu/Components/plugin/plugin.pro (+0/-3)
modules/Ubuntu/Components/plugin/ucalarm.cpp (+128/-173)
modules/Ubuntu/Components/plugin/ucalarm.h (+6/-2)
modules/Ubuntu/Components/plugin/ucalarm_p.h (+27/-7)
modules/Ubuntu/Components/plugin/ucalarmmodel.cpp (+118/-93)
modules/Ubuntu/Components/plugin/ucalarmmodel.h (+16/-10)
tests/resources/alarm/AlarmDays.qml (+15/-24)
tests/resources/alarm/Alarms.qml (+174/-148)
tests/unit/tst_alarms/tst_alarms.cpp (+130/-167)
tests/unit_x11/tst_components/tst_alarms.qml (+44/-25)
lp://staging/ubuntu/vivid-proposed/ubuntu-ui-toolkit
Nekhelesh Ramananthan (nik90)
summary: [Performance] Alarm Model is reloaded after creating/deleting an alarm
- instead of just appeding to it causing unnecessary listview repaint
+ instead of just appending to it causing unnecessary listview repaint
Revision history for this message
Zsombor Egri (zsombi) wrote :

The biggest issue is that it is not necessarily an append. It can be that the added item must be inserted in order to match the next fetch order. Deletion is simple.

Changed in ubuntu-ui-toolkit:
importance: Undecided → Medium
status: New → Confirmed
Zsombor Egri (zsombi)
tags: added: alarm-services
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
importance: Undecided → Medium
status: New → In Progress
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1347+15.04.20141126-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1347+15.04.20141126-0ubuntu1) vivid; urgency=medium

  [ Zsombor Egri ]
  * Expose refresh() function in revision 1 (Ubuntu.Components 1.1).
    Fixes LP: #1380559
  * Alarm adaptation refactored to support change granular model
    updates. Fixes LP: #1322558, LP: #1360359, LP: #1370649,
    LP: #1380553
  * Fix Header thin divider margins, restored to original no-margins.
    Fixes LP: #1380766.

  [ Tim Peeters ]
  * Add ensure_visible() function to header AP helper.
    Fixes LP: #1363591

  [ Albert Astals Cid ]
  * Add context support for i18n.tr calls. This allows to have strings
    like "All" translated to two different strings in the translated
    language if different contexts are given. Fixes LP: #1394904
 -- Ubuntu daily release <email address hidden> Wed, 26 Nov 2014 08:33:25 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.